Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fixing results service space checks #124707

Merged
merged 2 commits into from
Feb 7, 2022
Merged

[ML] Fixing results service space checks #124707

merged 2 commits into from
Feb 7, 2022

Conversation

jgowdyelastic
Copy link
Member

All searches in results service and top categories should supply the job ids for additional space checks.

@jgowdyelastic jgowdyelastic added release_note:fix :ml Feature:Anomaly Detection ML anomaly detection auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 v8.2.0 v8.0.1 v7.17.1 labels Feb 4, 2022
@jgowdyelastic jgowdyelastic self-assigned this Feb 4, 2022
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner February 4, 2022 16:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

This was referenced Feb 7, 2022
Merged
Closed
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

darnautov
darnautov approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

peteharverson
peteharverson approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic jgowdyelastic merged commit afb458e into elastic:main Feb 7, 2022
@jgowdyelastic jgowdyelastic deleted the fixing-results-service-space-checks branch February 7, 2022 15:26
@kibanamachine kibanamachine mentioned this pull request Feb 7, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 7, 2022
@jgowdyelastic @kibanamachine
[ML] Fixing results service space checks (elastic#124707)
c814bcd 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit afb458e)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 7, 2022
@jgowdyelastic @kibanamachine
[ML] Fixing results service space checks (elastic#124707)
3173de4 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit afb458e)
@kibanamachine kibanamachine mentioned this pull request Feb 7, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 7, 2022
@jgowdyelastic @kibanamachine
[ML] Fixing results service space checks (elastic#124707)
231cf44 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit afb458e)
@kibanamachine kibanamachine mentioned this pull request Feb 7, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.1
✅ 8.0
✅ 7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 7, 2022
@kibanamachine @jgowdyelastic
[ML] Fixing results service space checks (#124707) (#124834)
5cc6b2b 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit afb458e)

Co-authored-by: James Gowdy <jgowdy@elastic.co>
kibanamachine added a commit that referenced this pull request Feb 7, 2022
@kibanamachine @jgowdyelastic
[ML] Fixing results service space checks (#124707) (#124832)
9c413c5 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit afb458e)

Co-authored-by: James Gowdy <jgowdy@elastic.co>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 8, 2022
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

2 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

jgowdyelastic added a commit that referenced this pull request Feb 11, 2022
@kibanamachine @jgowdyelastic
[ML] Fixing results service space checks (#124707) (#124833)
b239007 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit afb458e)

Co-authored-by: James Gowdy <jgowdy@elastic.co>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 11, 2022
@lcawl lcawl added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:fix labels Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@darnautov darnautov darnautov approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Anomaly Detection ML anomaly detection :ml release_note:skip Skip the PR/issue when compiling release notes v7.17.1 v8.0.1 v8.1.0 v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jgowdyelastic @elasticmachine @kibana-ci @kibanamachine @darnautov @peteharverson @lcawl