Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Adding category definition and category examples api tests #124710

Merged
merged 12 commits into from
Feb 9, 2022
Merged

[ML] Adding category definition and category examples api tests #124710

merged 12 commits into from
Feb 9, 2022

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Feb 4, 2022 •
edited
Loading

Adds tests to check the response of the /api/ml/results/category_definition and /api/ml/results/category_examples endpoints.

Note this is broken until #124707 is merged.

Related to #117501

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

@jgowdyelastic jgowdyelastic self-assigned this Feb 7, 2022
@jgowdyelastic jgowdyelastic added :ml auto-backport Deprecated - use backport:version if exact versions are needed Feature:Anomaly Detection ML anomaly detection non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes test-api-integration v8.1.0 v8.2.0 labels Feb 7, 2022
@jgowdyelastic jgowdyelastic marked this pull request as ready for review February 7, 2022 10:28
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner February 7, 2022 10:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic jgowdyelastic changed the title [ML] Adding category definition api tests [ML] Adding category definition and category examples api tests Feb 7, 2022
@jgowdyelastic jgowdyelastic mentioned this pull request Feb 7, 2022
Closed
13 tasks
@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

pheyos
pheyos reviewed Feb 8, 2022
View reviewed changes
x-pack/test/api_integration/apis/ml/results/get_category_definition.ts Outdated Show resolved Hide resolved
x-pack/test/api_integration/apis/ml/results/get_category_definition.ts Outdated Show resolved Hide resolved
x-pack/test/api_integration/apis/ml/results/get_category_definition.ts Outdated Show resolved Hide resolved
x-pack/test/api_integration/apis/ml/results/get_category_definition.ts Show resolved Hide resolved
x-pack/test/api_integration/apis/ml/results/get_category_examples.ts Outdated Show resolved Hide resolved
x-pack/test/api_integration/apis/ml/results/get_category_examples.ts Outdated Show resolved Hide resolved
x-pack/test/api_integration/apis/ml/results/get_category_examples.ts Outdated Show resolved Hide resolved
x-pack/test/api_integration/apis/ml/results/get_category_definition.ts Outdated Show resolved Hide resolved
peteharverson
peteharverson approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pheyos
pheyos approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic merged commit 9790a7e into elastic:main Feb 9, 2022
@jgowdyelastic jgowdyelastic deleted the adding-category-definition-api-tests branch February 9, 2022 13:49
@kibanamachine kibanamachine mentioned this pull request Feb 9, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 9, 2022
@jgowdyelastic @kibanamachine
[ML] Adding category definition and category examples api tests (elas…
1dc8356 
…tic#124710)

* [ML] Adding category definition api tests

* adding test

* adding category examples tests

* updating test checks

* changes based on review

* removing test

* correcting mistake where wrong test was removed

* correctling text text

* fixing test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 9790a7e)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 9, 2022
@kibanamachine @jgowdyelastic
[ML] Adding category definition and category examples api tests (#124710
f0b8cfe 
) (#125077)

* [ML] Adding category definition api tests

* adding test

* adding category examples tests

* updating test checks

* changes based on review

* removing test

* correcting mistake where wrong test was removed

* correctling text text

* fixing test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 9790a7e)

Co-authored-by: James Gowdy <jgowdy@elastic.co>
@walterra walterra mentioned this pull request Feb 9, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@pheyos pheyos pheyos approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Anomaly Detection ML anomaly detection :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes test-api-integration v8.1.0 v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jgowdyelastic @elasticmachine @kibana-ci @kibanamachine @pheyos @peteharverson