[Gauge] Vis Type #126048

Kuznietsov · 2022-02-21T10:10:56Z

Summary

Completes part of the issue

Add vis_type for gauge/goal
Add support of percentage mode from vis_dimension
Disable form options that are not working for elastic-charts

Disabled options for elastic charts

elastic-charts.options.mov

Goal

Gauge

Split chart warnings

Kuznietsov · 2022-02-21T10:43:40Z

@elasticmachine merge upstream

…ibana into gauge-transparent-background

…tegration

Kuznietsov · 2022-02-21T16:12:09Z

@elasticmachine merge upstream

Kuznietsov · 2022-02-22T09:05:53Z

@elasticmachine merge upstream

Kuznietsov · 2022-02-22T13:39:59Z

@elasticmachine merge upstream

stratoula

Thanx Yaroslav for working on it! Some comments from my side:

In vislib the users can ovewrite the gauge colors from the legend. These colors are saved with the SO (uiState). Although we dont support the legend yet, I think that we should respect the overwritten colors. So for example this is a gauge with overwritten color (orange) but when I open it on the new implementation, the color is not respected

When I have a saved gauge with small multiples, and then render it with the new implementation, the user sees only one chart (makes sense as we dont support it). Can we add a warning in that case? We are doing the same for heatmap so it will be easy to integrate it.
The percentage mode returns different results for the new implementation.

stratoula · 2022-02-28T12:48:11Z

src/plugins/vis_types/gauge/public/editor/components/gauge/ranges_panel.tsx

+                'visTypeGauge.controls.gaugeOptions.showOutlineNotAvailable',
+                {
+                  defaultMessage:
+                    'The outile is not supported with the new charts library. Please, enable the gauge legacy charts library advanced setting.',


The outline (fix typo)

stratoula · 2022-02-28T12:51:37Z

src/plugins/vis_types/heatmap/public/sample_vis.test.mocks.ts

-    title: 'Heatmap',
-    description: 'Creates a heatmap viz',
-    icon: 'visHeatmap',
+    name: 'gauge',


This mock is for heatmap, why have we altered this?

Kuznietsov · 2022-03-02T06:08:45Z

We've discussed with @stratoula in the private chat, that I'm going to implement legacy percentage mode and uiState coloring in the follow-up PRs. And Warning about small multiples at the current.

Percentage mode is going to be ready very soon: #126318.

stratoula · 2022-03-03T08:23:52Z

@Kunzetsov the plan is to create additional PRs for the colouring and percentage mode and merge them to this PR or are we going to merge this PR in main and then the additional PRs?

Kuznietsov · 2022-03-03T08:54:46Z

@Kunzetsov the plan is to create additional PRs for the colouring and percentage mode and merge them to this PR or are we going to merge this PR in main and then the additional PRs?

@stratoula, To the main one by one.

stratoula · 2022-03-03T09:35:44Z

@Kunzetsov I see that you have hidden the Add bucket btn

This is correct of course as we don't support it but I am not very fond of the fact that we have a buckets title without any action.

I can think 3 things to improve it:

Not display the Buckets section (not so sure if it is easily done)
Do it like heatmap, (display add but split chart disabled with a tooltip

- Display add but disabled with a tooltip

It might not be so important as the new implementation won't be the default one but I would like yours and Joe's thoughts on that cc @flash1293 .

Kuznietsov · 2022-03-03T09:56:16Z

@stratoula, totally makes sense. I'll implement it right now. I didn't know, that we have heatmap when I was implementing this approach )

flash1293 · 2022-03-03T09:57:12Z

Like that approach @stratoula

Kuznietsov · 2022-03-03T14:40:01Z

@elasticmachine merge upstream

kibana-ci · 2022-03-03T16:06:08Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`visTypeGauge`	-	20	+20
`visTypeVislib`	184	176	-8
`visualizations`	214	216	+2
total			+14

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`expressionGauge`	68	69	+1
`visTypeGauge`	-	7	+7
`visualizations`	326	328	+2
total			+10

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`expressionGauge`	8.9KB	9.1KB	+117.0B
`visTypeGauge`	-	6.1KB	+6.1KB
`visTypeVislib`	356.1KB	351.8KB	-4.3KB
`visualizations`	164.1KB	165.1KB	+976.0B
total			+2.8KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`expressionGauge`	3	2	-1
`visTypeGauge`	-	2	+2
total			+1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`visTypeGauge`	-	9.7KB	+9.7KB
`visTypeVislib`	19.5KB	15.9KB	-3.6KB
`visualizations`	44.8KB	44.9KB	+122.0B
total			+6.2KB

Unknown metric groups

API count

id	before	after	diff
`expressionGauge`	68	69	+1
`visTypeGauge`	-	7	+7
`visualizations`	347	349	+2
total			+10

async chunk count

id	before	after	diff
`visTypeGauge`	-	1	+1
`visTypeVislib`	3	2	-1
total			-0

ESLint disabled line counts

id	before	after	diff
`visTypeGauge`	-	3	+3
`visTypeVislib`	3	2	-1
total			+2

Total ESLint disabled count

id	before	after	diff
`visTypeGauge`	-	3	+3
`visTypeVislib`	5	4	-1
total			+2

History

💔 Build #27330 failed 4fd9c74
💔 Build #27314 failed 9a94282
💚 Build #27042 succeeded 9eb731d
💚 Build #26462 succeeded b1f15c4
💚 Build #26119 succeeded 127b03e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kunzetsov

stratoula · 2022-03-04T07:44:30Z

This looks great Yaroslav. I only have one comment. When the user switches off the labels, I think we should also hide the Count label.

Update: The vislib also keeps it (it is less prominent than the new implementation but we should keep the vislib way so ignore it :))

stratoula

I approve it as it does what it says. The percentage mode and the uiState doesn't work but we have follow up PRs for them. With that being said, I am approving it (not a fan of merging PRs with bugs though :D )

Kuznietsov added 3 commits February 18, 2022 09:38

Added transparent background

064e917

Added gauge/goal visType.

adb0404

Merge branch 'main' into vis_editors_gauge-integration

e21f21a

Kuznietsov added the WIP Work in progress label Feb 21, 2022

Kuznietsov requested review from crob611 and alexwizp February 21, 2022 10:10

Kuznietsov self-assigned this Feb 21, 2022

Kuznietsov requested a review from VladLasitsa February 21, 2022 10:14

Fixed palette, scale and types.

6a8c677

kibanamachine and others added 12 commits February 21, 2022 05:43

Merge branch 'main' into vis_editors_gauge-integration

6f309f0

updated tests

7afcbc6

Cleaned up the code.

247689f

Updated limits.

29e9835

Set legacy chart as default.

eae8f8a

Removed deprecation message.

e0200bc

Added percent format params, comming from visdimensions.

b370834

Merge branch 'main' into gauge-transparent-background

2b8bbe8

Updated snapshot.

ff70db1

Merge branch 'gauge-transparent-background' of github.com:Kunzetsov/k…

a2f442c

…ibana into gauge-transparent-background

Merge branch 'gauge-transparent-background' into vis_editors_gauge-in…

6b07be8

…tegration

Added support of labels/sublabels.

c2e8bab

Merge branch 'main' into vis_editors_gauge-integration

48bbd6b

kibanamachine and others added 4 commits February 22, 2022 04:05

Merge branch 'main' into vis_editors_gauge-integration

10d9440

fixed vistype toast test.

573a5fe

fixed i18n.

3d96912

Updated i18n label.

d5d70b9

Kuznietsov requested a review from stratoula February 28, 2022 09:26

stratoula reviewed Feb 28, 2022

View reviewed changes

Kuznietsov added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:feature Makes this part of the condensed release notes labels Feb 28, 2022

Kuznietsov changed the title ~~[Gauge] Vis Type~~ [WIP][Gauge] Vis Type Feb 28, 2022

Kuznietsov added the WIP Work in progress label Feb 28, 2022

Merge branch 'main' into vis_editors_gauge-integration

6c48ded

Kuznietsov added 2 commits March 2, 2022 08:20

Fixed type.

c6b54e7

reverted mistaken change of sample_vis.test.mocks.

9eb731d

Warning message added to gauge split chart.

9a94282

Kuznietsov added 2 commits March 3, 2022 13:18

Added warning message to the splitChart button at goal/gauge.

4fd9c74

Fixed warning message

272427b

Kuznietsov changed the title ~~[WIP][Gauge] Vis Type~~ [Gauge] Vis Type Mar 3, 2022

Kuznietsov removed the WIP Work in progress label Mar 3, 2022

Merge branch 'main' into vis_editors_gauge-integration

55180a6

stratoula approved these changes Mar 4, 2022

View reviewed changes

Kuznietsov merged commit 2b6885a into elastic:main Mar 4, 2022

nickofthyme mentioned this pull request Mar 26, 2024

[Lens] Fix default formatter for gauge charts #179473

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Gauge] Vis Type #126048

[Gauge] Vis Type #126048

Kuznietsov commented Feb 21, 2022 •

edited

Loading

Kuznietsov commented Feb 21, 2022

Kuznietsov commented Feb 21, 2022

Kuznietsov commented Feb 22, 2022

Kuznietsov commented Feb 22, 2022

stratoula left a comment

stratoula Feb 28, 2022

stratoula Feb 28, 2022

Kuznietsov commented Mar 2, 2022 •

edited

Loading

stratoula commented Mar 3, 2022

Kuznietsov commented Mar 3, 2022 •

edited

Loading

stratoula commented Mar 3, 2022

Kuznietsov commented Mar 3, 2022

flash1293 commented Mar 3, 2022

Kuznietsov commented Mar 3, 2022

kibana-ci commented Mar 3, 2022

API count

async chunk count

ESLint disabled line counts

Total ESLint disabled count

stratoula commented Mar 4, 2022 •

edited

Loading

stratoula left a comment •

edited

Loading

[Gauge] Vis Type #126048

[Gauge] Vis Type #126048

Conversation

Kuznietsov commented Feb 21, 2022 • edited Loading

Summary

Disabled options for elastic charts

Goal

Gauge

Split chart warnings

Kuznietsov commented Feb 21, 2022

Kuznietsov commented Feb 21, 2022

Kuznietsov commented Feb 22, 2022

Kuznietsov commented Feb 22, 2022

stratoula left a comment

Choose a reason for hiding this comment

stratoula Feb 28, 2022

Choose a reason for hiding this comment

stratoula Feb 28, 2022

Choose a reason for hiding this comment

Kuznietsov commented Mar 2, 2022 • edited Loading

stratoula commented Mar 3, 2022

Kuznietsov commented Mar 3, 2022 • edited Loading

stratoula commented Mar 3, 2022

Kuznietsov commented Mar 3, 2022

flash1293 commented Mar 3, 2022

Kuznietsov commented Mar 3, 2022

kibana-ci commented Mar 3, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Public APIs missing exports

Page load bundle

API count

async chunk count

ESLint disabled line counts

Total ESLint disabled count

History

stratoula commented Mar 4, 2022 • edited Loading

stratoula left a comment • edited Loading

Choose a reason for hiding this comment

Kuznietsov commented Feb 21, 2022 •

edited

Loading

Kuznietsov commented Mar 2, 2022 •

edited

Loading

Kuznietsov commented Mar 3, 2022 •

edited

Loading

stratoula commented Mar 4, 2022 •

edited

Loading

stratoula left a comment •

edited

Loading