Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Fix default formatter for gauge charts #179473

Merged
merged 14 commits into from
Apr 9, 2024
Merged

[Lens] Fix default formatter for gauge charts #179473

merged 14 commits into from
Apr 9, 2024

Conversation

nickofthyme
Copy link
Contributor

@nickofthyme nickofthyme commented Mar 26, 2024 •
edited by kibanamachine
Loading

Summary

Fix gauge field formatter to pull default formatter defined on the dataview field.

Zight Recording 2024-03-26 at 10 27 06 AM

fixes #179439

Details

Bug originally from #126048 when Goal/Gauge was replaced in Aggs-Based with @elastic/charts.

Also removes old and now superfluous mocking of getSpecId chart export, see #179473 (comment).

Checklist

@nickofthyme nickofthyme requested a review from a team as a code owner March 26, 2024 17:29
@nickofthyme nickofthyme marked this pull request as draft March 26, 2024 17:29
@nickofthyme nickofthyme added backport:all-open Backport to all branches that could still receive a release backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:all-open Backport to all branches that could still receive a release labels Mar 26, 2024
@nickofthyme nickofthyme marked this pull request as ready for review March 28, 2024 19:00
@nickofthyme nickofthyme requested a review from a team as a code owner March 28, 2024 19:00
@nickofthyme
Copy link
Contributor Author

/ci

stephmilovic
stephmilovic approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code only review from explore, lgtm!

@nickofthyme nickofthyme requested a review from dej611 March 29, 2024 21:16
@nickofthyme
Copy link
Contributor Author

@dej611 Could you take another look at this?

dej611
dej611 approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with all gauge types and it works fine now 👍

@nickofthyme nickofthyme changed the title Fix default formatter for gauge charts [Lens] Fix default formatter for gauge charts Apr 8, 2024
@nickofthyme nickofthyme enabled auto-merge (squash) April 8, 2024 14:14
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionGauge 22.5KB 22.6KB +67.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visualizations 58.9KB 58.9KB +28.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nickofthyme
Copy link
Contributor Author

Pinging @elastic/security-threat-hunting-explore for codeowner review

@nickofthyme nickofthyme disabled auto-merge April 9, 2024 19:52
@nickofthyme nickofthyme merged commit 1d5a77a into elastic:main Apr 9, 2024
35 checks passed
@nickofthyme nickofthyme deleted the fix-gauge-default-format branch April 9, 2024 19:53
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.13 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 179473

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 179473 locally

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 10, 2024
@nickofthyme nickofthyme added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Apr 12, 2024
ElenaStoeva pushed a commit to ElenaStoeva/kibana that referenced this pull request Apr 18, 2024
@kibanamachine @simianhacker @dominiqueclarke
[8.12] [SLO] Reset UI for updating outdated SLOs (elastic#172883) (el…
5716fb9 
…astic#173200)

# Backport

This will backport the following commits from `main` to `8.12`:
- [[SLO] Reset UI for updating outdated SLOs
(elastic#172883)](elastic#172883)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Chris
Cowan","email":"chris@elastic.co"},"sourceCommit":{"committedDate":"2023-12-12T19:36:20Z","message":"[SLO]
Reset UI for updating outdated SLOs (elastic#172883)\n\n## Summary\r\n\r\nThis
PR is a follow up to elastic#172224, it adds a UI for resetting the
SLO\r\ndefinitions from the previous model. Once elastic#179473 is merged I
will\r\nrebase this against `main` and convert it from a \"draft\" PR to
\"ready
to\r\nreview\".\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/41702/daf0591c-272f-40c2-9831-658d7b9b1378)\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/41702/d385396d-d840-4574-942a-b8e51ce66066)\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/41702/729df2a0-61e6-41b3-aaa5-8501e7aa7797)\r\n\r\n\r\n###
Testing\r\n\r\n1. Start by loading `main`\r\n2. Ingest some data\r\n3.
Create some SLOs\r\n4. Change Kibana from `main` to this PR\r\n5. Visit
the SLO page, you should see a banner similar to the screen\r\nshot
above.\r\n6. Do your best to break
this\r\n\r\n---------\r\n\r\nCo-authored-by: shahzad31
<shahzad31comp@gmail.com>\r\nCo-authored-by: Dominique Clarke
<doclarke71@gmail.com>","sha":"c2003d9f83f6d437ec9ce46943a402b38c07ece5","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","backport:prev-minor","Feature:SLO","v8.12.0","Team:obs-ux-management","v8.13.0"],"number":172883,"url":"https://github.com/elastic/kibana/pull/172883","mergeCommit":{"message":"[SLO]
Reset UI for updating outdated SLOs (elastic#172883)\n\n## Summary\r\n\r\nThis
PR is a follow up to elastic#172224, it adds a UI for resetting the
SLO\r\ndefinitions from the previous model. Once elastic#179473 is merged I
will\r\nrebase this against `main` and convert it from a \"draft\" PR to
\"ready
to\r\nreview\".\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/41702/daf0591c-272f-40c2-9831-658d7b9b1378)\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/41702/d385396d-d840-4574-942a-b8e51ce66066)\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/41702/729df2a0-61e6-41b3-aaa5-8501e7aa7797)\r\n\r\n\r\n###
Testing\r\n\r\n1. Start by loading `main`\r\n2. Ingest some data\r\n3.
Create some SLOs\r\n4. Change Kibana from `main` to this PR\r\n5. Visit
the SLO page, you should see a banner similar to the screen\r\nshot
above.\r\n6. Do your best to break
this\r\n\r\n---------\r\n\r\nCo-authored-by: shahzad31
<shahzad31comp@gmail.com>\r\nCo-authored-by: Dominique Clarke
<doclarke71@gmail.com>","sha":"c2003d9f83f6d437ec9ce46943a402b38c07ece5"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172883","number":172883,"mergeCommit":{"message":"[SLO]
Reset UI for updating outdated SLOs (elastic#172883)\n\n## Summary\r\n\r\nThis
PR is a follow up to elastic#172224, it adds a UI for resetting the
SLO\r\ndefinitions from the previous model. Once elastic#179473 is merged I
will\r\nrebase this against `main` and convert it from a \"draft\" PR to
\"ready
to\r\nreview\".\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/41702/daf0591c-272f-40c2-9831-658d7b9b1378)\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/41702/d385396d-d840-4574-942a-b8e51ce66066)\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/41702/729df2a0-61e6-41b3-aaa5-8501e7aa7797)\r\n\r\n\r\n###
Testing\r\n\r\n1. Start by loading `main`\r\n2. Ingest some data\r\n3.
Create some SLOs\r\n4. Change Kibana from `main` to this PR\r\n5. Visit
the SLO page, you should see a banner similar to the screen\r\nshot
above.\r\n6. Do your best to break
this\r\n\r\n---------\r\n\r\nCo-authored-by: shahzad31
<shahzad31comp@gmail.com>\r\nCo-authored-by: Dominique Clarke
<doclarke71@gmail.com>","sha":"c2003d9f83f6d437ec9ce46943a402b38c07ece5"}}]}]
BACKPORT-->

Co-authored-by: Chris Cowan <chris@elastic.co>
Co-authored-by: Dominique Clarke <dominique.clarke@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephmilovic stephmilovic stephmilovic approved these changes

@dej611 dej611 dej611 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Gauge Vis Gauge and goal visualization Feature:Lens release_note:fix v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Gauge visualization is not respecting default field formatter
5 participants
@nickofthyme @kibana-ci @kibanamachine @dej611 @stephmilovic