Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Fix default formatter for gauge charts #179473

Merged
merged 14 commits into from
Apr 9, 2024
Merged

[Lens] Fix default formatter for gauge charts #179473

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c41a73f
fix default formatter for gauge charts
nickofthyme Mar 26, 2024
72ef15a
Merge branch 'main' into fix-gauge-default-format
nickofthyme Mar 27, 2024
aa5ad14
remove old chart mock for getSpecId
nickofthyme Mar 28, 2024
5253acf
update logic and tests for formatting cases
nickofthyme Mar 28, 2024
ef9ccf4
Merge branch 'main' into fix-gauge-default-format
nickofthyme Mar 28, 2024
f062bf8
revert changes to dimension format type
nickofthyme Mar 29, 2024
8a824d4
Merge branch 'main' into fix-gauge-default-format
nickofthyme Mar 29, 2024
a986ab0
Merge branch 'main' into fix-gauge-default-format
nickofthyme Mar 30, 2024
030fbff
fix jest tests from changes to format
nickofthyme Apr 1, 2024
410497f
Merge branch 'main' into fix-gauge-default-format
nickofthyme Apr 1, 2024
089e781
Merge branch 'main' into fix-gauge-default-format
nickofthyme Apr 2, 2024
21081b6
Merge branch 'main' into fix-gauge-default-format
nickofthyme Apr 4, 2024
da5e75d
Merge branch 'main' into fix-gauge-default-format
nickofthyme Apr 8, 2024
31bd1b7
Merge branch 'main' into fix-gauge-default-format
nickofthyme Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions src/plugins/chart_expressions/expression_gauge/public/components/gauge_component.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,6 @@ import {
Color,
} from '@elastic/charts';

jest.mock('@elastic/charts', () => {
const original = jest.requireActual('@elastic/charts');

return {
...original,
getSpecId: jest.fn(() => {}),
};
});
nickofthyme marked this conversation as resolved.
Show resolved Hide resolved

const numberColumn = (id = 'metric-accessor'): DatatableColumn => ({
id,
name: 'Count of records',
Expand All @@ -51,15 +42,6 @@ const numberColumn = (id = 'metric-accessor'): DatatableColumn => ({
},
});

jest.mock('@elastic/charts', () => {
const original = jest.requireActual('@elastic/charts');

return {
...original,
getSpecId: jest.fn(() => {}),
};
});

const chartsThemeService = chartPluginMock.createSetupContract().theme;
const paletteThemeService = chartPluginMock.createSetupContract().palettes;
const formatService = fieldFormatsServiceMock.createStartContract();
Expand Down
9 changes: 0 additions & 9 deletions ...plugins/chart_expressions/expression_heatmap/public/components/heatmap_component.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,6 @@ import HeatmapComponent from './heatmap_component';
import { LegendSize } from '@kbn/visualizations-plugin/common';
import { FieldFormat } from '@kbn/field-formats-plugin/common';

jest.mock('@elastic/charts', () => {
const original = jest.requireActual('@elastic/charts');

return {
...original,
getSpecId: jest.fn(() => {}),
};
});

const actWithTimeout = (action: Function, timer: number = 1) =>
act(
() =>
Expand Down
9 changes: 0 additions & 9 deletions ...t_expressions/expression_partition_vis/public/components/partition_vis_component.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,6 @@ import { ChartTypes } from '../../common/types';
import { LegendSize } from '@kbn/visualizations-plugin/common';
import { cloneDeep } from 'lodash';

jest.mock('@elastic/charts', () => {
const original = jest.requireActual('@elastic/charts');

return {
...original,
getSpecId: jest.fn(() => {}),
};
});

const actWithTimeout = (action: Function, timer: number = 1) =>
act(
() =>
Expand Down
9 changes: 0 additions & 9 deletions ...plugins/chart_expressions/expression_partition_vis/public/utils/get_color_picker.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,6 @@ import { createMockBucketColumns, createMockVisData } from '../mocks';
const bucketColumns = createMockBucketColumns();
const visData = createMockVisData();

jest.mock('@elastic/charts', () => {
const original = jest.requireActual('@elastic/charts');

return {
...original,
getSpecId: jest.fn(() => {}),
};
});

describe('LegendColorPickerWrapper', () => {
const mockState = new Map();
const uiState = {
Expand Down
9 changes: 0 additions & 9 deletions x-pack/plugins/security_solution/public/common/components/charts/common.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,6 @@ import { LEGACY_LIGHT_THEME, LEGACY_DARK_THEME } from '@elastic/charts';

jest.mock('../../lib/kibana');

jest.mock('@elastic/charts', () => {
const original = jest.requireActual('@elastic/charts');

return {
...original,
getSpecId: jest.fn(() => {}),
};
});
nickofthyme marked this conversation as resolved.
Show resolved Hide resolved

describe('WrappedByAutoSizer', () => {
it('should render correct default height', () => {
const wrapper = shallow(<WrappedByAutoSizer />);
Expand Down