[SLO] Reset UI for updating outdated SLOs #172883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
simianhacker
added
Feature:SLO
v8.12.0
v8.13.0
backport:prev-minor
simianhacker
force-pushed
the
slo-reset-ui
branch
from
6f958de to
acac81d
Compare
kdelemme
reviewed
Dec 8, 2023
...bservability/public/components/slo/reset_confirmation_modal/slo_reset_confirmation_modal.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability/public/pages/slo_outdated_definitions/outdated_slo_search_bar.tsx
Outdated
Show resolved
Hide resolved
kdelemme
reviewed
Dec 8, 2023
x-pack/plugins/observability/public/pages/slo_outdated_definitions/outdated_slo_search_bar.tsx
Outdated
Show resolved
Hide resolved
simianhacker
force-pushed
the
slo-reset-ui
branch
from
acac81d to
a34f6aa
Compare
simianhacker
force-pushed
the
slo-reset-ui
branch
from
8c9a1f0 to
792e3b5
Compare
botelastic
bot
added
the
Team:obs-ux-management
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
x-pack/plugins/observability/public/pages/slo_outdated_definitions/index.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Dominique Clarke <doclarke71@gmail.com>
Co-authored-by: Dominique Clarke <doclarke71@gmail.com>
Co-authored-by: Dominique Clarke <doclarke71@gmail.com>
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 12, 2023
## Summary This PR is a follow up to elastic#172224, it adds a UI for resetting the SLO definitions from the previous model. Once elastic#179473 is merged I will rebase this against `main` and convert it from a "draft" PR to "ready to review".    ### Testing 1. Start by loading `main` 2. Ingest some data 3. Create some SLOs 4. Change Kibana from `main` to this PR 5. Visit the SLO page, you should see a banner similar to the screen shot above. 6. Do your best to break this --------- Co-authored-by: shahzad31 <shahzad31comp@gmail.com> Co-authored-by: Dominique Clarke <doclarke71@gmail.com> (cherry picked from commit c2003d9)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 13, 2023
# Backport This will backport the following commits from `main` to `8.12`: - [[SLO] Reset UI for updating outdated SLOs (#172883)](#172883) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Chris Cowan","email":"chris@elastic.co"},"sourceCommit":{"committedDate":"2023-12-12T19:36:20Z","message":"[SLO] Reset UI for updating outdated SLOs (#172883)\n\n## Summary\r\n\r\nThis PR is a follow up to #172224, it adds a UI for resetting the SLO\r\ndefinitions from the previous model. Once #179473 is merged I will\r\nrebase this against `main` and convert it from a \"draft\" PR to \"ready to\r\nreview\".\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Testing\r\n\r\n1. Start by loading `main`\r\n2. Ingest some data\r\n3. Create some SLOs\r\n4. Change Kibana from `main` to this PR\r\n5. Visit the SLO page, you should see a banner similar to the screen\r\nshot above.\r\n6. Do your best to break this\r\n\r\n---------\r\n\r\nCo-authored-by: shahzad31 <shahzad31comp@gmail.com>\r\nCo-authored-by: Dominique Clarke <doclarke71@gmail.com>","sha":"c2003d9f83f6d437ec9ce46943a402b38c07ece5","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","backport:prev-minor","Feature:SLO","v8.12.0","Team:obs-ux-management","v8.13.0"],"number":172883,"url":"https://github.com/elastic/kibana/pull/172883","mergeCommit":{"message":"[SLO] Reset UI for updating outdated SLOs (#172883)\n\n## Summary\r\n\r\nThis PR is a follow up to #172224, it adds a UI for resetting the SLO\r\ndefinitions from the previous model. Once #179473 is merged I will\r\nrebase this against `main` and convert it from a \"draft\" PR to \"ready to\r\nreview\".\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Testing\r\n\r\n1. Start by loading `main`\r\n2. Ingest some data\r\n3. Create some SLOs\r\n4. Change Kibana from `main` to this PR\r\n5. Visit the SLO page, you should see a banner similar to the screen\r\nshot above.\r\n6. Do your best to break this\r\n\r\n---------\r\n\r\nCo-authored-by: shahzad31 <shahzad31comp@gmail.com>\r\nCo-authored-by: Dominique Clarke <doclarke71@gmail.com>","sha":"c2003d9f83f6d437ec9ce46943a402b38c07ece5"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172883","number":172883,"mergeCommit":{"message":"[SLO] Reset UI for updating outdated SLOs (#172883)\n\n## Summary\r\n\r\nThis PR is a follow up to #172224, it adds a UI for resetting the SLO\r\ndefinitions from the previous model. Once #179473 is merged I will\r\nrebase this against `main` and convert it from a \"draft\" PR to \"ready to\r\nreview\".\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Testing\r\n\r\n1. Start by loading `main`\r\n2. Ingest some data\r\n3. Create some SLOs\r\n4. Change Kibana from `main` to this PR\r\n5. Visit the SLO page, you should see a banner similar to the screen\r\nshot above.\r\n6. Do your best to break this\r\n\r\n---------\r\n\r\nCo-authored-by: shahzad31 <shahzad31comp@gmail.com>\r\nCo-authored-by: Dominique Clarke <doclarke71@gmail.com>","sha":"c2003d9f83f6d437ec9ce46943a402b38c07ece5"}}]}] BACKPORT--> Co-authored-by: Chris Cowan <chris@elastic.co> Co-authored-by: Dominique Clarke <dominique.clarke@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a follow up to #172224, it adds a UI for resetting the SLO definitions from the previous model. Once #179473 is merged I will rebase this against
mainand convert it from a "draft" PR to "ready to review".Testing
mainmainto this PR