Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.1] chore(NA): upgrade typescript-eslint packages to v5.14.0 (#127275) #127532

Merged
merged 3 commits into from
Mar 14, 2022

Conversation

mistic
Copy link
Member

@mistic mistic commented Mar 11, 2022

Backport

This will backport the following commits from main to 8.1:

Questions ?

Please refer to the Backport tool documentation

)

* chore(NA): upgrade typescript-eslint packages to v5.14.0

* chore(NA): ignore required quotes

* Update packages/elastic-eslint-config-kibana/typescript.js

Co-authored-by: Spencer <email@spalger.com>

* chore(NA): remove old lint disable comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Spencer <spencer@elastic.co>
Co-authored-by: Spencer <email@spalger.com>
(cherry picked from commit 8cd75df)

# Conflicts:
#	src/plugins/chart_expressions/expression_metric/public/components/metric_value.tsx
#	src/plugins/kibana_react/public/page_template/with_solution_nav.tsx
#	x-pack/plugins/lens/public/editor_frame_service/editor_frame/workspace_panel/workspace_panel_wrapper.tsx
@mistic mistic enabled auto-merge (squash) March 11, 2022 02:39
@mistic
Copy link
Member Author

mistic commented Mar 14, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #15 / machine learning data visualizer index based with farequote farequote index pattern displays index details

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
dataViewEditor 3 2 -1
dataViewFieldEditor 2 0 -2
kibanaReact 6 4 -2
timelines 3 2 -1
uiActionsEnhanced 6 5 -1
total -7

ESLint disabled line counts

id before after diff
@kbn/telemetry-tools 1 0 -1
advancedSettings 4 2 -2
charts 2 0 -2
dashboard 12 10 -2
data 44 42 -2
dataVisualizer 36 35 -1
discover 36 34 -2
embeddable 4 3 -1
expressionMetricVis 6 4 -2
graph 11 4 -7
indexManagement 35 15 -20
ingestPipelines 27 17 -10
kibanaUsageCollection 7 5 -2
lens 37 28 -9
maps 45 38 -7
ml 97 96 -1
searchprofiler 2 0 -2
securitySolution 447 445 -2
triggersActionsUi 154 150 -4
upgradeAssistant 11 10 -1
visTypeVislib 3 2 -1
total -81

Total ESLint disabled count

id before after diff
@kbn/telemetry-tools 1 0 -1
advancedSettings 4 2 -2
charts 3 1 -2
dashboard 12 10 -2
data 48 46 -2
dataViewEditor 5 4 -1
dataViewFieldEditor 10 8 -2
dataVisualizer 36 35 -1
discover 38 36 -2
embeddable 6 5 -1
expressionMetricVis 6 4 -2
graph 11 4 -7
indexManagement 40 20 -20
ingestPipelines 28 18 -10
kibanaReact 21 19 -2
kibanaUsageCollection 10 8 -2
lens 39 30 -9
maps 73 66 -7
ml 99 98 -1
searchprofiler 3 1 -2
securitySolution 515 513 -2
timelines 55 54 -1
triggersActionsUi 159 155 -4
uiActionsEnhanced 15 14 -1
upgradeAssistant 11 10 -1
visTypeVislib 5 4 -1
total -88

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit 61d1fc1 into elastic:8.1 Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants