Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for expression based scripted fields #14310

Merged
merged 5 commits into from
Nov 13, 2017

Conversation

Bargs
Copy link
Contributor

@Bargs Bargs commented Oct 4, 2017

Fixes #14216
Related #14214 (it's probably easier to review #14214 first)

This PR removes the ability to create scripted fields with the expression language. It also adds an error message to the scripted field list page if any expression scripts already exist which instructs the user to convert all their scripts to painless.

screen shot 2017-10-04 at 3 30 27 pm

Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Bargs
Copy link
Contributor Author

Bargs commented Oct 12, 2017

jenkins, test this

@Bargs Bargs force-pushed the removeExpressions branch from ff27812 to ac7b39c Compare November 3, 2017 19:20
@Bargs
Copy link
Contributor Author

Bargs commented Nov 7, 2017

jenkins test this

@Bargs Bargs force-pushed the removeExpressions branch from d45d2ba to 6be4439 Compare November 7, 2017 18:41
@Bargs Bargs force-pushed the removeExpressions branch from 6be4439 to 71212d5 Compare November 9, 2017 22:40
@Bargs Bargs requested review from bmcconaghy and removed request for BigFunger November 9, 2017 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants