-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tab counters on filter change #34246
Update tab counters on filter change #34246
Conversation
💚 Build Succeeded |
@flash1293 I was wondering (maybe you know the code now to estimate this), if it's worth when filtering down, actually not showing the plain number of now found fields, but instead something like |
@timroes This is easy to add to the current state. I also forgot to filter the counts for the source filters, I will add this to the PR. |
This doesn't respect the language filter in the "Scripted fields" tab - does this even work in the newer versions? Can this dropdown be removed completely? The control flow is a little awkward, because the individual tables do their own filtering (we basically filter twice, once in angular for the tabs, once in react for the actual table). But if we fix this now we might as well EUI-ify the whole thing which is a little more effort. |
I looked into the code and in |
💚 Build Succeeded |
You can still create a scripted field with the language |
Pinging @elastic/kibana-app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Chrome Linux. Seems to work fine. Code LGTM.
I would leave the code for multiple languages for now in there. Maybe if we refactor that part we can discuss throwing it out, but I see not current need for that (and I anyway wouldn't do it in this PR :D)
Summary
Fixes #19524 by updating the tab counters if the filter is changed.
@timroes The fix is in the angular code, so a complete EUI-ification of the edit index pattern section would fix this problem. If we get this in before 7.1 feature freeze, we don't need this PR.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers