-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Fixes bug with removing layer with trendline #143723
[Lens] Fixes bug with removing layer with trendline #143723
Conversation
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
x-pack/plugins/lens/public/datasources/form_based/form_based.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally with Safari 👍
Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
This fix makes sense to me! I think @MichaelMarcialis also wanted the "clear layer" icon not to change to the "delete layer" trash can. We could do this by excluding hidden layers when we calculate |
Yes, exactly. Since the metric type visualizations only support a single layer, the button should retain its "Clear layer" action (with accompanying |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
I spoke with @stratoula and we'll get that icon change ironed out in another PR @MichaelMarcialis . Thank you for taking on this fix @stratoula ! |
Summary
Part of #143687
If you create a layer with trendline and try to clear the layer, there was an error. This PR fixes it.