Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the clear layer icon on metric viz #143816

Closed
wants to merge 2 commits into from

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Oct 21, 2022

Summary

Closes #143687

It correct the clear layer icon that appears on a metric with trendline.

image

Checklist

@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes Feature:Lens backport:skip This commit does not require backporting v8.6.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 21, 2022
@stratoula stratoula marked this pull request as ready for review October 21, 2022 13:07
@stratoula stratoula requested a review from a team as a code owner October 21, 2022 13:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@drewdaemon
Copy link
Contributor

After #143723 I realized that we needed to call removeLayer on the visualization class whenever the datasource removes an extra (linked) layer.

I started working on that change and this icon correction together in #143781 and did not tell you since I didn't know you were working on this. I'm sorry that it led to duplicated work! I should have made sure I was coordinating with you!

@stratoula
Copy link
Contributor Author

Np Andrew at all. Thank you a lot for looking into it. I will close it

@mbondyra
Copy link
Contributor

@elasticmachine merge upstream

Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw it's to be closed. Nvm :)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
lens 576 577 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.3MB 1.3MB +188.0B
Unknown metric groups

API count

id before after diff
lens 669 671 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula closed this Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] Enabling metric trend line should not enable layer deletion
6 participants