allow cross cluster index pattern negation - remove index pattern validation code #147970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattkime
changed the title
This was referenced Dec 28, 2022
kertal
reviewed
Dec 29, 2022
Comment on lines
-71
to
-75
| let patternListActive: string[] = patternList; | ||
| // if only one pattern, don't bother with validation. We let getFieldCapabilities fail if the single pattern is bad regardless | ||
| if (patternList.length > 1 && !allowNoIndices) { | ||
| patternListActive = await this.validatePatternListActive(patternList); | ||
| } |
There was a problem hiding this comment.
For me this looks redundant if we decide no longer to show the message for existing data views without matching indices. Seems it was introduced in #90170?
mattkime
added a commit
that referenced
this pull request
Dec 29, 2022
## Summary The data views api examines comma delimited sections to see if there are matching indices before fetching the field list. The existing code checked for index pattern negation - patterns that started with a `-`. However, it didn't check for this in cross cluster case - `this_cluster:-kibana*`. The code now handles the cross cluster case appropriately. Still, its unclear to me whether this logic is necessary, hence why I opened #147970 - I was able to resolve the failed tests most familiar to me but I will need to work with engineers from other teams to investigate other failures. Closes #147926
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 29, 2022
## Summary The data views api examines comma delimited sections to see if there are matching indices before fetching the field list. The existing code checked for index pattern negation - patterns that started with a `-`. However, it didn't check for this in cross cluster case - `this_cluster:-kibana*`. The code now handles the cross cluster case appropriately. Still, its unclear to me whether this logic is necessary, hence why I opened elastic#147970 - I was able to resolve the failed tests most familiar to me but I will need to work with engineers from other teams to investigate other failures. Closes elastic#147926 (cherry picked from commit e3cac21)
kibanamachine
added a commit
that referenced
this pull request
Dec 29, 2022
… (#148206) # Backport This will backport the following commits from `main` to `8.6`: - [[data views] allow cross cluster index pattern negation (#147968)](#147968) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Matthew Kime","email":"matt@mattki.me"},"sourceCommit":{"committedDate":"2022-12-29T15:51:20Z","message":"[data views] allow cross cluster index pattern negation (#147968)\n\n## Summary\r\n\r\nThe data views api examines comma delimited sections to see if there are\r\nmatching indices before fetching the field list. The existing code\r\nchecked for index pattern negation - patterns that started with a `-`.\r\nHowever, it didn't check for this in cross cluster case -\r\n`this_cluster:-kibana*`. The code now handles the cross cluster case\r\nappropriately.\r\n\r\nStill, its unclear to me whether this logic is necessary, hence why I\r\nopened #147970 - I was able to\r\nresolve the failed tests most familiar to me but I will need to work\r\nwith engineers from other teams to investigate other failures.\r\n\r\nCloses https://github.com/elastic/kibana/issues/147926","sha":"e3cac218f011b3de0b39700feed1500f6129fd99","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Feature:Data Views","Team:DataDiscovery","backport:prev-minor","v8.7.0"],"number":147968,"url":"https://github.com/elastic/kibana/pull/147968","mergeCommit":{"message":"[data views] allow cross cluster index pattern negation (#147968)\n\n## Summary\r\n\r\nThe data views api examines comma delimited sections to see if there are\r\nmatching indices before fetching the field list. The existing code\r\nchecked for index pattern negation - patterns that started with a `-`.\r\nHowever, it didn't check for this in cross cluster case -\r\n`this_cluster:-kibana*`. The code now handles the cross cluster case\r\nappropriately.\r\n\r\nStill, its unclear to me whether this logic is necessary, hence why I\r\nopened #147970 - I was able to\r\nresolve the failed tests most familiar to me but I will need to work\r\nwith engineers from other teams to investigate other failures.\r\n\r\nCloses https://github.com/elastic/kibana/issues/147926","sha":"e3cac218f011b3de0b39700feed1500f6129fd99"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/147968","number":147968,"mergeCommit":{"message":"[data views] allow cross cluster index pattern negation (#147968)\n\n## Summary\r\n\r\nThe data views api examines comma delimited sections to see if there are\r\nmatching indices before fetching the field list. The existing code\r\nchecked for index pattern negation - patterns that started with a `-`.\r\nHowever, it didn't check for this in cross cluster case -\r\n`this_cluster:-kibana*`. The code now handles the cross cluster case\r\nappropriately.\r\n\r\nStill, its unclear to me whether this logic is necessary, hence why I\r\nopened #147970 - I was able to\r\nresolve the failed tests most familiar to me but I will need to work\r\nwith engineers from other teams to investigate other failures.\r\n\r\nCloses https://github.com/elastic/kibana/issues/147926","sha":"e3cac218f011b3de0b39700feed1500f6129fd99"}}]}] BACKPORT--> Co-authored-by: Matthew Kime <matt@mattki.me>
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]Page load bundle
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Closes #147926
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers