[Synthetics] Adds additional heartbeat configuration options to the Synthetics app #154390

dominiqueclarke · 2023-04-04T19:57:07Z

Summary

Closes #140864
Relates to https://github.com/elastic/synthetics-dev/issues/159
Relates to elastic/synthetics#655

Adds missing heartbeat configs to the Synthetics app. The additional configs are specified below:

HTTP (proxy_headers, mode, ipv4, ipv6, response.include_body_max_bytes, check.response.json)

TCP (mode, ipv4, ivp6)

ICMP (mode, ipv4, ipv6)

Testing

Create a private location
Create an http monitor selecting both a public and private location, adjusting the settings for mode, ipv4, ipv6, response.include_body_max_bytes, check.response.json and proxy headers.
Navigate to the edit page for that monitor, ensure the configuration above was saved to the monitor settings
Create an icmp monitor selecting both a public and private location, adjusting the settings for mode, ipv6, and ipv4.
Navigate to the dit page for that monitor, ensure the configuration above was saved to the monitor settings
Create an tcp monitor selecting both a public and private location, adjusting the settings for mode, ipv6, and ipv4.
Navigate to the dit page for that monitor, ensure the configuration above was saved to the monitor settings
Navigate to the agent policy for the private location selected. Ensure that the configuration options are represented on the the individual integration policies

apmmachine · 2023-04-04T19:57:23Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

…-add-extra-heartbeat-configs

…/github.com/dominiqueclarke/kibana into feat/synthetics-add-extra-heartbeat-configs

elasticmachine · 2023-04-11T02:36:50Z

Pinging @elastic/uptime (Team:uptime)

dominiqueclarke · 2023-04-11T13:32:16Z

@elasticmachine merge upstream

…/github.com/dominiqueclarke/kibana into feat/synthetics-add-extra-heartbeat-configs

florent-leborgne

Nice content! I have mostly minor wording style suggestions. I hope I haven't missed anything :)

.../plugins/synthetics/public/apps/synthetics/components/monitor_add_edit/form/field_config.tsx

florent-leborgne · 2023-04-12T08:36:04Z

.../plugins/synthetics/public/apps/synthetics/components/monitor_add_edit/form/field_config.tsx

+    fieldKey: ConfigKey.RESPONSE_JSON_CHECK,
+    component: KeyValuePairsField,
+    label: i18n.translate('xpack.synthetics.monitorConfig.responseJSON.label', {
+      defaultMessage: 'Check response body contains JSON',


I noticed that all labels for similar settings are like this. I'd suggest 2 improvements depending on what is possible, timely and realistic to do:

Have simple labels and use the operators as preset fields (a bit like what the JSON setting looks like), for example:
Response status
Equals to input field...
Response body
Contains input field...
some help text
Does not contain input field...
some help text

Quick label structure improvement: remove "Check". It's already explained in the section description and name "Response checks"

Response body contains JSON

Response status equals to

Response headers contain

etc.

florent-leborgne · 2023-04-12T08:39:21Z

.../plugins/synthetics/public/apps/synthetics/components/monitor_add_edit/form/field_config.tsx

+    fieldKey: ConfigKey.PROXY_HEADERS,
+    component: HeaderField,
+    label: i18n.translate('xpack.synthetics.monitorConfig.proxyHeaders.label', {
+      defaultMessage: 'Proxy headers',


Not very content related, but I'm wondering from the screenshots if it wouldn't be clearer to have the "+ Add expression", "+ Add header" and similar types of button below the setting descriptions and values already added. Just thinking in terms of layout. Maybe it'd look odd as well, not sure.

.../plugins/synthetics/public/apps/synthetics/components/monitor_add_edit/form/field_config.tsx

…nitor_add_edit/form/field_config.tsx Co-authored-by: florent-leborgne <florent.leborgne@elastic.co>

shahzad31 · 2023-04-17T14:37:29Z

x-pack/plugins/synthetics/server/legacy_uptime/lib/saved_objects/migrations/monitors/8.8.0.ts

@@ -90,7 +90,7 @@ const getNearestSupportedSchedule = (currentSchedule: string): string => {

    return closest;
  } catch {
-    return ALLOWED_SCHEDULES_IN_MINUTES[0];
+    return '10';


is this intended?

It is. Paul and I had a conversation about this, and I decided to just make this quick change in this PR.

shahzad31

Tested newly added configs !!

Works as expected !!

…/github.com/dominiqueclarke/kibana into feat/synthetics-add-extra-heartbeat-configs

…nitor_add_edit/form/field_config.tsx Co-authored-by: florent-leborgne <florent.leborgne@elastic.co>

kibana-ci · 2023-04-25T03:01:59Z

💚 Build Succeeded

Buildkite Build
Commit: a793568

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`synthetics`	1.2MB	1.2MB	+5.8KB

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	17	19	+2
`securitySolution`	397	400	+3
total			+5

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	18	20	+2
`securitySolution`	477	480	+3
total			+5

History

💔 Build #120573 failed 85496a9
💔 Build #120329 failed cb3fd7d
💛 Build #119394 was flaky 00681b8
💔 Build #119379 failed d47a045
💔 Build #119364 failed 8f9b1c9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

add mode to http monitors

98e7748

dominiqueclarke added 20 commits April 4, 2023 16:50

adjust tests

58b4817

add mode to icmp and tcp monitors

229076e

add response.include_body_max_bytes to http monitors

cb41e21

adjust types

54789cc

adjust tests

871995f

add ipv4 and ipv6 configs

44dd5e2

adjust tests

9144a91

Merge branch 'main' of github.com:elastic/kibana into feat/synthetics…

6e72e22

…-add-extra-heartbeat-configs

add monitor proxy headers

431a4c2

handle converting response_body_max_bytes to a string

4f41b0c

Merge branch 'main' into feat/synthetics-add-extra-heartbeat-configs

cecf870

Merge branch 'main' of github.com:elastic/kibana into feat/synthetics…

57aac3c

…-add-extra-heartbeat-configs

Merge branch 'main' of github.com:elastic/kibana into feat/synthetics…

0f77230

…-add-extra-heartbeat-configs

add response check json to http monitor

6d2c734

Merge branch 'feat/synthetics-add-extra-heartbeat-configs' of https:/…

4ce77ce

…/github.com/dominiqueclarke/kibana into feat/synthetics-add-extra-heartbeat-configs

adjust tests

3e165ad

add test

26a53ed

adjust test for private locations

39cce02

adjust tests to account for private locations

99c5d45

adjust field config

c049e1d

dominiqueclarke added enhancement New value added to drive a business result Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.8.0 labels Apr 11, 2023

dominiqueclarke changed the title ~~add mode to http monitors~~ [Synthetics] Adds additional heartbeat configuration options to the Synthetics app Apr 11, 2023

dominiqueclarke marked this pull request as ready for review April 11, 2023 02:36

dominiqueclarke requested a review from a team as a code owner April 11, 2023 02:36

dominiqueclarke added the release_note:skip Skip the PR/issue when compiling release notes label Apr 11, 2023

Merge branch 'main' into feat/synthetics-add-extra-heartbeat-configs

e9b11fc

dominiqueclarke requested a review from florent-leborgne April 11, 2023 02:45

kibanamachine and others added 4 commits April 11, 2023 09:32

Merge branch 'main' into feat/synthetics-add-extra-heartbeat-configs

c3a9cf1

merge upstream

510dbf0

Merge branch 'feat/synthetics-add-extra-heartbeat-configs' of https:/…

74d9c66

…/github.com/dominiqueclarke/kibana into feat/synthetics-add-extra-heartbeat-configs

Merge branch 'main' into feat/synthetics-add-extra-heartbeat-configs

26e38d4

florent-leborgne reviewed Apr 12, 2023

View reviewed changes

dominiqueclarke and others added 7 commits April 12, 2023 08:02

Update x-pack/plugins/synthetics/public/apps/synthetics/components/mo…

b185cb7

…nitor_add_edit/form/field_config.tsx Co-authored-by: florent-leborgne <florent.leborgne@elastic.co>

Update x-pack/plugins/synthetics/public/apps/synthetics/components/mo…

60a8544

…nitor_add_edit/form/field_config.tsx Co-authored-by: florent-leborgne <florent.leborgne@elastic.co>

Update x-pack/plugins/synthetics/public/apps/synthetics/components/mo…

4d68099

…nitor_add_edit/form/field_config.tsx Co-authored-by: florent-leborgne <florent.leborgne@elastic.co>

Update x-pack/plugins/synthetics/public/apps/synthetics/components/mo…

8f9b1c9

…nitor_add_edit/form/field_config.tsx Co-authored-by: florent-leborgne <florent.leborgne@elastic.co>

linting

d47a045

adjust content

00681b8

Update x-pack/plugins/synthetics/public/apps/synthetics/components/mo…

0abea88

…nitor_add_edit/form/field_config.tsx Co-authored-by: florent-leborgne <florent.leborgne@elastic.co>

shahzad31 reviewed Apr 17, 2023

View reviewed changes

shahzad31 added 2 commits April 17, 2023 16:40

Merge branch 'main' into feat/synthetics-add-extra-heartbeat-configs

cb3fd7d

Merge branch 'main' into feat/synthetics-add-extra-heartbeat-configs

85496a9

shahzad31 approved these changes Apr 18, 2023

View reviewed changes

dominiqueclarke and others added 6 commits April 24, 2023 21:11

merge upstream

1d3b7f7

adjust content

41fb842

Merge branch 'feat/synthetics-add-extra-heartbeat-configs' of https:/…

5407fcf

…/github.com/dominiqueclarke/kibana into feat/synthetics-add-extra-heartbeat-configs

Update x-pack/plugins/synthetics/public/apps/synthetics/components/mo…

2846868

…nitor_add_edit/form/field_config.tsx Co-authored-by: florent-leborgne <florent.leborgne@elastic.co>

Update x-pack/plugins/synthetics/public/apps/synthetics/components/mo…

23fb494

…nitor_add_edit/form/field_config.tsx Co-authored-by: florent-leborgne <florent.leborgne@elastic.co>

adjust tests

a793568

dominiqueclarke merged commit c3ccede into elastic:main Apr 25, 2023

kibanamachine added the backport:skip This commit does not require backporting label Apr 25, 2023

dominiqueclarke deleted the feat/synthetics-add-extra-heartbeat-configs branch April 25, 2023 12:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Synthetics] Adds additional heartbeat configuration options to the Synthetics app #154390

[Synthetics] Adds additional heartbeat configuration options to the Synthetics app #154390

dominiqueclarke commented Apr 4, 2023 •

edited

Loading

apmmachine commented Apr 4, 2023

elasticmachine commented Apr 11, 2023

dominiqueclarke commented Apr 11, 2023

florent-leborgne left a comment

florent-leborgne Apr 12, 2023

florent-leborgne Apr 12, 2023

shahzad31 Apr 17, 2023

dominiqueclarke Apr 17, 2023

shahzad31 left a comment

kibana-ci commented Apr 25, 2023

ESLint disabled line counts

Total ESLint disabled count

[Synthetics] Adds additional heartbeat configuration options to the Synthetics app #154390

[Synthetics] Adds additional heartbeat configuration options to the Synthetics app #154390

Conversation

dominiqueclarke commented Apr 4, 2023 • edited Loading

Summary

Testing

apmmachine commented Apr 4, 2023

🤖 GitHub comments

elasticmachine commented Apr 11, 2023

dominiqueclarke commented Apr 11, 2023

florent-leborgne left a comment

Choose a reason for hiding this comment

florent-leborgne Apr 12, 2023

Choose a reason for hiding this comment

florent-leborgne Apr 12, 2023

Choose a reason for hiding this comment

shahzad31 Apr 17, 2023

Choose a reason for hiding this comment

dominiqueclarke Apr 17, 2023

Choose a reason for hiding this comment

shahzad31 left a comment

Choose a reason for hiding this comment

kibana-ci commented Apr 25, 2023

💚 Build Succeeded

Metrics [docs]

Async chunks

ESLint disabled line counts

Total ESLint disabled count

History

dominiqueclarke commented Apr 4, 2023 •

edited

Loading