Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synthetics to push all Heartbeat config options #655

Open
paulb-elastic opened this issue Nov 21, 2022 · 4 comments
Open

Synthetics to push all Heartbeat config options #655

paulb-elastic opened this issue Nov 21, 2022 · 4 comments

Comments

@paulb-elastic
Copy link
Contributor

paulb-elastic commented Nov 21, 2022

This is the Synthetics version of the Kibana UI elastic/kibana#140864 issue, which is about config options that can be done in traditional heartbeat.yml today, that are not supported in the Synthetics UI, or via push.

This issue covers the requirement to add additional config options via push (further to what was initially implemented in #593).

Note that there are other specific issues covering:

This issue should focus on the other configuration options in Heartbeat

NOTE that the documentation states that ...not all Heartbeat configuration options are supported... which we should update accordingly

@shahzad31
Copy link
Contributor

Also needs to support ssl.renegotiation and

@dominiqueclarke
Copy link
Contributor

response.include_body_max_bytes was also requested by a customer.

@dominiqueclarke
Copy link
Contributor

I don't think this is needed, as synthetics currently already pushes all the configuration it's provided, and Kibana is what tells it if it's supported or not. @paulb-elastic keeping this open for now but can probably close.

@paulb-elastic
Copy link
Contributor Author

Pushing to post 1.0

dominiqueclarke added a commit to elastic/kibana that referenced this issue Apr 25, 2023
…ynthetics app (#154390)

## Summary

Closes #140864
Relates to elastic/synthetics-dev#159
Relates to elastic/synthetics#655

Adds missing heartbeat configs to the Synthetics app. The additional
configs are specified below:

HTTP (proxy_headers, mode, ipv4, ipv6, response.include_body_max_bytes,
check.response.json)

![image](https://user-images.githubusercontent.com/11356435/231040397-4f80d3af-ff08-4ef1-bbd9-c49f63d29bd0.png)

![image](https://user-images.githubusercontent.com/11356435/231040371-b7baa693-d573-46e1-b0f1-6d21c32522b8.png)


TCP (mode, ipv4, ivp6)

![image](https://user-images.githubusercontent.com/11356435/231040065-ad865160-7f6c-4450-ab1c-98c17aedd3f0.png)

ICMP (mode, ipv4, ipv6)

![image](https://user-images.githubusercontent.com/11356435/231039925-d2a2e9ab-69aa-4d74-8c3e-91223dd963d1.png)


### Testing

1. Create a private location
2. Create an http monitor selecting both a public and private location,
adjusting the settings for mode, ipv4, ipv6,
response.include_body_max_bytes, check.response.json and proxy headers.
3. Navigate to the edit page for that monitor, ensure the configuration
above was saved to the monitor settings
4. Create an icmp monitor selecting both a public and private location,
adjusting the settings for mode, ipv6, and ipv4.
5. Navigate to the dit page for that monitor, ensure the configuration
above was saved to the monitor settings
6. Create an tcp monitor selecting both a public and private location,
adjusting the settings for mode, ipv6, and ipv4.
7. Navigate to the dit page for that monitor, ensure the configuration
above was saved to the monitor settings
8. Navigate to the agent policy for the private location selected.
Ensure that the configuration options are represented on the the
individual integration policies

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: florent-leborgne <florent.leborgne@elastic.co>
Co-authored-by: Shahzad <shahzad31comp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants