[AO] Update default action and recovery messages for observability rule types #159571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
maryam-saeidi
changed the title
…-ref HEAD~1..HEAD --fix'
maryam-saeidi
commented
Jun 13, 2023
| @@ -95,7 +95,7 @@ pageLoadAssetSize: | |||
| monitoring: 80000 | |||
| navigation: 37269 | |||
| newsfeed: 42228 | |||
| observability: 100000 | |||
| observability: 115443 | |||
There was a problem hiding this comment.
I've just added some default messages for alerting. Not sure how to improve this; any suggestions?
|
/oblt-deploy |
maryam-saeidi
added
release_note:skip
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
|
Sorry for the wrong ping! 🙈 |
💚 Build Succeeded
Metrics [docs]Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.9.0
backport:skip
maryam-saeidi
added a commit
that referenced
this pull request
Jun 30, 2023
Fixes #160926 Partially reverts #159571 ## Summary At the moment, we don't have any context for recovered alerts for APM rule types, and the default messages will be empty. We will bring these messages back after #158183 is done. ## 🧪 How to test - When creating an APM rule, add an action for the recovered state. You should see the default recovery message as Recovered <img src="https://github.com/elastic/kibana/assets/12370520/eb6ef0cc-0dbc-4758-a73e-4647b068f9a1" width="500"/>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 30, 2023
) Fixes elastic#160926 Partially reverts elastic#159571 ## Summary At the moment, we don't have any context for recovered alerts for APM rule types, and the default messages will be empty. We will bring these messages back after elastic#158183 is done. ## 🧪 How to test - When creating an APM rule, add an action for the recovered state. You should see the default recovery message as Recovered <img src="https://github.com/elastic/kibana/assets/12370520/eb6ef0cc-0dbc-4758-a73e-4647b068f9a1" width="500"/> (cherry picked from commit 3382061)
kibanamachine
referenced
this pull request
Jun 30, 2023
…) (#160967) # Backport This will backport the following commits from `main` to `8.9`: - [[AO] Remove default recovery messages for APM rule types (#160928)](#160928) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maryam Saeidi","email":"maryam.saeidi@elastic.co"},"sourceCommit":{"committedDate":"2023-06-30T09:14:11Z","message":"[AO] Remove default recovery messages for APM rule types (#160928)\n\nFixes #160926\r\nPartially reverts https://github.com/elastic/kibana/pull/159571\r\n\r\n## Summary\r\n\r\nAt the moment, we don't have any context for recovered alerts for APM\r\nrule types, and the default messages will be empty. We will bring these\r\nmessages back after #158183 is\r\ndone.\r\n\r\n## 🧪 How to test\r\n- When creating an APM rule, add an action for the recovered state. You\r\nshould see the default recovery message as Recovered\r\n\r\n<img\r\nsrc=\"https://github.com/elastic/kibana/assets/12370520/eb6ef0cc-0dbc-4758-a73e-4647b068f9a1\"\r\nwidth=\"500\"/>","sha":"3382061db4acd29c57f3b6def3e3008d46765a38","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:APM","release_note:skip","Team: Actionable Observability","backport:prev-minor","v8.10.0"],"number":160928,"url":"https://github.com/elastic/kibana/pull/160928","mergeCommit":{"message":"[AO] Remove default recovery messages for APM rule types (#160928)\n\nFixes #160926\r\nPartially reverts https://github.com/elastic/kibana/pull/159571\r\n\r\n## Summary\r\n\r\nAt the moment, we don't have any context for recovered alerts for APM\r\nrule types, and the default messages will be empty. We will bring these\r\nmessages back after #158183 is\r\ndone.\r\n\r\n## 🧪 How to test\r\n- When creating an APM rule, add an action for the recovered state. You\r\nshould see the default recovery message as Recovered\r\n\r\n<img\r\nsrc=\"https://github.com/elastic/kibana/assets/12370520/eb6ef0cc-0dbc-4758-a73e-4647b068f9a1\"\r\nwidth=\"500\"/>","sha":"3382061db4acd29c57f3b6def3e3008d46765a38"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160928","number":160928,"mergeCommit":{"message":"[AO] Remove default recovery messages for APM rule types (#160928)\n\nFixes #160926\r\nPartially reverts https://github.com/elastic/kibana/pull/159571\r\n\r\n## Summary\r\n\r\nAt the moment, we don't have any context for recovered alerts for APM\r\nrule types, and the default messages will be empty. We will bring these\r\nmessages back after #158183 is\r\ndone.\r\n\r\n## 🧪 How to test\r\n- When creating an APM rule, add an action for the recovered state. You\r\nshould see the default recovery message as Recovered\r\n\r\n<img\r\nsrc=\"https://github.com/elastic/kibana/assets/12370520/eb6ef0cc-0dbc-4758-a73e-4647b068f9a1\"\r\nwidth=\"500\"/>","sha":"3382061db4acd29c57f3b6def3e3008d46765a38"}}]}] BACKPORT--> Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #157284, closes #158437
Summary
This PR updates the default action and recovery message for observability rule types. Only uptime is excluded in this PR, I will add that after synching with the synthetics team.
Here you can find the list of default messages and the new proposals.
🧪 How to test
server.publicBaseUrlis configured in kibana.dev.yml