Skip to content

Commit

Permalink
[AO] Remove default recovery messages for APM rule types (elastic#160928
Browse files Browse the repository at this point in the history
)

Fixes elastic#160926
Partially reverts elastic#159571

## Summary

At the moment, we don't have any context for recovered alerts for APM
rule types, and the default messages will be empty. We will bring these
messages back after elastic#158183 is
done.

## 🧪 How to test
- When creating an APM rule, add an action for the recovered state. You
should see the default recovery message as Recovered

<img
src="https://github.com/elastic/kibana/assets/12370520/eb6ef0cc-0dbc-4758-a73e-4647b068f9a1"
width="500"/>

(cherry picked from commit 3382061)
  • Loading branch information
maryam-saeidi committed Jun 30, 2023
1 parent b20e7b9 commit 97d510a
Showing 1 changed file with 0 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,9 @@ import {
import { ApmRuleType } from '../../../../common/rules/apm_rule_types';
import {
anomalyMessage,
anomalyRecoveryMessage,
errorCountMessage,
errorCountRecoveryMessage,
transactionDurationMessage,
transactionDurationRecoveryMessage,
transactionErrorRateMessage,
transactionErrorRateRecoveryMessage,
} from '../../../../common/rules/default_action_message';

// copied from elasticsearch_fieldnames.ts to limit page load bundle size
Expand Down Expand Up @@ -59,7 +55,6 @@ export function registerApmRuleTypes(
}),
requiresAppContext: false,
defaultActionMessage: errorCountMessage,
defaultRecoveryMessage: errorCountRecoveryMessage,
});

observabilityRuleTypeRegistry.register({
Expand Down Expand Up @@ -97,7 +92,6 @@ export function registerApmRuleTypes(
),
requiresAppContext: false,
defaultActionMessage: transactionDurationMessage,
defaultRecoveryMessage: transactionDurationRecoveryMessage,
});

observabilityRuleTypeRegistry.register({
Expand Down Expand Up @@ -130,7 +124,6 @@ export function registerApmRuleTypes(
}),
requiresAppContext: false,
defaultActionMessage: transactionErrorRateMessage,
defaultRecoveryMessage: transactionErrorRateRecoveryMessage,
});

observabilityRuleTypeRegistry.register({
Expand Down Expand Up @@ -160,6 +153,5 @@ export function registerApmRuleTypes(
}),
requiresAppContext: false,
defaultActionMessage: anomalyMessage,
defaultRecoveryMessage: anomalyRecoveryMessage,
});
}

0 comments on commit 97d510a

Please sign in to comment.