Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cypress@13.3.0 #162383

Merged

Conversation

patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented Jul 22, 2023

Summary

Bump Cypress-related dependencies to the latest versions and update renovate.json to do it automatically in the future

@patrykkopycinski patrykkopycinski marked this pull request as ready for review July 22, 2023 21:59
@patrykkopycinski patrykkopycinski requested a review from a team as a code owner July 22, 2023 21:59
@patrykkopycinski patrykkopycinski added the release_note:skip Skip the PR/issue when compiling release notes label Jul 22, 2023
@patrykkopycinski patrykkopycinski self-assigned this Jul 24, 2023
@patrykkopycinski patrykkopycinski removed the request for review from a team July 24, 2023 18:50
@patrykkopycinski patrykkopycinski changed the title Bump cypress@12.17.2 Bump cypress@12.17.3 Aug 9, 2023
@patrykkopycinski patrykkopycinski requested review from a team as code owners August 10, 2023 12:26
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Aug 10, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@patrykkopycinski patrykkopycinski marked this pull request as draft August 10, 2023 12:58
…cypress

# Conflicts:
#	x-pack/test/security_solution_cypress/cypress/support/old_headless.ts
#	x-pack/test_serverless/functional/test_suites/security/cypress/cypress.config.ts
#	yarn.lock
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Profiling changes LGTM

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 30, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #18 / Alerting APIs Alerting rules "after each" hook for "should retry when appropriate"
  • [job] [logs] Defend Workflows Cypress Tests #4 / Artifact pages Trusted applications should update Endpoint Policy on Endpoint when adding Trusted application name should update Endpoint Policy on Endpoint when adding Trusted application name
  • [job] [logs] Security Solution Cypress Tests #9 / Ransomware Detection Alerts Ransomware in Timelines Renders ransomware entries in timelines table Renders ransomware entries in timelines table

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @patrykkopycinski

@patrykkopycinski patrykkopycinski enabled auto-merge (squash) September 30, 2023 22:15
@patrykkopycinski patrykkopycinski merged commit 924664f into elastic:main Oct 1, 2023
@kibanamachine kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Oct 1, 2023
@patrykkopycinski patrykkopycinski deleted the chore/renovate-cypress branch October 1, 2023 09:52
@patrykkopycinski patrykkopycinski added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) backport:prev-major Backport to (8.x, 8.17, 8.16, 8.15) the previous major branch and other branches in development and removed backport:skip This commit does not require backporting labels Oct 2, 2023
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
7.17 Backport failed because of merge conflicts
8.10 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 162383

Questions ?

Please refer to the Backport tool documentation

1 similar comment
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
7.17 Backport failed because of merge conflicts
8.10 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 162383

Questions ?

Please refer to the Backport tool documentation

patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Oct 2, 2023
## Summary

Bump Cypress-related dependencies to the latest versions and update
`renovate.json` to do it automatically in the future

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Gloria Hornero <gloria.hornero@elastic.co>
(cherry picked from commit 924664f)

# Conflicts:
#	.buildkite/pipelines/pull_request/security_solution.yml
#	package.json
#	yarn.lock
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Oct 2, 2023
## Summary

Bump Cypress-related dependencies to the latest versions and update
`renovate.json` to do it automatically in the future

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Gloria Hornero <gloria.hornero@elastic.co>
(cherry picked from commit 924664f)

# Conflicts:
#	.buildkite/pipelines/pull_request/security_solution.yml
#	package.json
#	renovate.json
#	x-pack/plugins/apm/ftr_e2e/config.ts
#	x-pack/plugins/apm/ftr_e2e/cypress.config.ts
#	x-pack/plugins/apm/ftr_e2e/cypress_test_runner.ts
#	x-pack/plugins/observability_onboarding/e2e/cypress.config.ts
#	x-pack/plugins/observability_onboarding/e2e/ftr_config_runner.ts
#	x-pack/plugins/profiling/e2e/cypress.config.ts
#	x-pack/plugins/profiling/e2e/ftr_config_runner.ts
#	x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/detection_page_filters.cy.ts
#	x-pack/test/security_solution_cypress/cypress/e2e/investigations/timelines/open_timeline.cy.ts
#	x-pack/test_serverless/functional/test_suites/observability/cypress/cypress.config.ts
#	yarn.lock
patrykkopycinski added a commit that referenced this pull request Oct 2, 2023
# Backport

This will backport the following commits from `main` to `8.10`:
- [Bump cypress@13.3.0
(#162383)](#162383)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Patryk
Kopyciński","email":"contact@patrykkopycinski.com"},"sourceCommit":{"committedDate":"2023-10-01T08:55:01Z","message":"Bump
cypress@13.3.0 (#162383)\n\n## Summary\r\n\r\nBump Cypress-related
dependencies to the latest versions and update\r\n`renovate.json` to do
it automatically in the future\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Gloria Hornero
<gloria.hornero@elastic.co>","sha":"924664fc79d29a3f77014902c1d7d24537a5d9e3","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:APM","release_note:skip","Team:Fleet","ci:all-cypress-suites","backport:prev-minor","backport:prev-MAJOR","v8.11.0"],"number":162383,"url":"https://github.com/elastic/kibana/pull/162383","mergeCommit":{"message":"Bump
cypress@13.3.0 (#162383)\n\n## Summary\r\n\r\nBump Cypress-related
dependencies to the latest versions and update\r\n`renovate.json` to do
it automatically in the future\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Gloria Hornero
<gloria.hornero@elastic.co>","sha":"924664fc79d29a3f77014902c1d7d24537a5d9e3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/162383","number":162383,"mergeCommit":{"message":"Bump
cypress@13.3.0 (#162383)\n\n## Summary\r\n\r\nBump Cypress-related
dependencies to the latest versions and update\r\n`renovate.json` to do
it automatically in the future\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Gloria Hornero
<gloria.hornero@elastic.co>","sha":"924664fc79d29a3f77014902c1d7d24537a5d9e3"}}]}]
BACKPORT-->
achyutjhunjhunwala added a commit that referenced this pull request Oct 2, 2023
## Summary

As part of this [PR](#167623),
added a logic to handle hiding of Logs Panels which was consuming a lot
of memory.

With [Cypress Upgrade](#162383) to
13.x, this issue is now fixed and hence this can be reverted.

## How to be sure this works ?
If the PR passes the build, you know it works
patrykkopycinski added a commit that referenced this pull request Oct 2, 2023
# Backport

This will backport the following commits from `main` to `7.17`:
- [Bump cypress@13.3.0
(#162383)](#162383)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Patryk
Kopyciński","email":"contact@patrykkopycinski.com"},"sourceCommit":{"committedDate":"2023-10-01T08:55:01Z","message":"Bump
cypress@13.3.0 (#162383)\n\n## Summary\r\n\r\nBump Cypress-related
dependencies to the latest versions and update\r\n`renovate.json` to do
it automatically in the future\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Gloria Hornero
<gloria.hornero@elastic.co>","sha":"924664fc79d29a3f77014902c1d7d24537a5d9e3","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:APM","release_note:skip","Team:Fleet","ci:all-cypress-suites","backport:prev-minor","backport:prev-MAJOR","v8.11.0"],"number":162383,"url":"https://github.com/elastic/kibana/pull/162383","mergeCommit":{"message":"Bump
cypress@13.3.0 (#162383)\n\n## Summary\r\n\r\nBump Cypress-related
dependencies to the latest versions and update\r\n`renovate.json` to do
it automatically in the future\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Gloria Hornero
<gloria.hornero@elastic.co>","sha":"924664fc79d29a3f77014902c1d7d24537a5d9e3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/162383","number":162383,"mergeCommit":{"message":"Bump
cypress@13.3.0 (#162383)\n\n## Summary\r\n\r\nBump Cypress-related
dependencies to the latest versions and update\r\n`renovate.json` to do
it automatically in the future\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Gloria Hornero
<gloria.hornero@elastic.co>","sha":"924664fc79d29a3f77014902c1d7d24537a5d9e3"}}]}]
BACKPORT-->

---------

Co-authored-by: Gloria Hornero <gloria.hornero@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-major Backport to (8.x, 8.17, 8.16, 8.15) the previous major branch and other branches in development backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:all-cypress-suites release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Fleet Team label for Observability Data Collection Fleet team v7.17.14 v8.10.3 v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.