Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Add feature flag for APM table search #174750

Merged
merged 3 commits into from
Jan 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/management/advanced-options.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,9 @@ Set the default environment for the APM app. When left empty, data from all envi
[[observability-apm-enable-profiling]]`observability:apmEnableProfilingIntegration`::
Enable the Universal Profiling integration in APM.

[[observability-apm-enable-table-search-bar]]`observability:apmEnableTableSearchBar`::
beta:[] Enables faster searching in APM tables by adding a handy search bar with live filtering. Available for the following tables: Services, Transactions, and Errors.

[[observability-enable-aws-lambda-metrics]]`observability:enableAwsLambdaMetrics`::
preview:[] Display Amazon Lambda metrics in the service metrics tab.

Expand Down
2 changes: 2 additions & 0 deletions packages/kbn-management/settings/setting_ids/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,8 @@ export const OBSERVABILITY_APM_ENABLE_CONTINUOUS_ROLLUPS_ID =
export const OBSERVABILITY_APM_ENABLE_PROFILING_INTEGRATION_ID =
'observability:apmEnableProfilingIntegration';

export const OBSERVABILITY_APM_ENABLE_TABLE_SEARCH_BAR = 'observability:apmEnableTableSearchBar';

// Reporting settings
export const XPACK_REPORTING_CUSTOM_PDF_LOGO_ID = 'xpackReporting:customPdfLogo';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -449,6 +449,10 @@ export const stackManagementSchema: MakeSchemaFrom<UsageStats> = {
type: 'boolean',
_meta: { description: 'Non-default value of setting.' },
},
'observability:apmEnableTableSearchBar': {
type: 'boolean',
_meta: { description: 'Non-default value of setting.' },
},
'observability:apmAWSLambdaPriceFactor': {
type: 'text',
_meta: { description: 'Non-default value of setting.' },
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ export interface UsageStats {
'observability:enableInfrastructureHostsView': boolean;
'observability:enableInfrastructureProfilingIntegration': boolean;
'observability:apmAgentExplorerView': boolean;
'observability:apmEnableTableSearchBar': boolean;
'visualization:heatmap:maxBuckets': number;
'visualization:colorMapping': string;
'visualization:useLegacyTimeAxis': boolean;
Expand Down
6 changes: 6 additions & 0 deletions src/plugins/telemetry/schema/oss_plugins.json
Original file line number Diff line number Diff line change
Expand Up @@ -9863,6 +9863,12 @@
"description": "Non-default value of setting."
}
},
"observability:apmEnableTableSearchBar": {
"type": "boolean",
"_meta": {
"description": "Non-default value of setting."
}
},
"observability:apmAWSLambdaPriceFactor": {
"type": "text",
"_meta": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import {
apmEnableContinuousRollups,
enableAgentExplorerView,
apmEnableProfilingIntegration,
apmEnableTableSearchBar,
} from '@kbn/observability-plugin/common';
import { isEmpty } from 'lodash';
import React from 'react';
Expand All @@ -41,6 +42,7 @@ const apmSettingsKeys = [
apmEnableServiceMetrics,
apmEnableContinuousRollups,
enableAgentExplorerView,
apmEnableTableSearchBar,
apmEnableProfilingIntegration,
];

Expand Down
1 change: 1 addition & 0 deletions x-pack/plugins/observability/common/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export {
enableInfrastructureProfilingIntegration,
enableAwsLambdaMetrics,
enableAgentExplorerView,
apmEnableTableSearchBar,
apmAWSLambdaPriceFactor,
apmAWSLambdaRequestCostPerMillion,
apmEnableServiceMetrics,
Expand Down
1 change: 1 addition & 0 deletions x-pack/plugins/observability/common/ui_settings_keys.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ export const enableInfrastructureProfilingIntegration =
'observability:enableInfrastructureProfilingIntegration';
export const enableAwsLambdaMetrics = 'observability:enableAwsLambdaMetrics';
export const enableAgentExplorerView = 'observability:apmAgentExplorerView';
export const apmEnableTableSearchBar = 'observability:apmEnableTableSearchBar';
export const apmAWSLambdaPriceFactor = 'observability:apmAWSLambdaPriceFactor';
export const apmAWSLambdaRequestCostPerMillion = 'observability:apmAWSLambdaRequestCostPerMillion';
export const enableCriticalPath = 'observability:apmEnableCriticalPath';
Expand Down
1 change: 1 addition & 0 deletions x-pack/plugins/observability/public/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ export {
apmServiceGroupMaxNumberOfServices,
enableInfrastructureHostsView,
enableAgentExplorerView,
apmEnableTableSearchBar,
} from '../common/ui_settings_keys';
export {
alertsLocatorID,
Expand Down
18 changes: 18 additions & 0 deletions x-pack/plugins/observability/server/ui_settings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import {
apmTraceExplorerTab,
apmLabsButton,
enableAgentExplorerView,
apmEnableTableSearchBar,
enableAwsLambdaMetrics,
apmAWSLambdaPriceFactor,
apmAWSLambdaRequestCostPerMillion,
Expand Down Expand Up @@ -284,6 +285,23 @@ export const uiSettings: Record<string, UiSettings> = {
requiresPageReload: true,
type: 'boolean',
},
[apmEnableTableSearchBar]: {
category: [observabilityFeatureId],
name: i18n.translate('xpack.observability.apmEnableTableSearchBar', {
defaultMessage: 'Instant table search',
}),
description: i18n.translate('xpack.observability.apmEnableTableSearchBarDescription', {
defaultMessage:
'{betaLabel} Enables faster searching in APM tables by adding a handy search bar with live filtering. Available for the following tables: Services, Transactions and Errors',
values: {
betaLabel: `<em>[${betaLabel}]</em>`,
},
}),
schema: schema.boolean(),
value: false,
requiresPageReload: false,
type: 'boolean',
},
[apmAWSLambdaPriceFactor]: {
category: [observabilityFeatureId],
name: i18n.translate('xpack.observability.apmAWSLambdaPricePerGbSeconds', {
Expand Down