Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Add feature flag for APM table search #174750

Merged
merged 3 commits into from
Jan 12, 2024
Merged

[APM] Add feature flag for APM table search #174750

merged 3 commits into from
Jan 12, 2024

Conversation

sorenlouv
Copy link
Member

This adds a feature flag for table search (#127036). The feature itself is being worked on in #174490

@sorenlouv sorenlouv requested review from a team as code owners January 12, 2024 13:11
@botelastic botelastic bot added Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team labels Jan 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@sorenlouv sorenlouv added v8.12.0 and removed Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team labels Jan 12, 2024
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@sorenlouv sorenlouv added the release_note:skip Skip the PR/issue when compiling release notes label Jan 12, 2024
@sorenlouv sorenlouv mentioned this pull request Jan 12, 2024
Merged
@sorenlouv sorenlouv force-pushed the add-table-search-feature-flag branch from 05958bf to 68b176f Compare January 12, 2024 13:31
@botelastic botelastic bot added Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team labels Jan 12, 2024
cauemarcondes
cauemarcondes approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sorenlouv sorenlouv force-pushed the add-table-search-feature-flag branch from 68b176f to 47ac73b Compare January 12, 2024 13:41
@sorenlouv sorenlouv requested a review from a team as a code owner January 12, 2024 13:41
maryam-saeidi
maryam-saeidi approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@maryam-saeidi maryam-saeidi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only, new apmEnableTableSearchBar UI setting LGTM!

ElenaStoeva
ElenaStoeva approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sorenlouv sorenlouv added v8.13.0 and removed v8.12.0 labels Jan 12, 2024
bmorelli25
bmorelli25 approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look good! Thanks

tsullivan
tsullivan approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages/kbn-management changes look good from the #appex-sharedux side.

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #58 / endpoint "before all" hook in "endpoint"
  • [job] [logs] FTR Configs #1 / Serverless Common UI - Examples Search examples handling warnings with search source fetch "after all" hook for "should show search warnings in results tab"
  • [job] [logs] FTR Configs #1 / Serverless Common UI - Examples Search examples handling warnings with search source fetch "before all" hook for "should show search warnings as toasts"

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/management-settings-ids 130 131 +1
observability 596 606 +10
total +11

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.1MB 3.1MB +26.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 101.1KB 101.2KB +192.0B
Unknown metric groups

API count

id before after diff
@kbn/management-settings-ids 132 133 +1
observability 605 615 +10
total +11

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

TinaHeiligers
TinaHeiligers approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sorenlouv sorenlouv merged commit 0dd4e37 into elastic:main Jan 12, 2024
23 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 12, 2024
@sorenlouv sorenlouv deleted the add-table-search-feature-flag branch January 12, 2024 18:52
cauemarcondes added a commit that referenced this pull request Jan 30, 2024
@sorenlouv @cauemarcondes @kibanamachine
[APM] Add table search to services, transactions and errors (#174490)
c0077d6 
Closes: #127036

This adds the ability to easily search for data in tables. The search
will be performed server side if there are more results than initially
returned by Elasticsearch. If all results were returned the search is
performed client side to provide a more snappy experience.
The feature is guarded by a feature flag (disabled by default) and only
available for services, transactions and errors table.

# Transactions


![quick-filtering](https://github.com/elastic/kibana/assets/209966/20684b88-a103-4000-a012-ee6e35479b44)

# Errors


![error3](https://github.com/elastic/kibana/assets/209966/c7f09dd9-24a5-482a-ae72-4c4477f65d3a)


**Dependencies:**

- #173973
- #174746
- #174750

---------

Co-authored-by: Caue Marcondes <caue.marcondes@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@sorenlouv @cauemarcondes
@kibanamachine @CoenWarmer
[APM] Add table search to services, transactions and errors (elastic#…
4e6c910 
…174490)

Closes: elastic#127036

This adds the ability to easily search for data in tables. The search
will be performed server side if there are more results than initially
returned by Elasticsearch. If all results were returned the search is
performed client side to provide a more snappy experience.
The feature is guarded by a feature flag (disabled by default) and only
available for services, transactions and errors table.

# Transactions


![quick-filtering](https://github.com/elastic/kibana/assets/209966/20684b88-a103-4000-a012-ee6e35479b44)

# Errors


![error3](https://github.com/elastic/kibana/assets/209966/c7f09dd9-24a5-482a-ae72-4c4477f65d3a)


**Dependencies:**

- elastic#173973
- elastic#174746
- elastic#174750

---------

Co-authored-by: Caue Marcondes <caue.marcondes@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
@sorenlouv @cauemarcondes
@kibanamachine @fkanout
[APM] Add table search to services, transactions and errors (elastic#…
6041bbb 
…174490)

Closes: elastic#127036

This adds the ability to easily search for data in tables. The search
will be performed server side if there are more results than initially
returned by Elasticsearch. If all results were returned the search is
performed client side to provide a more snappy experience.
The feature is guarded by a feature flag (disabled by default) and only
available for services, transactions and errors table.

# Transactions


![quick-filtering](https://github.com/elastic/kibana/assets/209966/20684b88-a103-4000-a012-ee6e35479b44)

# Errors


![error3](https://github.com/elastic/kibana/assets/209966/c7f09dd9-24a5-482a-ae72-4c4477f65d3a)


**Dependencies:**

- elastic#173973
- elastic#174746
- elastic#174750

---------

Co-authored-by: Caue Marcondes <caue.marcondes@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElenaStoeva ElenaStoeva ElenaStoeva approved these changes

@cauemarcondes cauemarcondes cauemarcondes approved these changes

@maryam-saeidi maryam-saeidi maryam-saeidi approved these changes

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

@bmorelli25 bmorelli25 bmorelli25 approved these changes

@tsullivan tsullivan tsullivan approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.