[APM] Synthtrace high cardinality scenarios #174746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
Team:obs-ux-infra_services
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
sorenlouv
added
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
sorenlouv
force-pushed
the
synthtrace-improvements
branch
from
e6ab8e1 to
bbecbdf
Compare
botelastic
bot
added
the
Team:obs-ux-infra_services
sorenlouv
changed the title
gbamparop
approved these changes
Jan 12, 2024
kpatticha
reviewed
Jan 12, 2024
| * Side Public License, v 1. | ||
| */ | ||
|
|
||
| export const randomNames = [ |
There was a problem hiding this comment.
this should be renamed to ancient Greek random names 😆
There was a problem hiding this comment.
I thought you and @gbamparop would like it :D
kpatticha
reviewed
Jan 12, 2024
| generate: ({ range, clients: { apmEsClient } }) => { | ||
| const instances = times(numInstances).map((index) => { | ||
| const agentVersion = agentVersions[index % agentVersions.length]; | ||
| const randomName = serviceNames[index % serviceNames.length]; |
There was a problem hiding this comment.
nit:
Suggested change
| const randomName = serviceNames[index % serviceNames.length]; | |
| const randomName = getRandomNameForIndex[index]; |
kpatticha
reviewed
Jan 12, 2024
| apm | ||
| .service({ | ||
| name: `${services[index % services.length]}-${language}-${index}`, | ||
| name: `${serviceNames[index % serviceNames.length]}-${language}-${index}`, |
There was a problem hiding this comment.
Suggested change
| name: `${serviceNames[index % serviceNames.length]}-${language}-${index}`, | |
| name: `${getRandomNameForIndex[index]-${language}-${index}`, |
kpatticha
approved these changes
Jan 12, 2024
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
semd
pushed a commit
to semd/kibana
that referenced
this pull request
Jan 12, 2024
While working on elastic#127036 I needed scenarios for creating a high number of services, transactions and errors. I've removed some unnecessary stuff in the scenarios that we already have elsewhere to make them run faster.
| * Side Public License, v 1. | ||
| */ | ||
|
|
||
| export const randomGreekishNames = [ |
There was a problem hiding this comment.
@sqren If i were you, i would have sneaked in my name 😆
cauemarcondes
added a commit
that referenced
this pull request
Jan 30, 2024
Closes: #127036 This adds the ability to easily search for data in tables. The search will be performed server side if there are more results than initially returned by Elasticsearch. If all results were returned the search is performed client side to provide a more snappy experience. The feature is guarded by a feature flag (disabled by default) and only available for services, transactions and errors table. # Transactions  # Errors  **Dependencies:** - #173973 - #174746 - #174750 --------- Co-authored-by: Caue Marcondes <caue.marcondes@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
…174490) Closes: elastic#127036 This adds the ability to easily search for data in tables. The search will be performed server side if there are more results than initially returned by Elasticsearch. If all results were returned the search is performed client side to provide a more snappy experience. The feature is guarded by a feature flag (disabled by default) and only available for services, transactions and errors table. # Transactions  # Errors  **Dependencies:** - elastic#173973 - elastic#174746 - elastic#174750 --------- Co-authored-by: Caue Marcondes <caue.marcondes@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
…174490) Closes: elastic#127036 This adds the ability to easily search for data in tables. The search will be performed server side if there are more results than initially returned by Elasticsearch. If all results were returned the search is performed client side to provide a more snappy experience. The feature is guarded by a feature flag (disabled by default) and only available for services, transactions and errors table. # Transactions  # Errors  **Dependencies:** - elastic#173973 - elastic#174746 - elastic#174750 --------- Co-authored-by: Caue Marcondes <caue.marcondes@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #127036 I needed scenarios for creating a high number of services, transactions and errors. I've removed some unnecessary stuff in the scenarios that we already have elsewhere to make them run faster.