[APM] Add table search to services, transactions and errors #174490

sorenlouv · 2024-01-08T22:36:35Z

This adds the ability to easily search for data in tables. The search will be performed server side if there are more results than initially returned by Elasticsearch. If all results were returned the search is performed client side to provide a more snappy experience.
The feature is guarded by a feature flag (disabled by default) and only available for services, transactions and errors table.

Transactions

Errors

Dependencies:

apmmachine · 2024-01-08T22:36:51Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
/oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

This adds a feature flag for table search (#127036). The feature itself is being worked on in #174490

x-pack/plugins/apm/public/components/app/error_group_overview/error_group_list/index.tsx

x-pack/plugins/apm/public/components/app/error_group_overview/index.tsx

elasticmachine · 2024-01-16T14:01:17Z

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

elasticmachine · 2024-01-16T14:01:17Z

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

x-pack/plugins/apm/public/components/shared/transactions_table/index.tsx

...k/plugins/apm/public/components/app/service_overview/service_overview_errors_table/index.tsx

x-pack/plugins/apm/public/components/app/service_inventory/index.tsx

…to-errors

cauemarcondes

LGTM

achyutjhunjhunwala · 2024-01-29T17:27:36Z

Synthtrace changes are LGTM

kibana-ci · 2024-01-30T14:54:57Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`apm`	1604	1607	+3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/apm-synthtrace-client`	188	189	+1
`observability`	606	610	+4
total			+5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	3.2MB	3.2MB	+473.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/apm-synthtrace-client`	188	189	+1
`observability`	615	619	+4
total			+5

ESLint disabled line counts

id	before	after	diff
`apm`	77	75	-2

Total ESLint disabled count

id	before	after	diff
`apm`	91	89	-2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…174490) Closes: elastic#127036 This adds the ability to easily search for data in tables. The search will be performed server side if there are more results than initially returned by Elasticsearch. If all results were returned the search is performed client side to provide a more snappy experience. The feature is guarded by a feature flag (disabled by default) and only available for services, transactions and errors table. # Transactions ![quick-filtering](https://github.com/elastic/kibana/assets/209966/20684b88-a103-4000-a012-ee6e35479b44) # Errors ![error3](https://github.com/elastic/kibana/assets/209966/c7f09dd9-24a5-482a-ae72-4c4477f65d3a) **Dependencies:** - elastic#173973 - elastic#174746 - elastic#174750 --------- Co-authored-by: Caue Marcondes <caue.marcondes@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

sorenlouv force-pushed the add-search-bar-to-errors branch 3 times, most recently from 03c50da to 3ace84a Compare January 12, 2024 12:53

sorenlouv changed the title ~~Add search bar to errors~~ [APM] Add table search to APM services, transactions and errors Jan 12, 2024

sorenlouv mentioned this pull request Jan 12, 2024

[APM] Add feature flag for APM table search #174750

Merged

sorenlouv added v8.13.0 release_note:enhancement labels Jan 12, 2024

sorenlouv force-pushed the add-search-bar-to-errors branch 2 times, most recently from 082e4d4 to b615cac Compare January 12, 2024 17:44

sorenlouv added a commit that referenced this pull request Jan 12, 2024

[APM] Add feature flag for APM table search (#174750)

0dd4e37

This adds a feature flag for table search (#127036). The feature itself is being worked on in #174490

sorenlouv force-pushed the add-search-bar-to-errors branch from b615cac to 5923466 Compare January 13, 2024 18:34

sorenlouv commented Jan 14, 2024

View reviewed changes

x-pack/plugins/apm/public/components/app/error_group_overview/error_group_list/index.tsx Outdated Show resolved Hide resolved

sorenlouv commented Jan 14, 2024

View reviewed changes

x-pack/plugins/apm/public/components/app/error_group_overview/index.tsx Outdated Show resolved Hide resolved

sorenlouv force-pushed the add-search-bar-to-errors branch from 3b87ba6 to 9165c71 Compare January 15, 2024 09:58

sorenlouv marked this pull request as ready for review January 16, 2024 14:01

sorenlouv requested review from a team as code owners January 16, 2024 14:01

sorenlouv force-pushed the add-search-bar-to-errors branch from f82fc14 to 9758819 Compare January 16, 2024 14:01

botelastic bot added Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team labels Jan 16, 2024

sorenlouv changed the title ~~[APM] Add table search to APM services, transactions and errors~~ [APM] Add table search to services, transactions and errors Jan 16, 2024

sorenlouv added 4 commits January 16, 2024 15:21

[APM] Add TableSearchBar component

34b3851

Integrate feature flag

7d8251a

Fix naming stuff

20f8dab

Improve synthtrace scenario

78d253b

cauemarcondes reviewed Jan 18, 2024

View reviewed changes

x-pack/plugins/apm/public/components/shared/transactions_table/index.tsx Show resolved Hide resolved

cauemarcondes reviewed Jan 18, 2024

View reviewed changes

...k/plugins/apm/public/components/app/service_overview/service_overview_errors_table/index.tsx Show resolved Hide resolved

cauemarcondes reviewed Jan 18, 2024

View reviewed changes

x-pack/plugins/apm/public/components/app/service_inventory/index.tsx Outdated Show resolved Hide resolved

sorenlouv and others added 8 commits January 22, 2024 11:13

Add requestId back

6ee9615

addressing pr comments

1486cf3

Merge branch 'main' of github.com:elastic/kibana into add-search-bar-…

5c1a294

…to-errors

fixing storybook

bb6d2a1

fixing error table

e19c9d7

adding e2e test

3e58177

i18n

e50d730

fixing ci

6cb1bc4

cauemarcondes approved these changes Jan 29, 2024

View reviewed changes

fixing tests

ce65768

achyutjhunjhunwala approved these changes Jan 29, 2024

View reviewed changes

shahzad31 approved these changes Jan 29, 2024

View reviewed changes

cauemarcondes added 3 commits January 30, 2024 09:54

fixing tests

c37e963

fixing ci / enabling by default

0266d5a

removing only

949a94d

cauemarcondes merged commit c0077d6 into elastic:main Jan 30, 2024
21 checks passed

kibanamachine added the backport:skip This commit does not require backporting label Jan 30, 2024

sorenlouv deleted the add-search-bar-to-errors branch January 31, 2024 00:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[APM] Add table search to services, transactions and errors #174490

[APM] Add table search to services, transactions and errors #174490

sorenlouv commented Jan 8, 2024 •

edited

Loading

apmmachine commented Jan 8, 2024

elasticmachine commented Jan 16, 2024

elasticmachine commented Jan 16, 2024

cauemarcondes left a comment

achyutjhunjhunwala commented Jan 29, 2024

kibana-ci commented Jan 30, 2024

API count

ESLint disabled line counts

Total ESLint disabled count

[APM] Add table search to services, transactions and errors #174490

[APM] Add table search to services, transactions and errors #174490

Conversation

sorenlouv commented Jan 8, 2024 • edited Loading

Transactions

Errors

apmmachine commented Jan 8, 2024

🤖 GitHub comments

elasticmachine commented Jan 16, 2024

elasticmachine commented Jan 16, 2024

cauemarcondes left a comment

Choose a reason for hiding this comment

achyutjhunjhunwala commented Jan 29, 2024

kibana-ci commented Jan 30, 2024

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

API count

ESLint disabled line counts

Total ESLint disabled count

History

sorenlouv commented Jan 8, 2024 •

edited

Loading