fix: [SCREEN READER]: flyouts must announce itself on render and manage focus #180888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
alexwizp
added
release_note:skip
|
/ci |
|
/ci |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
|
Pinging @elastic/security-detection-engine (Team:Detection Engine) |
# Conflicts: # x-pack/plugins/security_solution/public/management/pages/event_filters/view/components/event_filters_flyout.tsx
vitaliidm
reviewed
Apr 17, 2024
...y_solution/public/detection_engine/rule_exceptions/components/add_exception_flyout/index.tsx
Show resolved
Hide resolved
..._solution/public/detection_engine/rule_exceptions/components/edit_exception_flyout/index.tsx
Show resolved
Hide resolved
vitaliidm
approved these changes
Apr 17, 2024
...y_solution/public/detection_engine/rule_exceptions/components/add_exception_flyout/index.tsx
Show resolved
Hide resolved
nikitaindik
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Thanks for the fixes @alexwizp! I checked the code and tested it with a screen reader. LGTM!
paul-tavares
approved these changes
Apr 22, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @alexwizp |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 23, 2024
…ge focus (elastic#180888) Part of: elastic/security-team#8657 ## Summary This PR is a component of elastic/security-team#8657 and addresses a part of the issue where the flyout must announce itself upon render. This issue was found to be valid for almost all flyouts in the Security Solution's code, and this PR rectifies these cases. ## What was done? 1. In accordance with [EUI doc](https://eui.elastic.co/#/layout/flyout) we should `Use aria-labelledby={headingId} to announce the flyout to screen readers.` ## Screens: ### `a11y` tree #### Before: <img width="1591" alt="image" src="https://github.com/elastic/kibana/assets/20072247/879e7cd6-22dd-4642-8b72-3da95866da9f"> #### After: <img width="1445" alt="image" src="https://github.com/elastic/kibana/assets/20072247/3328c6fd-b0bd-46d7-9251-b4ca3905900d"> (cherry picked from commit b67d45b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 23, 2024
…nd manage focus (#180888) (#181397) # Backport This will backport the following commits from `main` to `8.14`: - [fix: [SCREEN READER]: flyouts must announce itself on render and manage focus (#180888)](#180888) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2024-04-23T09:19:13Z","message":"fix: [SCREEN READER]: flyouts must announce itself on render and manage focus (#180888)\n\nPart of: https://github.com/elastic/security-team/issues/8657\r\n\r\n## Summary\r\n\r\nThis PR is a component of\r\nhttps://github.com/elastic/security-team/issues/8657 and addresses a\r\npart of the issue where the flyout must announce itself upon render.\r\nThis issue was found to be valid for almost all flyouts in the Security\r\nSolution's code, and this PR rectifies these cases.\r\n\r\n## What was done?\r\n1. In accordance with [EUI doc](https://eui.elastic.co/#/layout/flyout)\r\nwe should `Use aria-labelledby={headingId} to announce the flyout to\r\nscreen readers.`\r\n\r\n## Screens: \r\n\r\n### `a11y` tree\r\n\r\n#### Before:\r\n<img width=\"1591\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/20072247/879e7cd6-22dd-4642-8b72-3da95866da9f\">\r\n\r\n#### After:\r\n\r\n<img width=\"1445\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/20072247/3328c6fd-b0bd-46d7-9251-b4ca3905900d\">","sha":"b67d45b3d2485485fa111f814f8c80934ba1df30","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team: SecuritySolution","Team:Defend Workflows","Team:Detection Rule Management","Team:Detection Engine","v8.14.0","v8.15.0"],"title":"fix: [SCREEN READER]: flyouts must announce itself on render and manage focus","number":180888,"url":"https://github.com/elastic/kibana/pull/180888","mergeCommit":{"message":"fix: [SCREEN READER]: flyouts must announce itself on render and manage focus (#180888)\n\nPart of: https://github.com/elastic/security-team/issues/8657\r\n\r\n## Summary\r\n\r\nThis PR is a component of\r\nhttps://github.com/elastic/security-team/issues/8657 and addresses a\r\npart of the issue where the flyout must announce itself upon render.\r\nThis issue was found to be valid for almost all flyouts in the Security\r\nSolution's code, and this PR rectifies these cases.\r\n\r\n## What was done?\r\n1. In accordance with [EUI doc](https://eui.elastic.co/#/layout/flyout)\r\nwe should `Use aria-labelledby={headingId} to announce the flyout to\r\nscreen readers.`\r\n\r\n## Screens: \r\n\r\n### `a11y` tree\r\n\r\n#### Before:\r\n<img width=\"1591\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/20072247/879e7cd6-22dd-4642-8b72-3da95866da9f\">\r\n\r\n#### After:\r\n\r\n<img width=\"1445\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/20072247/3328c6fd-b0bd-46d7-9251-b4ca3905900d\">","sha":"b67d45b3d2485485fa111f814f8c80934ba1df30"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/180888","number":180888,"mergeCommit":{"message":"fix: [SCREEN READER]: flyouts must announce itself on render and manage focus (#180888)\n\nPart of: https://github.com/elastic/security-team/issues/8657\r\n\r\n## Summary\r\n\r\nThis PR is a component of\r\nhttps://github.com/elastic/security-team/issues/8657 and addresses a\r\npart of the issue where the flyout must announce itself upon render.\r\nThis issue was found to be valid for almost all flyouts in the Security\r\nSolution's code, and this PR rectifies these cases.\r\n\r\n## What was done?\r\n1. In accordance with [EUI doc](https://eui.elastic.co/#/layout/flyout)\r\nwe should `Use aria-labelledby={headingId} to announce the flyout to\r\nscreen readers.`\r\n\r\n## Screens: \r\n\r\n### `a11y` tree\r\n\r\n#### Before:\r\n<img width=\"1591\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/20072247/879e7cd6-22dd-4642-8b72-3da95866da9f\">\r\n\r\n#### After:\r\n\r\n<img width=\"1445\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/20072247/3328c6fd-b0bd-46d7-9251-b4ca3905900d\">","sha":"b67d45b3d2485485fa111f814f8c80934ba1df30"}}]}] BACKPORT--> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
alexwizp
added a commit
that referenced
this pull request
Apr 25, 2024
…t must announce itself on render and manage focus (#181427) Closes: elastic/security-team#8657 ## Summary The part about announcing the title was fixed in that PR: #180888. This PR removed the incorrect 'ownFocus = { false }' parameter for `EuiFlyout`. Since that flyout overlaps the table, we should not open it with that option. ### Screen  #### Eui documentation https://eui.elastic.co/#/layout/flyout#without-ownfocus
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 25, 2024
…t must announce itself on render and manage focus (elastic#181427) Closes: elastic/security-team#8657 ## Summary The part about announcing the title was fixed in that PR: elastic#180888. This PR removed the incorrect 'ownFocus = { false }' parameter for `EuiFlyout`. Since that flyout overlaps the table, we should not open it with that option. ### Screen  #### Eui documentation https://eui.elastic.co/#/layout/flyout#without-ownfocus (cherry picked from commit 482766e)
kibanamachine
added a commit
that referenced
this pull request
Apr 25, 2024
…odal flyout must announce itself on render and manage focus (#181427) (#181658) # Backport This will backport the following commits from `main` to `8.14`: - [fix: [Rules > Add Elastic rules][SCREEN READER]: Rule non-modal flyout must announce itself on render and manage focus (#181427)](#181427) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2024-04-25T08:11:43Z","message":"fix: [Rules > Add Elastic rules][SCREEN READER]: Rule non-modal flyout must announce itself on render and manage focus (#181427)\n\nCloses: https://github.com/elastic/security-team/issues/8657\r\n\r\n## Summary\r\n\r\nThe part about announcing the title was fixed in that PR:\r\nhttps://github.com//pull/180888. This PR removed the\r\nincorrect 'ownFocus = { false }' parameter for `EuiFlyout`. Since that\r\nflyout overlaps the table, we should not open it with that option.\r\n\r\n### Screen \r\n\r\n\r\n\r\n\r\n#### Eui documentation\r\nhttps://eui.elastic.co/#/layout/flyout#without-ownfocus","sha":"482766e0bfcf2a2297135a3084e0286e22bed888","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team: SecuritySolution","Feature:Rule Management","Team:Detection Rule Management","v8.14.0","v8.15.0"],"title":"fix: [Rules > Add Elastic rules][SCREEN READER]: Rule non-modal flyout must announce itself on render and manage focus","number":181427,"url":"https://github.com/elastic/kibana/pull/181427","mergeCommit":{"message":"fix: [Rules > Add Elastic rules][SCREEN READER]: Rule non-modal flyout must announce itself on render and manage focus (#181427)\n\nCloses: https://github.com/elastic/security-team/issues/8657\r\n\r\n## Summary\r\n\r\nThe part about announcing the title was fixed in that PR:\r\nhttps://github.com//pull/180888. This PR removed the\r\nincorrect 'ownFocus = { false }' parameter for `EuiFlyout`. Since that\r\nflyout overlaps the table, we should not open it with that option.\r\n\r\n### Screen \r\n\r\n\r\n\r\n\r\n#### Eui documentation\r\nhttps://eui.elastic.co/#/layout/flyout#without-ownfocus","sha":"482766e0bfcf2a2297135a3084e0286e22bed888"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/181427","number":181427,"mergeCommit":{"message":"fix: [Rules > Add Elastic rules][SCREEN READER]: Rule non-modal flyout must announce itself on render and manage focus (#181427)\n\nCloses: https://github.com/elastic/security-team/issues/8657\r\n\r\n## Summary\r\n\r\nThe part about announcing the title was fixed in that PR:\r\nhttps://github.com//pull/180888. This PR removed the\r\nincorrect 'ownFocus = { false }' parameter for `EuiFlyout`. Since that\r\nflyout overlaps the table, we should not open it with that option.\r\n\r\n### Screen \r\n\r\n\r\n\r\n\r\n#### Eui documentation\r\nhttps://eui.elastic.co/#/layout/flyout#without-ownfocus","sha":"482766e0bfcf2a2297135a3084e0286e22bed888"}}]}] BACKPORT--> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
kpatticha
pushed a commit
to kpatticha/kibana
that referenced
this pull request
Apr 26, 2024
…t must announce itself on render and manage focus (elastic#181427) Closes: elastic/security-team#8657 ## Summary The part about announcing the title was fixed in that PR: elastic#180888. This PR removed the incorrect 'ownFocus = { false }' parameter for `EuiFlyout`. Since that flyout overlaps the table, we should not open it with that option. ### Screen  #### Eui documentation https://eui.elastic.co/#/layout/flyout#without-ownfocus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: https://github.com/elastic/security-team/issues/8657
Summary
This PR is a component of https://github.com/elastic/security-team/issues/8657 and addresses a part of the issue where the flyout must announce itself upon render. This issue was found to be valid for almost all flyouts in the Security Solution's code, and this PR rectifies these cases.
What was done?
Use aria-labelledby={headingId} to announce the flyout to screen readers.Screens:
a11ytreeBefore:
After: