Skip to content

Commit

Permalink
fix: [Rules > Add Elastic rules][SCREEN READER]: Rule non-modal flyou…
Browse files Browse the repository at this point in the history
…t must announce itself on render and manage focus (elastic#181427)

Closes: elastic/security-team#8657

## Summary

The part about announcing the title was fixed in that PR:
elastic#180888. This PR removed the
incorrect 'ownFocus = { false }' parameter for `EuiFlyout`. Since that
flyout overlaps the table, we should not open it with that option.

### Screen 


![image](https://github.com/elastic/kibana/assets/20072247/50883abb-7a76-4819-8df4-530c81d1a48c)

#### Eui documentation
https://eui.elastic.co/#/layout/flyout#without-ownfocus
  • Loading branch information
alexwizp authored Apr 25, 2024
1 parent 6ea7a35 commit 482766e
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -191,11 +191,11 @@ export const RuleDetailsFlyout = ({
id={id}
size={size}
onClose={closeFlyout}
ownFocus={false}
key="prebuilt-rules-flyout"
paddingSize="l"
data-test-subj={dataTestSubj}
aria-labelledby={prebuiltRulesFlyoutTitleId}
ownFocus
>
<EuiFlyoutHeader>
<EuiTitle size="m">
Expand Down

0 comments on commit 482766e

Please sign in to comment.