[Security Solution][Alert details] - fix timeline ES|QL flyout shown behind #182296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeOberti
added
release_note:skip
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
logeekal
reviewed
May 2, 2024
src/plugins/discover/public/components/discover_grid_flyout/discover_grid_flyout.tsx
Outdated
Show resolved
Hide resolved
…t shown behind" This reverts commit 7fb53ed8a3b0d88141bbf0092fa66ee015f3423e.
…behind within SecuritySolution
PhilippeOberti
force-pushed
the
discover-table-timeline-flyout
branch
from
7fb53ed to
a1cf66f
Compare
lukasolson
approved these changes
May 2, 2024
logeekal
approved these changes
May 2, 2024
michaelolo24
reviewed
May 2, 2024
|
|
||
| // TODO remember to remove the className added to discover/public/components/discover_grid_flyout/discover_grid_flyout.tsx when removing this | ||
| export const TimelineESQLGlobalStyles = createGlobalStyle` | ||
| body:has(.timeline-portal-overlay-mask) .DiscoverFlyout { |
There was a problem hiding this comment.
Thanks! I noticed it was .euiFlyout before and was wondering how that affected the other flyouts 😅 . Nice work, tested and works great!
michaelolo24
approved these changes
May 2, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
Saved Objects .kibana field count
History
To update your PR or re-run it, just comment with: |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
PhilippeOberti
added a commit
to PhilippeOberti/kibana
that referenced
this pull request
May 2, 2024
…behind (elastic#182296) (cherry picked from commit 2c6d13e) # Conflicts: # src/plugins/discover/public/components/discover_grid_flyout/discover_grid_flyout.tsx
PhilippeOberti
added a commit
that referenced
this pull request
May 2, 2024
… shown behind (#182296) (#182529) # Backport This will backport the following commits from `main` to `8.14`: - [[Security Solution][Alert details] - fix timeline ES|QL flyout shown behind (#182296)](#182296) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2024-05-02T21:51:52Z","message":"[Security Solution][Alert details] - fix timeline ES|QL flyout shown behind (#182296)","sha":"2c6d13e661db96988e51a355dbcbde5e6d04e1e1","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat Hunting:Investigations","v8.14.0","v8.15.0"],"number":182296,"url":"https://github.com/elastic/kibana/pull/182296","mergeCommit":{"message":"[Security Solution][Alert details] - fix timeline ES|QL flyout shown behind (#182296)","sha":"2c6d13e661db96988e51a355dbcbde5e6d04e1e1"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","labelRegex":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/182296","number":182296,"mergeCommit":{"message":"[Security Solution][Alert details] - fix timeline ES|QL flyout shown behind (#182296)","sha":"2c6d13e661db96988e51a355dbcbde5e6d04e1e1"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses an issue where the flyout for the unified data table used in the ES|QL tab of Timeline is shown behind timeline. This was most likely introduced when we merged this PR that introduced the expandable flyout to timeline, where we had to modify the
z-indexof timeline from1000to1001. Therefore all flyouts opened from timeline should have theirz-indexset to higher or equal to1002.The solution proposed in the PR is not ideal. I wish there was a way to use our own flyout (as we should be using the expandable flyout for UI consistency in Security Solution).Or at least I wish we could pass some properties down to the flyout to render it differently from how it is done in Discover at the moment (maybe there is a way but I'm not aware of it).The code was updated to have the logic directly within the SecuritySolution plugin instead of within Discover. Therefore there aren't any impact on the Discover app!
As
8.14is upon us, I felt like this was a simple, non-intrusive (hopefully) solution.Before fix (flyout is open but hidden behind timeline)
After fix
#180106