Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.14] [Security Solution][Alert details] - fix timeline ES|QL flyout shown behind (#182296) #182529

Merged

Conversation

PhilippeOberti
Copy link
Contributor

Backport

This will backport the following commits from main to 8.14:

Questions ?

Please refer to the Backport tool documentation

…behind (elastic#182296)

(cherry picked from commit 2c6d13e)

# Conflicts:
#	src/plugins/discover/public/components/discover_grid_flyout/discover_grid_flyout.tsx
@PhilippeOberti
Copy link
Contributor Author

I resolve the conflicts and manually created this backport.

To make sure everything was working as expected I pulled down 8.14 and applied the same fix locally. Here's a video that show the flyout is correctly rendered

Screen.Recording.2024-05-02.at.5.10.01.PM.mov

A very recent change is making main and 8.14 quite different on the component this PR touches.

@michaelolo24 michaelolo24 self-requested a review May 2, 2024 22:14
Copy link
Contributor

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 638.0KB 638.1KB +27.0B
securitySolution 13.6MB 13.6MB +135.0B
total +162.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@PhilippeOberti PhilippeOberti merged commit 4e22ab8 into elastic:8.14 May 2, 2024
38 checks passed
@PhilippeOberti PhilippeOberti deleted the backport/8.14/pr-182296 branch May 2, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants