Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data views] Fix single quotes on field save confirm toast #184789

Merged
merged 2 commits into from
Jun 5, 2024
Merged

[data views] Fix single quotes on field save confirm toast #184789

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1777b9
fix some single quote issues
mattkime Jun 5, 2024
f644c98
Update src/plugins/data_view_management/public/components/edit_index_…
mattkime Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/kbn-i18n/GUIDELINE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ Messages can contain placeholders for embedding a value of a variable. For examp

```js
{
'kbn.management.editIndexPattern.scripted.deleteFieldLabel': "Delete scripted field '{fieldName}'?"
'kbn.management.editIndexPattern.scripted.noFieldLabel': "'{indexPatternTitle}' index pattern doesn't have a scripted field called '{fieldName}'"
'kbn.management.editIndexPattern.scripted.deleteFieldLabel': "Delete scripted field ''{fieldName}''?"
'kbn.management.editIndexPattern.scripted.noFieldLabel': "''{indexPatternTitle}'' index pattern doesn't have a scripted field called ''{fieldName}''"
}
```

Expand Down
2 changes: 1 addition & 1 deletion src/plugins/data_view_field_editor/public/components/preview/preview_controller.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ export class PreviewController {

const afterSave = () => {
const message = i18n.translate('indexPatternFieldEditor.deleteField.savedHeader', {
defaultMessage: "Saved '{fieldName}'",
defaultMessage: "Saved ''{fieldName}''",
values: { fieldName: updatedField.name },
});
this.deps.notifications.toasts.addSuccess(message);
Expand Down
2 changes: 1 addition & 1 deletion ...w_management/public/components/edit_index_pattern/create_edit_field/create_edit_field.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export const CreateEditField = withRouter(
if (mode === 'edit' && !spec) {
const message = i18n.translate('indexPatternManagement.editDataView.scripted.noFieldLabel', {
defaultMessage:
"'{dataViewTitle}' data view doesn't have a scripted field called '{fieldName}'",
"'{dataViewTitle}' data view doesn't have a scripted field called ''{fieldName}''",
mattkime marked this conversation as resolved.
Show resolved Hide resolved
values: { dataViewTitle: indexPattern.title, fieldName },
});
notifications.toasts.addWarning(message);
Expand Down