Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Remove deprecated usage of `environment` (#202124) #202183

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

Closes elastic#200720

## Summary

This PR removes deprecated usage of `environment` property. The code
isn't used anymore, therefore can be removed safely.

https://github.com/elastic/kibana/blob/d0d33aab38009fe19cb18bacd3bf1943b5a8043f/src/plugins/home/public/plugin.ts#L202-L208
(cherry picked from commit 979f3e8)
@kibanamachine kibanamachine enabled auto-merge (squash) November 28, 2024 14:35
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Nov 28, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibanamachine kibanamachine merged commit 5d934a4 into elastic:8.x Nov 28, 2024
15 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 38.0KB 37.9KB -40.0B
Unknown metric groups

References to deprecated APIs

id before after diff
apm 33 32 -1

Unreferenced deprecated APIs

id before after diff
home 1 2 +1

cc @miloszmarcinkowski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants