Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Fix deprecated usage of environment #200720

Closed
jennypavlova opened this issue Nov 19, 2024 · 1 comment · Fixed by #202124
Closed

[APM] Fix deprecated usage of environment #200720

jennypavlova opened this issue Nov 19, 2024 · 1 comment · Fixed by #202124
Assignees
@miloszmarcinkowski
Labels
good first issue low hanging fruit Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team technical debt Improvement of the software architecture and operational architecture

Comments

@jennypavlova
Copy link
Member

Replace environment used in plugin.ts
@jennypavlova jennypavlova added Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team technical debt Improvement of the software architecture and operational architecture labels Nov 19, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@jennypavlova jennypavlova added the good first issue low hanging fruit label Nov 20, 2024
@miloszmarcinkowski miloszmarcinkowski self-assigned this Nov 27, 2024
@miloszmarcinkowski miloszmarcinkowski mentioned this issue Nov 28, 2024
Merged
miloszmarcinkowski added a commit that referenced this issue Nov 28, 2024
@miloszmarcinkowski
Remove deprecated usage of environment (#202124)
979f3e8 
Closes #200720

## Summary

This PR removes deprecated usage of `environment` property. The code
isn't used anymore, therefore can be removed safely.


https://github.com/elastic/kibana/blob/d0d33aab38009fe19cb18bacd3bf1943b5a8043f/src/plugins/home/public/plugin.ts#L202-L208
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 28, 2024
@miloszmarcinkowski
Remove deprecated usage of environment (elastic#202124)
fa7f524 
Closes elastic#200720

## Summary

This PR removes deprecated usage of `environment` property. The code
isn't used anymore, therefore can be removed safely.

https://github.com/elastic/kibana/blob/d0d33aab38009fe19cb18bacd3bf1943b5a8043f/src/plugins/home/public/plugin.ts#L202-L208
(cherry picked from commit 979f3e8)
kibanamachine added a commit that referenced this issue Nov 28, 2024
@kibanamachine @miloszmarcinkowski
[8.x] Remove deprecated usage of `environment` (#202124) (#…
5d934a4 
…202183)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Remove deprecated usage of `environment`
(#202124)](#202124)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Milosz
Marcinkowski","email":"38698566+miloszmarcinkowski@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-11-28T14:29:54Z","message":"Remove
deprecated usage of `environment` (#202124)\n\nCloses #200720\r\n\r\n##
Summary\r\n\r\nThis PR removes deprecated usage of `environment`
property. The code\r\nisn't used anymore, therefore can be removed
safely.\r\n\r\n\r\nhttps://github.com/elastic/kibana/blob/d0d33aab38009fe19cb18bacd3bf1943b5a8043f/src/plugins/home/public/plugin.ts#L202-L208","sha":"979f3e8ac492dd4cb7f77793ae54aa094edf99be","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services"],"title":"Remove
deprecated usage of
`environment`","number":202124,"url":"https://github.com/elastic/kibana/pull/202124","mergeCommit":{"message":"Remove
deprecated usage of `environment` (#202124)\n\nCloses #200720\r\n\r\n##
Summary\r\n\r\nThis PR removes deprecated usage of `environment`
property. The code\r\nisn't used anymore, therefore can be removed
safely.\r\n\r\n\r\nhttps://github.com/elastic/kibana/blob/d0d33aab38009fe19cb18bacd3bf1943b5a8043f/src/plugins/home/public/plugin.ts#L202-L208","sha":"979f3e8ac492dd4cb7f77793ae54aa094edf99be"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202124","number":202124,"mergeCommit":{"message":"Remove
deprecated usage of `environment` (#202124)\n\nCloses #200720\r\n\r\n##
Summary\r\n\r\nThis PR removes deprecated usage of `environment`
property. The code\r\nisn't used anymore, therefore can be removed
safely.\r\n\r\n\r\nhttps://github.com/elastic/kibana/blob/d0d33aab38009fe19cb18bacd3bf1943b5a8043f/src/plugins/home/public/plugin.ts#L202-L208","sha":"979f3e8ac492dd4cb7f77793ae54aa094edf99be"}}]}]
BACKPORT-->

Co-authored-by: Milosz Marcinkowski <38698566+miloszmarcinkowski@users.noreply.github.com>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
@miloszmarcinkowski @CAWilson94
Remove deprecated usage of environment (elastic#202124)
b7f985f 
Closes elastic#200720

## Summary

This PR removes deprecated usage of `environment` property. The code
isn't used anymore, therefore can be removed safely.


https://github.com/elastic/kibana/blob/d0d33aab38009fe19cb18bacd3bf1943b5a8043f/src/plugins/home/public/plugin.ts#L202-L208
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miloszmarcinkowski miloszmarcinkowski

Labels
good first issue low hanging fruit Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove deprecated usage of environment miloszmarcinkowski/kibana
3 participants
@jennypavlova @elasticmachine @miloszmarcinkowski