Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sustainable Kibana Architecture: Move modules owned by @elastic/security-detection-rule-management #202846

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

gsoldevila
Copy link
Contributor

@gsoldevila gsoldevila commented Dec 3, 2024

Summary

This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.

Important

  • We kindly ask you to:
    • Manually fix the errors in the error section below (if there are any).
    • Search for the packages[\/\\] and plugins[\/\\] patterns in the source code (Babel and Eslint config files), and update them appropriately.
    • Manually review .buildkite/scripts/pipelines/pull_request/pipeline.ts to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names
    • Review all of the updated files, specially the .ts and .js files listed in the sections below, as some of them contain relative paths that have been updated.
    • Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.:
      • customised eslint rules
      • docs pointing to source code

Note

This PR has been auto-generated.
Do not attempt to push any changes unless you know what you are doing.
Please use #sustainable_kibana_architecture Slack channel for feedback.

2 package(s) are going to be relocated:

Id Target folder
@kbn/openapi-common src/platform/packages/shared/kbn-openapi-common
@kbn/zod-helpers src/platform/packages/shared/kbn-zod-helpers
Updated references
./package.json
./packages/kbn-repo-packages/package-map.json
./packages/kbn-ts-projects/config-paths.json
./src/platform/packages/shared/kbn-zod-helpers/jest.config.js
./tsconfig.base.json
./yarn.lock
Updated relative paths
src/platform/packages/shared/kbn-openapi-common/scripts/openapi_generate.js:10
src/platform/packages/shared/kbn-openapi-common/tsconfig.json:7
src/platform/packages/shared/kbn-zod-helpers/jest.config.js:12
src/platform/packages/shared/kbn-zod-helpers/tsconfig.json:7
Script errors

@gsoldevila gsoldevila added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Detection Rule Management Security Detection Rule Management Team labels Dec 4, 2024
@gsoldevila gsoldevila marked this pull request as ready for review December 4, 2024 08:24
@gsoldevila gsoldevila requested a review from a team as a code owner December 4, 2024 08:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@nikitaindik nikitaindik requested review from banderror and removed request for nikitaindik December 5, 2024 13:12
@gsoldevila gsoldevila force-pushed the kbn-team-1309-move-kibana-security-detection-rule-management branch from 04d9fce to b4d1454 Compare December 5, 2024 15:35
@banderror
Copy link
Contributor

@gsoldevila Can we fix CI before opening the PR for review?

@banderror banderror marked this pull request as draft December 6, 2024 11:26
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 6, 2024

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

@gsoldevila gsoldevila force-pushed the kbn-team-1309-move-kibana-security-detection-rule-management branch from 915f2b2 to 1d39379 Compare December 6, 2024 13:27
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 7, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #8 / Agent policies fleet_agent_policies POST /api/fleet/agent_policies should create .fleet-policies document with inputs
  • [job] [logs] FTR Configs #8 / Agent policies fleet_agent_policies POST /api/fleet/agent_policies should create .fleet-policies document with inputs

Metrics [docs]

✅ unchanged

History

@marshallmain
Copy link
Contributor

This PR is going to have conflicts in the .schema.yaml files with #202844 - let's do the detection engine PR first then work on this one afterwards.

@banderror
Copy link
Contributor

@marshallmain I think both also conflict with #202851

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Detection Rule Management Security Detection Rule Management Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants