Sustainable Kibana Architecture: Move modules owned by `@elastic/security-solution` #202851

gsoldevila · 2024-12-04T00:21:46Z

Summary

This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.

Important

We kindly ask you to:
- Manually fix the errors in the error section below (if there are any).
- Search for the packages[\/\\] and plugins[\/\\] patterns in the source code (Babel and Eslint config files), and update them appropriately.
- Manually review .buildkite/scripts/pipelines/pull_request/pipeline.ts to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names
- Review all of the updated files, specially the .ts and .js files listed in the sections below, as some of them contain relative paths that have been updated.
- Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.:
  - customised eslint rules
  - docs pointing to source code

Note

This PR has been auto-generated.
Any manual contributions will be lost if the 'relocate' script is re-run.
Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash.
Please use #sustainable_kibana_architecture Slack channel for feedback.

3 plugin(s) are going to be relocated:

Id	Target folder
`@kbn/security-solution-ess`	`x-pack/solutions/security/plugins/security_solution_ess`
`@kbn/security-solution-plugin`	`x-pack/solutions/security/plugins/security_solution`
`@kbn/security-solution-serverless`	`x-pack/solutions/security/plugins/security_solution_serverless`

2 packages(s) are going to be relocated:

Id	Target folder
`@kbn/deeplinks-security`	`src/platform/packages/shared/deeplinks/security`
`@kbn/serverless-security-settings`	`src/platform/packages/shared/serverless/settings/security_project`

Script errors

Cannot replace multiple occurrences of "../../.." in the same line, please fix manually:	/Users/stephmilovic/dev/kibana/x-pack/solutions/security/plugins/security_solution/package.json:25
Cannot replace multiple occurrences of "../../.." in the same line, please fix manually:	/Users/stephmilovic/dev/kibana/x-pack/solutions/security/plugins/security_solution/package.json:25
Cannot replace multiple occurrences of "../../.." in the same line, please fix manually:	/Users/stephmilovic/dev/kibana/x-pack/solutions/security/plugins/security_solution/package.json:25
Cannot replace multiple occurrences of "../../.." in the same line, please fix manually:	/Users/stephmilovic/dev/kibana/x-pack/solutions/security/plugins/security_solution/package.json:25
Cannot replace multiple occurrences of "../../.." in the same line, please fix manually:	/Users/stephmilovic/dev/kibana/x-pack/solutions/security/plugins/security_solution/package.json:25
Cannot replace multiple occurrences of "../../.." in the same line, please fix manually:	/Users/stephmilovic/dev/kibana/x-pack/solutions/security/plugins/security_solution/package.json:25
Cannot replace multiple occurrences of "../../.." in the same line, please fix manually:	/Users/stephmilovic/dev/kibana/x-pack/solutions/security/plugins/security_solution/package.json:25
Cannot replace multiple occurrences of "../../.." in the same line, please fix manually:	/Users/stephmilovic/dev/kibana/x-pack/solutions/security/plugins/security_solution/package.json:25
Cannot replace multiple occurrences of "../../.." in the same line, please fix manually:	/Users/stephmilovic/dev/kibana/x-pack/solutions/security/plugins/security_solution/package.json:31

Updated references

./.buildkite/scripts/packer_cache.sh
./.buildkite/scripts/pipelines/security_solution_quality_gate/edr_workflows/mki_security_solution_defend_workflows.sh
./.buildkite/scripts/steps/code_generation/security_solution_codegen.sh
./.buildkite/scripts/steps/functional/defend_workflows.sh
./.buildkite/scripts/steps/functional/defend_workflows_burn.sh
./.buildkite/scripts/steps/functional/defend_workflows_serverless.sh
./.buildkite/scripts/steps/functional/defend_workflows_serverless_burn.sh
./.buildkite/scripts/steps/openapi_bundling/security_solution_openapi_bundling.sh
./.eslintrc.js
./.github/codeql/codeql-config.yml
./.gitignore
./docs/developer/plugin-list.asciidoc
./oas_docs/scripts/merge_ess_oas.js
./oas_docs/scripts/merge_serverless_oas.js
./package.json
./packages/kbn-dependency-usage/README.md
./packages/kbn-dependency-usage/src/dependency_graph/providers/cruiser.test.ts
./packages/kbn-openapi-generator/README.md
./packages/kbn-repo-packages/package-map.json
./packages/kbn-securitysolution-io-ts-types/src/version/index.ts
./packages/kbn-ts-projects/config-paths.json
./packages/kbn-zod-helpers/README.md
./src/dev/code_coverage/docs/team_assignment/README.md
./src/dev/precommit_hook/casing_check_config.js
./src/dev/storybook/aliases.ts
./src/platform/packages/shared/deeplinks/security/jest.config.js
./src/plugins/data/server/search/search_service.ts
./src/plugins/guided_onboarding/README.md
./tsconfig.base.json
./x-pack/.i18nrc.json
./x-pack/README.md
./x-pack/packages/kbn-elastic-assistant-common/README.md
./x-pack/packages/kbn-elastic-assistant/impl/assistant/prompt_context/types.ts
./x-pack/packages/kbn-elastic-assistant/index.ts
./x-pack/platform/plugins/shared/osquery/package.json
./x-pack/plugins/cloud_defend/public/common/navigation/types.ts
./x-pack/plugins/cloud_security_posture/public/common/navigation/types.ts
./x-pack/plugins/elastic_assistant/server/routes/user_conversations/find_route.ts
./x-pack/plugins/fleet/dev_docs/fleet_ui_extensions.md
./x-pack/plugins/fleet/server/services/epm/archive/parse.ts
./x-pack/plugins/fleet/server/telemetry/sender.ts
./x-pack/plugins/lists/server/routes/utils/build_siem_response.ts
./x-pack/plugins/lists/server/routes/utils/route_validation.test.ts
./x-pack/plugins/lists/server/routes/utils/route_validation.ts
./x-pack/plugins/rule_registry/common/schemas/README.md
./x-pack/plugins/rule_registry/server/routes/utils/route_validation.ts
./x-pack/solutions/observability/plugins/synthetics/server/telemetry/sender.ts
./x-pack/solutions/security/packages/data_table/README.md
./x-pack/solutions/security/packages/expandable-flyout/README.md
./x-pack/solutions/security/packages/features/src/security/types.ts
./x-pack/solutions/security/packages/navigation/src/constants.ts
./x-pack/solutions/security/plugins/security_solution/common/api/detection_engine/model/alerts/README.md
./x-pack/solutions/security/plugins/security_solution/common/api/detection_engine/prebuilt_rules/model/diff/three_way_diff/three_way_diff_conflict.ts
./x-pack/solutions/security/plugins/security_solution/common/api/endpoint/README.md
./x-pack/solutions/security/plugins/security_solution/common/api/endpoint/actions/response_actions/kill_process/kill_process.ts
./x-pack/solutions/security/plugins/security_solution/common/endpoint/service/response_actions/constants.ts
./x-pack/solutions/security/plugins/security_solution/common/endpoint/utils/kibana_status.ts
./x-pack/solutions/security/plugins/security_solution/common/jest.config.js
./x-pack/solutions/security/plugins/security_solution/docs/adrs/threat_hunting/0001_saving_of_timeline_associated_saved_objects.md
./x-pack/solutions/security/plugins/security_solution/docs/openapi/README.md
./x-pack/solutions/security/plugins/security_solution/docs/rfcs/detection_response/prebuilt_rules_customization.md
./x-pack/solutions/security/plugins/security_solution/jest.config.dev.js
./x-pack/solutions/security/plugins/security_solution/jest.integration.config.js
./x-pack/solutions/security/plugins/security_solution/public/app/jest.config.js
./x-pack/solutions/security/plugins/security_solution/public/assistant/jest.config.js
./x-pack/solutions/security/plugins/security_solution/public/attack_discovery/jest.config.js
./x-pack/solutions/security/plugins/security_solution/public/cases/jest.config.js
./x-pack/solutions/security/plugins/security_solution/public/cloud_security_posture/jest.config.js
./x-pack/solutions/security/plugins/security_solution/public/common/components/toasters/utils.ts
./x-pack/solutions/security/plugins/security_solution/public/common/components/with_security_context/store.ts
./x-pack/solutions/security/plugins/security_solution/public/common/hooks/use_app_toasts.ts
./x-pack/solutions/security/plugins/security_solution/public/common/jest.config.js
./x-pack/solutions/security/plugins/security_solution/public/dashboards/jest.config.js
./x-pack/solutions/security/plugins/security_solution/public/detection_engine/jest.config.js
./x-pack/solutions/security/plugins/security_solution/public/detections/jest.config.js
./x-pack/solutions/security/plugins/security_solution/public/entity_analytics/jest.config.js
./x-pack/solutions/security/plugins/security_solution/public/exceptions/jest.config.js
./x-pack/solutions/security/plugins/security_solution/public/explore/jest.config.js
./x-pack/solutions/security/plugins/security_solution/public/flyout/README.md
./x-pack/solutions/security/plugins/security_solution/public/flyout/document_details/right/hooks/use_fetch_threat_intelligence.ts
./x-pack/solutions/security/plugins/security_solution/public/flyout/document_details/shared/mocks/mock_get_fields_data.ts
./x-pack/solutions/security/plugins/security_solution/public/flyout/jest.config.js
./x-pack/solutions/security/plugins/security_solution/public/jest.config.js
./x-pack/solutions/security/plugins/security_solution/public/management/cypress/README.md
./x-pack/solutions/security/plugins/security_solution/public/management/jest.config.js
./x-pack/solutions/security/plugins/security_solution/public/notes/api/api.ts
./x-pack/solutions/security/plugins/security_solution/public/notes/jest.config.js
./x-pack/solutions/security/plugins/security_solution/public/onboarding/jest.config.js
./x-pack/solutions/security/plugins/security_solution/public/one_discover/jest.config.js
./x-pack/solutions/security/plugins/security_solution/public/overview/jest.config.js
./x-pack/solutions/security/plugins/security_solution/public/resolver/documentation/schema.md
./x-pack/solutions/security/plugins/security_solution/public/resolver/jest.config.js
./x-pack/solutions/security/plugins/security_solution/public/security_integrations/jest.config.js
./x-pack/solutions/security/plugins/security_solution/public/siem_migrations/jest.config.js
./x-pack/solutions/security/plugins/security_solution/public/sourcerer/jest.config.js
./x-pack/solutions/security/plugins/security_solution/public/threat_intelligence/use_investigate_in_timeline.ts
./x-pack/solutions/security/plugins/security_solution/public/timelines/jest.config.js
./x-pack/solutions/security/plugins/security_solution/scripts/endpoint/README.md
./x-pack/solutions/security/plugins/security_solution/scripts/endpoint/api_emulator/README.md
./x-pack/solutions/security/plugins/security_solution/scripts/endpoint/common/roles_users/serverless/es_serverless_resources/README.md
./x-pack/solutions/security/plugins/security_solution/scripts/endpoint/common/vm_services.ts
./x-pack/solutions/security/plugins/security_solution/scripts/jest.config.js
./x-pack/solutions/security/plugins/security_solution/scripts/mappings/README.md
./x-pack/solutions/security/plugins/security_solution/scripts/openapi/generate.js
./x-pack/solutions/security/plugins/security_solution/scripts/quickstart/README.md
./x-pack/solutions/security/plugins/security_solution/scripts/run_cypress/utils.ts
./x-pack/solutions/security/plugins/security_solution/scripts/telemetry/README.md
./x-pack/solutions/security/plugins/security_solution/server/__mocks__/module_name_map.js
./x-pack/solutions/security/plugins/security_solution/server/assistant/jest.config.js
./x-pack/solutions/security/plugins/security_solution/server/client/jest.config.js
./x-pack/solutions/security/plugins/security_solution/server/config.ts
./x-pack/solutions/security/plugins/security_solution/server/endpoint/jest.config.js
./x-pack/solutions/security/plugins/security_solution/server/endpoint/services/agent/clients/endpoint/endpoint_agent_status_client.test.ts
./x-pack/solutions/security/plugins/security_solution/server/endpoint/services/metadata/mocks.ts
./x-pack/solutions/security/plugins/security_solution/server/fleet_integration/jest.config.js
./x-pack/solutions/security/plugins/security_solution/server/integration_tests/telemetry.test.ts
./x-pack/solutions/security/plugins/security_solution/server/jest.config.js
./x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/README.md
./x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/prebuilt_rules/content/prepackaged_timelines/README.md
./x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/rule_monitoring/logic/detection_engine_health/README.md
./x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/rule_types/new_terms/bulk_create_suppressed_alerts_in_memory.ts
./x-pack/solutions/security/plugins/security_solution/server/lib/entity_analytics/risk_score/painless/index.test.ts
./x-pack/solutions/security/plugins/security_solution/server/lib/jest.config.js
./x-pack/solutions/security/plugins/security_solution/server/lib/risk_score/readme.md
./x-pack/solutions/security/plugins/security_solution/server/lib/telemetry/artifact.test.ts
./x-pack/solutions/security/plugins/security_solution/server/lib/timeline/routes/notes/get_notes.ts
./x-pack/solutions/security/plugins/security_solution/server/lists_integration/jest.config.js
./x-pack/solutions/security/plugins/security_solution/server/search_strategy/jest.config.js
./x-pack/solutions/security/plugins/security_solution/server/usage/jest.config.js
./x-pack/solutions/security/plugins/security_solution/server/utils/jest.config.js
./x-pack/solutions/security/plugins/security_solution_ess/jest.config.dev.js
./x-pack/solutions/security/plugins/security_solution_ess/public/jest.config.js
./x-pack/solutions/security/plugins/security_solution_serverless/common/config.ts
./x-pack/solutions/security/plugins/security_solution_serverless/common/jest.config.js
./x-pack/solutions/security/plugins/security_solution_serverless/jest.config.dev.js
./x-pack/solutions/security/plugins/security_solution_serverless/public/jest.config.js
./x-pack/solutions/security/plugins/security_solution_serverless/server/config.ts
./x-pack/solutions/security/plugins/security_solution_serverless/server/jest.config.js
./x-pack/solutions/security/plugins/threat_intelligence/README.md
./x-pack/solutions/security/plugins/threat_intelligence/common/types/indicator.ts
./x-pack/solutions/security/plugins/threat_intelligence/public/modules/timeline/hooks/use_add_to_timeline.ts
./x-pack/solutions/security/plugins/threat_intelligence/public/modules/timeline/hooks/use_investigate_in_timeline.ts
./x-pack/solutions/security/plugins/threat_intelligence/public/types.ts
./x-pack/solutions/security/plugins/threat_intelligence/public/utils/security_solution_links.ts
./x-pack/solutions/security/plugins/timelines/common/types/timeline/cells/index.ts
./x-pack/solutions/security/plugins/timelines/common/types/timeline/rows/index.ts
./x-pack/solutions/security/plugins/timelines/public/hooks/use_app_toasts.ts
./x-pack/test/security_solution_api_integration/test_suites/detections_response/detection_engine/rule_execution_logic/eql/trial_license_complete_tier/eql_alert_suppression.ts
./x-pack/test/security_solution_cypress/cypress/tsconfig.json
./x-pack/test/security_solution_cypress/package.json
./x-pack/test/security_solution_endpoint/page_objects/policy_page.ts
./x-pack/test/security_solution_playwright/package.json
./x-pack/test/security_solution_playwright/tsconfig.json
./yarn.lock

Updated relative paths

src/platform/packages/shared/deeplinks/security/jest.config.js:12
src/platform/packages/shared/deeplinks/security/tsconfig.json:2
src/platform/packages/shared/serverless/settings/security_project/tsconfig.json:2
x-pack/solutions/security/plugins/security_solution/README.md:100
x-pack/solutions/security/plugins/security_solution/README.md:22
x-pack/solutions/security/plugins/security_solution/README.md:26
x-pack/solutions/security/plugins/security_solution/README.md:31
x-pack/solutions/security/plugins/security_solution/common/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/docs/openapi/README.md:3
x-pack/solutions/security/plugins/security_solution/docs/openapi/README.md:7
x-pack/solutions/security/plugins/security_solution/jest.config.dev.js:10
x-pack/solutions/security/plugins/security_solution/jest.integration.config.js:10
x-pack/solutions/security/plugins/security_solution/package.json:10
x-pack/solutions/security/plugins/security_solution/package.json:13
x-pack/solutions/security/plugins/security_solution/package.json:16
x-pack/solutions/security/plugins/security_solution/package.json:25
x-pack/solutions/security/plugins/security_solution/package.json:31
x-pack/solutions/security/plugins/security_solution/package.json:8
x-pack/solutions/security/plugins/security_solution/package.json:9
x-pack/solutions/security/plugins/security_solution/public/app/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/public/assistant/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/public/attack_discovery/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/public/cases/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/public/cloud_security_posture/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/public/common/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/public/dashboards/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/public/detection_engine/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/public/detections/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/public/entity_analytics/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/public/exceptions/hooks/use_import_exception_list/index.tsx:25
x-pack/solutions/security/plugins/security_solution/public/exceptions/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/public/explore/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/public/flyout/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/public/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/public/management/cypress/cypress_base.config.ts:27
x-pack/solutions/security/plugins/security_solution/public/management/cypress/tsconfig.json:2
x-pack/solutions/security/plugins/security_solution/public/management/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/public/management/reporter_config.json:12
x-pack/solutions/security/plugins/security_solution/public/management/reporter_config.json:14
x-pack/solutions/security/plugins/security_solution/public/notes/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/public/onboarding/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/public/one_discover/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/public/overview/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/public/resolver/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/public/security_integrations/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/public/siem_migrations/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/public/sourcerer/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/public/timelines/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/scripts/beat_docs/build.js:8
x-pack/solutions/security/plugins/security_solution/scripts/endpoint/agent_downloader.js:8
x-pack/solutions/security/plugins/security_solution/scripts/endpoint/endpoint_agent_emulator.js:8
x-pack/solutions/security/plugins/security_solution/scripts/endpoint/load_agent_policies.js:10
x-pack/solutions/security/plugins/security_solution/scripts/endpoint/load_blocklists.js:10
x-pack/solutions/security/plugins/security_solution/scripts/endpoint/load_endpoint_policies.js:8
x-pack/solutions/security/plugins/security_solution/scripts/endpoint/load_env_data.js:8
x-pack/solutions/security/plugins/security_solution/scripts/endpoint/load_event_filters.js:10
x-pack/solutions/security/plugins/security_solution/scripts/endpoint/load_host_isolation_exceptions.js:10
x-pack/solutions/security/plugins/security_solution/scripts/endpoint/load_trusted_apps.js:10
x-pack/solutions/security/plugins/security_solution/scripts/endpoint/resolver_generator.js:8
x-pack/solutions/security/plugins/security_solution/scripts/endpoint/run_endpoint_agent.js:8
x-pack/solutions/security/plugins/security_solution/scripts/endpoint/run_sentinelone_host.js:8
x-pack/solutions/security/plugins/security_solution/scripts/endpoint/start_es_serverless_with_security_users.js:8
x-pack/solutions/security/plugins/security_solution/scripts/endpoint/start_external_edr_server_emulator.js:8
x-pack/solutions/security/plugins/security_solution/scripts/endpoint/start_fleet_server.js:8
x-pack/solutions/security/plugins/security_solution/scripts/extract_tactics_techniques_mitre.js:8
x-pack/solutions/security/plugins/security_solution/scripts/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/scripts/junit_transformer/index.js:8
x-pack/solutions/security/plugins/security_solution/scripts/mappings/mappings_generator.js:8
x-pack/solutions/security/plugins/security_solution/scripts/mappings/mappings_loader.js:8
x-pack/solutions/security/plugins/security_solution/scripts/mappings/mappings_loader_script.ts:20
x-pack/solutions/security/plugins/security_solution/scripts/mappings/mappings_loader_script.ts:21
x-pack/solutions/security/plugins/security_solution/scripts/openapi/bundle_detections.js:8
x-pack/solutions/security/plugins/security_solution/scripts/openapi/bundle_endpoint_management.js:8
x-pack/solutions/security/plugins/security_solution/scripts/openapi/bundle_entity_analytics.js:8
x-pack/solutions/security/plugins/security_solution/scripts/openapi/bundle_timeline.js:8
x-pack/solutions/security/plugins/security_solution/scripts/openapi/generate.js:8
x-pack/solutions/security/plugins/security_solution/scripts/quickstart/run.js:8
x-pack/solutions/security/plugins/security_solution/scripts/run_playwright/playwright.ts:327
x-pack/solutions/security/plugins/security_solution/scripts/run_playwright/playwright.ts:337
x-pack/solutions/security/plugins/security_solution/scripts/run_playwright/start_playwright.js:8
x-pack/solutions/security/plugins/security_solution/scripts/siem_migration/draw_graphs.js:8
x-pack/solutions/security/plugins/security_solution/scripts/start_cypress_parallel.js:8
x-pack/solutions/security/plugins/security_solution/scripts/start_cypress_parallel_serverless.js:8
x-pack/solutions/security/plugins/security_solution/server/assistant/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/server/client/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/server/endpoint/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/server/fleet_integration/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/server/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/routes/__mocks__/request_context.ts:18
x-pack/solutions/security/plugins/security_solution/server/lib/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/server/lists_integration/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/server/search_strategy/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/server/usage/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/server/utils/jest.config.js:10
x-pack/solutions/security/plugins/security_solution/tsconfig.json:16
x-pack/solutions/security/plugins/security_solution/tsconfig.json:2
x-pack/solutions/security/plugins/security_solution/tsconfig.json:26
x-pack/solutions/security/plugins/security_solution_ess/README.md:76
x-pack/solutions/security/plugins/security_solution_ess/jest.config.dev.js:10
x-pack/solutions/security/plugins/security_solution_ess/package.json:8
x-pack/solutions/security/plugins/security_solution_ess/package.json:9
x-pack/solutions/security/plugins/security_solution_ess/public/jest.config.js:9
x-pack/solutions/security/plugins/security_solution_ess/tsconfig.json:12
x-pack/solutions/security/plugins/security_solution_ess/tsconfig.json:2
x-pack/solutions/security/plugins/security_solution_serverless/README.md:78
x-pack/solutions/security/plugins/security_solution_serverless/common/jest.config.js:10
x-pack/solutions/security/plugins/security_solution_serverless/jest.config.dev.js:10
x-pack/solutions/security/plugins/security_solution_serverless/package.json:8
x-pack/solutions/security/plugins/security_solution_serverless/package.json:9
x-pack/solutions/security/plugins/security_solution_serverless/public/jest.config.js:10
x-pack/solutions/security/plugins/security_solution_serverless/server/jest.config.js:11
x-pack/solutions/security/plugins/security_solution_serverless/tsconfig.json:12
x-pack/solutions/security/plugins/security_solution_serverless/tsconfig.json:2

github-actions · 2024-12-04T00:22:00Z

A documentation preview will be available soon.

🔨 Buildkite builds
📚 HTML diff
📙 Preview page

Request a new doc build by commenting

Rebuild this PR: run docs-build
Rebuild this PR and all Elastic docs: run docs-build rebuild

_{run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.}

_{If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.}

elasticmachine · 2024-12-04T08:22:55Z

Pinging @elastic/kibana-core (Team:Core)

elasticmachine · 2024-12-04T08:22:56Z

Pinging @elastic/security-solution (Team: SecuritySolution)

stephmilovic

Finally got a successful build, almost there! LGTM

banderror

Security Detection Rule Management changes LGTM 👍

The folder structure looks good
The app runs locally without issues, the features we own work
The API integration tests we own run locally
The OpenAPI code generation works locally and is properly integrated with CI
The OpenAPI specs bundling works locally and is properly integrated with CI

Should be good to merge and fix leftover issues separately:

Sustainable Kibana Architecture: Move modules owned by @elastic/security-solution #202851 (comment)
Paths in the CODEOWNERS file

kapral18

LGTM

nchaulet

Fleet changes 🚀

…-fix'

tomsonpl · 2024-12-13T14:59:56Z

I’ve noticed that some Defend Workflows tests are failing quietly, which might be because most of them were skipped yesterday. I’m working on a PR to revert that change. It seems like getting the tests PR merged first would help clarify the Cypress issues with Defend Workflows in this PR.
Sorry for the trouble!

Also there are issues with reporters in Cypress tests - probably just wrong paths to them in cypress config files. .

…ipeline.ts

…-fix'

elasticmachine · 2024-12-13T18:02:52Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 17be4f0
Storybooks Preview
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-202851-17be4f00d6b9

Failed CI Steps

FTR Configs #97

Test Failures

[job] [logs] FTR Configs #97 / serverless observability UI Dataset Quality Dataset quality details navigate to dataset details should navigate to details page from a main page

Metrics [docs]

✅ unchanged

History

💛 Build #260168 was flaky 9e88c52
💛 Build #260144 was flaky 5b9a02a
💔 Build #260084 failed 2ffd907
💔 Build #260061 failed 4c618df
💔 Build #260029 failed b97771b

PhilippeOberti

LGTM for the Threat Hunting Investigations team.

Code change looks good and I desk tested the following:

timeline, alerts and intelligence pages
interaction with the Cases plugin
expandable flyout
notes

Looking at Buildkite, all the Jest and Cypress tests seem to all be running.

I noticed a issue related to Storybook where the Threat Intelligence plugin seems to be bundled under yarn storybook security_solution_packages but that can be fixed in a follow up PR!

gsoldevila marked this pull request as ready for review December 4, 2024 08:22

gsoldevila requested review from a team as code owners December 4, 2024 08:22

stephmilovic approved these changes Dec 13, 2024

View reviewed changes

mattkime approved these changes Dec 13, 2024

View reviewed changes

stephmilovic force-pushed the kbn-team-1309-move-kibana-security-solution branch from 5b9a02a to 5152866 Compare December 13, 2024 02:55

banderror approved these changes Dec 13, 2024

View reviewed changes

banderror mentioned this pull request Dec 13, 2024

Sustainable Kibana Architecture: Move modules owned by @elastic/security-detection-rule-management #202846

Draft

kapral18 approved these changes Dec 13, 2024

View reviewed changes

stephmilovic added 5 commits December 13, 2024 06:55

Relocating module @kbn/deeplinks-security

7535ccf

Relocating module @kbn/security-solution-ess

9fd0825

Relocating module @kbn/security-solution-plugin

6d46687

Relocating module @kbn/security-solution-serverless

ce00667

Relocating module @kbn/serverless-security-settings

c5c64be

stephmilovic force-pushed the kbn-team-1309-move-kibana-security-solution branch from 9e88c52 to c5c64be Compare December 13, 2024 14:02

manual changes

e1d1455

kdelemme approved these changes Dec 13, 2024

View reviewed changes

nchaulet approved these changes Dec 13, 2024

View reviewed changes

[CI] Auto-commit changed files from 'node scripts/telemetry_check'

72a4340

patrykkopycinski approved these changes Dec 13, 2024

View reviewed changes

seanrathier approved these changes Dec 13, 2024

View reviewed changes

james-elastic approved these changes Dec 13, 2024

View reviewed changes

machadoum approved these changes Dec 13, 2024

View reviewed changes

dokmic approved these changes Dec 13, 2024

View reviewed changes

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

92b99e5

…-fix'

fix updated file paths in .buildkite/scripts/pipelines/pull_request/p…

e4ab7f5

…ipeline.ts

delanni approved these changes Dec 13, 2024

View reviewed changes

marshallmain and others added 3 commits December 13, 2024 11:07

Fix cypress report target path

0abca6d

fix minor outdated security_solution paths in comments

f300aa0

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

17be4f0

…-fix'

PhilippeOberti approved these changes Dec 13, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sustainable Kibana Architecture: Move modules owned by `@elastic/security-solution` #202851

Sustainable Kibana Architecture: Move modules owned by `@elastic/security-solution` #202851

gsoldevila commented Dec 4, 2024 •

edited by stephmilovic

Loading

github-actions bot commented Dec 4, 2024

elasticmachine commented Dec 4, 2024

elasticmachine commented Dec 4, 2024

stephmilovic left a comment

banderror left a comment •

edited

Loading

kapral18 left a comment

nchaulet left a comment •

edited

Loading

tomsonpl commented Dec 13, 2024 •

edited

Loading

elasticmachine commented Dec 13, 2024 •

edited

Loading

PhilippeOberti left a comment

Sustainable Kibana Architecture: Move modules owned by @elastic/security-solution #202851

Are you sure you want to change the base?

Sustainable Kibana Architecture: Move modules owned by @elastic/security-solution #202851

Conversation

gsoldevila commented Dec 4, 2024 • edited by stephmilovic Loading

Summary

3 plugin(s) are going to be relocated:

2 packages(s) are going to be relocated:

github-actions bot commented Dec 4, 2024

elasticmachine commented Dec 4, 2024

elasticmachine commented Dec 4, 2024

stephmilovic left a comment

Choose a reason for hiding this comment

banderror left a comment • edited Loading

Choose a reason for hiding this comment

kapral18 left a comment

Choose a reason for hiding this comment

nchaulet left a comment • edited Loading

Choose a reason for hiding this comment

tomsonpl commented Dec 13, 2024 • edited Loading

elasticmachine commented Dec 13, 2024 • edited Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

History

PhilippeOberti left a comment

Choose a reason for hiding this comment

Sustainable Kibana Architecture: Move modules owned by `@elastic/security-solution` #202851

Sustainable Kibana Architecture: Move modules owned by `@elastic/security-solution` #202851

gsoldevila commented Dec 4, 2024 •

edited by stephmilovic

Loading

banderror left a comment •

edited

Loading

nchaulet left a comment •

edited

Loading

tomsonpl commented Dec 13, 2024 •

edited

Loading

elasticmachine commented Dec 13, 2024 •

edited

Loading