Cut down on all tests except for secops tests and one example of infr… #24693

FrankHassanabad · 2018-10-26T22:38:39Z

Commented out code for only this branch
Added comments and "please see issue number"
https://github.com/elastic/ingest-dev/issues/60

…a integration tests * Commented out code for only this branch * Added comments and "please see issue number" * https://github.com/elastic/ingest-dev/issues/60

x-pack/scripts/functional_tests.js

-  require.resolve('../test/reporting/configs/phantom_api.js'),
-  require.resolve('../test/reporting/configs/phantom_functional.js'),
-  require.resolve('../test/functional/config.js'),
+//  require.resolve('../test/reporting/configs/chromium_api.js'),


x-pack/test/api_integration/apis/index.js

-    loadTestFile(require.resolve('./xpack_main'));
-    loadTestFile(require.resolve('./logstash'));
-    loadTestFile(require.resolve('./kibana'));
+    // loadTestFile(require.resolve('./es'));


andrew-goldstein · 2018-10-26T22:56:36Z

x-pack/test/api_integration/apis/index.js

+    // loadTestFile(require.resolve('./kibana'));
+    // loadTestFile(require.resolve('./infra'));
+
+    // TODO: I am only running infra at the moment


makes sense, and this comment will go away soon

andrew-goldstein

Focusing the tests in this branch makes sense, and as noted throughout the the changes, this will not be merged back into master.

elasticmachine · 2018-10-26T23:33:43Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

FrankHassanabad · 2018-10-26T23:36:09Z

Checked that secops jest tests are still being executed:

Checked that for now infra api integration tests are still running on a PR until we copy and switch those for our own integration tests:

Our build times for PR's are down to 30 minutes again and all are green:

elastic#24693) * Cut down on all tests except for secops tests and one example of infra integration tests * Commented out code for only this branch * Added comments and "please see issue number" * https://github.com/elastic/ingest-dev/issues/60

* Translate global navigation bar component (#23993) Translate global navigation bar component * [backport] add back earlier 6.x minor versions We still backport to these branches, primarily for doc changes. * [dev/build] fix invalid assertion * Skip this test until snapshots are updated (#24650) * Feat/expression threading (#24598) Replaces #23301 Closes #23080 --- This is a minimal threading implementation for Canvas. There's still a lot to be done to make this concept great, but this is a start. What it does: - Creates a server side abstraction on top of the interpreter - Determines where to send the expression by checking the first function to be run - Loads common functions in a separate worker thread on the server. - Routes to a single forked worker (thread), the main thread (server), or the browser (browser), in that order - Defers back to the router when a function isn't found. Fails if the function isn't found in any of the above 3 environments - Times out the worker if it takes too long, and respawns it as needed. - Simplifies the error dialog to remove the stack. What is does not.: - Round robin a pool of workers - Queue. If one expression in the threaded env fails then anything sent to it in the meantime will fail. The upstream environment handles managing timeouts. I think this would only make sense todo with a pool. - Client side. This doesn't implement web workers, but we could use roughly the same architecture. - Implement a specific, pluggable `worker` environment on the server. Right now it's just common functions, so plugin authors will always end up in a thread if they put their function in the common directory. What I don't like: - The socketProvider code. This was reused across the server & browser, but now that it's only used in the browser there's no good reason for the abstraction - The serialize/deserialize stuff feels messy. Do we really need serialization? * Polish 6.5 (#24556) * Updates waterfall item design for timeline rows * Adjusts span and tx flyouts and updates tooltips to EUI * Heading size fixes and clean up * Updates tooltip snapshots * Review tweaks and snapshot updates * Revert experiment :) Co-Authored-By: jasonrhodes <jason.matthew.rhodes@gmail.com> * Fixes bug with v1 waterfall state * Fixes bug with timeline bar height * Updates snapshot tests * Updated test so it doesn't mount and rely on EUI makeId() which is non-deterministic per test run * Don't throw errors in optimizer (#24660) * Fixed label position on progress elements (#24623) * [kbn/es] add context to error message (#24664) This just tweaks the kbn-es error message to provide more context than just `Not Found` * [BeatsCM] Beats without tags should return an empty array via the config API (#24665) * [ML] Change file data visualizer JSON format label to NDJSON (#24643) * [ML] Change file datavisualizer JSON format label to NDJSON * [ML] Update edit flyout overrides snapshot * Translations for Coordinate Map (#23952) translate Coordinate Map * Translations for Region Map (#23875) add translations for region_map plugin * [Tools] Add TemplateLiteral parsing to i18n_check tool (#24580) * [Tools] Add TemplateLiteral parsing to i18n_check tool * Add comments * [ML] Remove obsolete sentence from info tooltip. (#24716) * Translate security/users component (#23940) Translate security/users * [Docs] Remove beta notes for ML and Query bar (#24718) * Translations for Table Vis plugin (#23679) add translations for table vis plugin * Feature/translate new nav bar (#24326) translate new_nav_bar * center content in fullscreen mode, hide K7 top nav (#24589) * [APM] Fixes rare cases where KibanaLink is loaded outside of React context (#24705) * Fixes rare cases where KibanaLink will be loaded outside of React context and requires no redux connect dependency * Fixes tests for updated Kibana link component * Removes obsolete snapshot * Secops structure code (#24652) * add basic structure for secops application * finalize skeleton for secops * fix type issue and hapi new version * remove route home, not needed for now * Add configuration + delete noise * prepend elastic license to generated file * Cut down on all tests except for secops tests and one example of infr… (#24693) * Cut down on all tests except for secops tests and one example of infra integration tests * Commented out code for only this branch * Added comments and "please see issue number" * https://github.com/elastic/ingest-dev/issues/60

#24693) * Cut down on all tests except for secops tests and one example of infra integration tests * Commented out code for only this branch * Added comments and "please see issue number" * https://github.com/elastic/ingest-dev/issues/60

Cut down on all tests except for secops tests and one example of infr…

07dfc7b

…a integration tests * Commented out code for only this branch * Added comments and "please see issue number" * https://github.com/elastic/ingest-dev/issues/60

FrankHassanabad requested review from andrew-goldstein and XavierM October 26, 2018 22:50

andrew-goldstein reviewed Oct 26, 2018

View reviewed changes

x-pack/test/api_integration/apis/index.js

loadTestFile(require.resolve('./xpack_main'));

loadTestFile(require.resolve('./logstash'));

loadTestFile(require.resolve('./kibana'));

// loadTestFile(require.resolve('./es'));

This comment was marked as resolved.

Sign in to view

andrew-goldstein reviewed Oct 26, 2018

View reviewed changes

Added more lines of comments to protect against merging into master

5b38481

andrew-goldstein approved these changes Oct 26, 2018

View reviewed changes

FrankHassanabad merged commit 35ef51f into elastic:feature-secops Oct 26, 2018

FrankHassanabad deleted the focused-testing branch October 26, 2018 23:36

FrankHassanabad self-assigned this Oct 26, 2018

FrankHassanabad added Team:SIEM review loe:small Small Level of Effort labels Oct 26, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cut down on all tests except for secops tests and one example of infr… #24693

Cut down on all tests except for secops tests and one example of infr… #24693

FrankHassanabad commented Oct 26, 2018

This comment was marked as resolved.

This comment was marked as resolved.

andrew-goldstein Oct 26, 2018

andrew-goldstein left a comment

elasticmachine commented Oct 26, 2018

FrankHassanabad commented Oct 26, 2018

Cut down on all tests except for secops tests and one example of infr… #24693

Cut down on all tests except for secops tests and one example of infr… #24693

Conversation

FrankHassanabad commented Oct 26, 2018

This comment was marked as resolved.

This comment was marked as resolved.

andrew-goldstein Oct 26, 2018

Choose a reason for hiding this comment

andrew-goldstein left a comment

Choose a reason for hiding this comment

elasticmachine commented Oct 26, 2018

💚 Build Succeeded

FrankHassanabad commented Oct 26, 2018