-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut down on all tests except for secops tests and one example of infr… #24693
Merged
FrankHassanabad
merged 2 commits into
elastic:feature-secops
from
FrankHassanabad:focused-testing
Oct 26, 2018
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,13 +6,23 @@ | |
|
||
export default function ({ loadTestFile }) { | ||
describe('apis', () => { | ||
loadTestFile(require.resolve('./es')); | ||
loadTestFile(require.resolve('./security')); | ||
loadTestFile(require.resolve('./monitoring')); | ||
loadTestFile(require.resolve('./xpack_main')); | ||
loadTestFile(require.resolve('./logstash')); | ||
loadTestFile(require.resolve('./kibana')); | ||
// These commented out tests are only for within the secops branch and should not be merged into master | ||
// loadTestFile(require.resolve('./es')); | ||
This comment was marked as resolved.
Sorry, something went wrong. |
||
// loadTestFile(require.resolve('./security')); | ||
// loadTestFile(require.resolve('./monitoring')); | ||
// loadTestFile(require.resolve('./xpack_main')); | ||
// loadTestFile(require.resolve('./logstash')); | ||
// loadTestFile(require.resolve('./kibana')); | ||
// loadTestFile(require.resolve('./infra')); | ||
|
||
// TODO: I am only running infra at the moment | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. makes sense, and this comment will go away soon |
||
// but in reality I should not be running infra and | ||
// should instead be running secops which still needs | ||
// to be built. I kept this api integration test running for right now | ||
// as an example. -- Frank H. | ||
// See completion of issue: https://github.com/elastic/ingest-dev/issues/56 | ||
loadTestFile(require.resolve('./infra')); | ||
loadTestFile(require.resolve('./beats')); | ||
|
||
// loadTestFile(require.resolve('./beats')); | ||
}); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as resolved.
Sorry, something went wrong.