Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[es] when specifying path with vars always use encodeURIComponent #29210

Merged
merged 6 commits into from
Jan 24, 2019
Merged

[es] when specifying path with vars always use encodeURIComponent #29210

merged 6 commits into from
Jan 24, 2019

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Jan 23, 2019 •
edited
Loading

Fixes #29194

In node 10, urls are validated to not include any multi-byte characters, which wouldn't be possible if we were always encoding variables injected into URLs but we missed a couple places.

This was referenced Jan 23, 2019
Merged
Closed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger spalger requested a review from kobelb January 23, 2019 21:36
@spalger spalger added the v6.5.5 label Jan 23, 2019
kobelb
kobelb approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@kobelb kobelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this should only be backported as far as 6.6 though

@spalger spalger removed the v6.5.5 label Jan 23, 2019
@elasticmachine

This comment has been minimized.

Sign in to view
@kobelb
Copy link
Contributor

kobelb commented Jan 23, 2019

Still looks good to me, pending green CI

@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger spalger merged commit 78299c0 into elastic:master Jan 24, 2019
spalger pushed a commit to spalger/kibana that referenced this pull request Jan 24, 2019
[es] when specifying path with vars always use encodeURIComponent (el…
9092f2d 
…astic#29210)

Fixes elastic#29194

In node 10, urls are validated to not include any multi-byte characters, which wouldn't be possible if we were always encoding variables injected into URLs but we missed a couple places.
@spalger spalger mentioned this pull request Jan 24, 2019
Merged
spalger pushed a commit that referenced this pull request Jan 24, 2019
[es] when specifying path with vars always use encodeURIComponent (#2…
48f01ba 
…9210) (#29236)

Fixes #29194

In node 10, urls are validated to not include any multi-byte characters, which wouldn't be possible if we were always encoding variables injected into URLs but we missed a couple places.
@spalger spalger mentioned this pull request Jan 24, 2019
Merged
spalger pushed a commit to spalger/kibana that referenced this pull request Jan 24, 2019
[es] when specifying path with vars always use encodeURIComponent (el…
b2c811b 
…astic#29210)

Fixes elastic#29194

In node 10, urls are validated to not include any multi-byte characters, which wouldn't be possible if we were always encoding variables injected into URLs but we missed a couple places.
spalger pushed a commit that referenced this pull request Jan 24, 2019
[6.6] [es] when specifying path with vars always use encodeURICompone…
bbbacb0 
…nt (#29210) (#29237)

Backports the following commits to 6.6:
 - [es] when specifying path with vars always use encodeURIComponent  (#29210)
@spalger
Copy link
Contributor Author

spalger commented Jan 24, 2019

6.x/6.7: 48f01ba
6.6: bbbacb0

@spalger spalger deleted the fix/always-encode-uri-components branch January 24, 2019 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobelb kobelb kobelb approved these changes

Assignees
No one assigned
Labels
Feature:elasticsearch review v6.6.0 v6.7.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spalger @elasticmachine @kobelb