Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[es] when specifying path with vars always use encodeURIComponent #29210

Merged
merged 6 commits into from
Jan 24, 2019
Merged

[es] when specifying path with vars always use encodeURIComponent #29210

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
563c014
[es] when specifying path with vars always use encodeURIComponent
Jan 23, 2019
bceeba2
[ftr/indexPatterns] test that using multi-byte characters works
Jan 23, 2019
c3224d3
[jest] update snapshots
Jan 23, 2019
c7ca092
[ftr/indexPatterns] reset state after new test
Jan 23, 2019
02fc2b0
Merge branch 'master' of github.com:elastic/kibana into fix/always-en…
Jan 24, 2019
0eee951
[pageObjects/settings] fix call to setIndexPatternField()
Jan 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/legacy/core_plugins/elasticsearch/lib/create_proxy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export function createProxy(server) {
handler(req, h) {
const { query, payload: body } = req;
return callWithRequest(req, 'transport.request', {
path: `/${req.params.index}/_search`,
path: `/${encodeURIComponent(req.params.index)}/_search`,
method: 'POST',
query,
body
Expand Down
2 changes: 1 addition & 1 deletion ...plugins/index_lifecycle_management/server/routes/api/index/register_get_affected_route.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ async function getAffectedIndices(
}
const indexParams = {
method: 'GET',
path: `/${indexPatterns.join(',')}`,
path: `/${encodeURIComponent(indexPatterns.join(','))}`,
// we allow 404 in case there are no indices
ignore: [404]
};
Expand Down
4 changes: 2 additions & 2 deletions ...ugins/index_lifecycle_management/server/routes/api/templates/register_add_policy_route.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ async function updateIndexTemplate(callWithRequest, indexTemplatePatch) {

const params = {
method: 'PUT',
path: `/_template/${indexTemplatePatch.templateName}`,
path: `/_template/${encodeURIComponent(indexTemplatePatch.templateName)}`,
ignore: [ 404 ],
body: template,
};
Expand Down Expand Up @@ -67,4 +67,4 @@ export function registerAddPolicyRoute(server) {
pre: [ licensePreRouting ]
}
});
}
}
2 changes: 1 addition & 1 deletion x-pack/plugins/index_lifecycle_management/server/routes/api/templates/register_get_route.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { licensePreRoutingFactory } from'../../../lib/license_pre_routing_factor
async function fetchTemplate(callWithRequest, templateName) {
const params = {
method: 'GET',
path: `/_template/${templateName}`,
path: `/_template/${encodeURIComponent(templateName)}`,
// we allow 404 incase the user shutdown security in-between the check and now
ignore: [ 404 ]
};
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/index_management/server/routes/api/indices/register_freeze_route.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ function getIndexArrayFromPayload(payload) {

async function freezeIndices(callWithRequest, indices) {
const params = {
path: `/${indices.join(',')}/_freeze`,
path: `/${encodeURIComponent(indices.join(','))}/_freeze`,
method: 'POST',
};

Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/index_management/server/routes/api/indices/register_unfreeze_route.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ function getIndexArrayFromPayload(payload) {

async function unfreezeIndices(callWithRequest, indices) {
const params = {
path: `/${indices.join(',')}/_unfreeze`,
path: `/${encodeURIComponent(indices.join(','))}/_unfreeze`,
method: 'POST',
};

Expand Down