Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vis: Default editor] EUIficate pie chart options tab #41901

Merged
merged 6 commits into from
Jul 29, 2019
Merged

[Vis: Default editor] EUIficate pie chart options tab #41901

merged 6 commits into from
Jul 29, 2019

Conversation

sulemanof
Copy link
Contributor

@sulemanof sulemanof commented Jul 24, 2019 •
edited
Loading

Summary

A part of #38273.
EUIfication of the Options tab in Pie vis.

image

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@sulemanof sulemanof requested a review from maryia-lapata July 24, 2019 14:43
@sulemanof sulemanof added release_note:skip Skip the PR/issue when compiling release notes Feature:Vis Editor Visualization editor issues Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.4.0 v8.0.0 labels Jul 24, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@timroes timroes mentioned this pull request Jul 24, 2019
Closed
10 tasks
@sulemanof sulemanof requested a review from cchaos July 24, 2019 14:59
@elasticmachine
Copy link
Contributor

💔 Build Failed

cchaos
cchaos approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion about panel title sizing, but LGTM 👍

src/legacy/core_plugins/kbn_vislib_vis_types/public/editors/pie.tsx Outdated Show resolved Hide resolved
@maryia-lapata maryia-lapata mentioned this pull request Jul 25, 2019
Merged
3 tasks
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

maryia-lapata
maryia-lapata approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@maryia-lapata maryia-lapata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally

@sulemanof sulemanof mentioned this pull request Jul 26, 2019
Merged
7 tasks
flash1293
flash1293 approved these changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works, LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@sulemanof sulemanof merged commit 91adbfc into elastic:master Jul 29, 2019
@sulemanof sulemanof deleted the EUIfication/options/pie branch July 29, 2019 10:04
@sulemanof sulemanof mentioned this pull request Jul 29, 2019
Merged
sulemanof added a commit to sulemanof/kibana that referenced this pull request Jul 29, 2019
@sulemanof
[Vis: Default editor] EUIficate pie chart options tab (elastic#41901)
bd0bb9d 
* EUIficate pie chart options tab

* Fix tests

* Size titles down to xs

* Use FormattedMessage
sulemanof added a commit that referenced this pull request Jul 29, 2019
@sulemanof
[Vis: Default editor] EUIficate pie chart options tab (#41901) (#42125)
73ab20e 
* EUIficate pie chart options tab

* Fix tests

* Size titles down to xs

* Use FormattedMessage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maryia-lapata maryia-lapata maryia-lapata approved these changes

@flash1293 flash1293 flash1293 approved these changes

@cchaos cchaos cchaos approved these changes

@wylieconlon wylieconlon Awaiting requested review from wylieconlon

Assignees
No one assigned
Labels
backported Feature:Vis Editor Visualization editor issues release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sulemanof @elasticmachine @cchaos @flash1293 @maryia-lapata