[7.x] [Vis: Default Editor] EUIficate 'Metrics & Axis' tab (#43772) #45621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* EUIficate pointe-series and grid * Apply TS * Show grid on a panel * Remove extra space * Add TS * Use BasicOptions * Adjust func test * Add dataTestSubj prop to SelectOption * Use id instead of data-sest-subj * Disable show x-axis lines when there is histogram agg * Add tooltip for disabled 'Show x-axis lines' config * Add series_options.tsx * Migrate series * Improve changeValueAxis * Create CategoryAxisPanel * Create ValueAxesPanel * Create CustomExtentsOptions * File renaming * Use TruncateLabelsOption * Set min value * Add validation * Refactoring * Move types upper * Convert series logic * Convert valueAxes logic * Rename function * Add validation and refactoring * Adjust styles * Fix rotates * Apply config for other vis * Remove old directives * Fix useHook usage * Update vislib_vis_type.js * Fix * Move Threshold line panel into a separate component * Remove unused translations * Apply ui suggestions * Update functional tests * Remove angular unit test * Refactoring * Fix dependencies * Refactoring * Add validation * Add validation for other vis * Refactoring of onPositionChanged handler * Refactoring of addValueAxis * Get rid of a useEffect * Refactoring of updateAxisTitle * Update useCallback * Refactoring * Refactoring of collections config * Refactoring of setChartValueByIndex and setValueAxisByIndex * Update metrics_axes_options.tsx * Watch current tab for correct accordion height * Revert axis title logic * Fix axis id and name number * Fix code review comments * Fix functional tests * Update visualize_page.js * Move option tabs in common * Fix code review comments * Update index.tsx * Refactoring * Fix merge conflict * Show ThresholdPanel when it's configured * Fix passing a current tab to vis-options * Localize 'Count' text * Pass one axis to CategoryAxisPanel * Fix y-axis name number when x-axis position changed * Fix Y-axis name number when position Y-axis changed * Fix refresh loop * Re-organize controls * Apply code review comments * Refactoring * Fix extents empty value * Update y_extents.tsx * Fix code review comments * Fix updating several seriesParams when removing axis * Add thresholdLine config to horizontal bar * Refactoring * Reset grid.valueAxis when the axis deleted * Fix refresh loop * Set interpolate config for line * Enable "show dots"
💔 Build Failed |
|
retest |
💔 Build Failed |
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: