Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vis: Default Editor] EUIficate 'Metrics & Axis' tab - fix functional test #45641

Merged
merged 2 commits into from
Sep 16, 2019

Conversation

maryia-lapata
Copy link
Contributor

@maryia-lapata maryia-lapata commented Sep 13, 2019

Summary

Vertical bar chart tests are skipped in master but in 7.x not.

There is an issue in a skipped test. The fix was already merged in 7.x (#45621). I also added a fix to master.

@maryia-lapata maryia-lapata added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels Sep 13, 2019
@dmlemeshko dmlemeshko self-requested a review September 13, 2019 14:57
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@maryia-lapata maryia-lapata merged commit 71f6150 into elastic:master Sep 16, 2019
@maryia-lapata maryia-lapata deleted the fix_test branch September 16, 2019 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants