Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vis: Default editor] EUIficate Vega options tab #47473

Merged
merged 9 commits into from
Oct 18, 2019
Merged

[Vis: Default editor] EUIficate Vega options tab #47473

merged 9 commits into from
Oct 18, 2019

Conversation

sulemanof
Copy link
Contributor

@sulemanof sulemanof commented Oct 7, 2019 •
edited
Loading

Summary

A part of #38247.
EUIfication of the Vega visualization editor.

image

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

flash1293
flash1293 approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested and didn't notice any problems

src/legacy/core_plugins/vis_type_vega/public/components/vega_vis_editor.tsx Outdated Show resolved Hide resolved
src/legacy/core_plugins/vis_type_vega/public/components/vega_vis_editor.tsx Outdated Show resolved Hide resolved
@sulemanof sulemanof marked this pull request as ready for review October 10, 2019 11:13
@sulemanof sulemanof requested a review from a team as a code owner October 10, 2019 11:13
@timroes timroes mentioned this pull request Oct 10, 2019
Closed
4 tasks
@sulemanof sulemanof added Feature:Vega Vega visualizations release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.5.0 v8.0.0 labels Oct 10, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@sulemanof
Copy link
Contributor Author

@elasticmachine merge upstream

@sulemanof
Copy link
Contributor Author

sulemanof commented Oct 14, 2019 •
edited
Loading

@snide @chandlerprall @cchaos @ryankeairns
Kindly ask someone of you to take a look at this PR 😊
Thanks in advance!

@timroes timroes mentioned this pull request Oct 14, 2019
Closed
10 tasks
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

maryia-lapata
maryia-lapata suggested changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@maryia-lapata maryia-lapata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but we need to leave some configuration for reformatting. Please take a look at the comments below.

src/legacy/core_plugins/vis_type_vega/public/components/vega_help_menu.tsx Outdated Show resolved Hide resolved
src/legacy/core_plugins/vis_type_vega/public/components/vega_help_menu.tsx Outdated Show resolved Hide resolved
src/legacy/core_plugins/vis_type_vega/public/components/vega_help_menu.tsx Outdated Show resolved Hide resolved
src/legacy/core_plugins/vis_type_vega/public/components/vega_vis_editor.tsx Outdated
function format(value: string, stringify: typeof compactStringify) {
try {
const spec = hjson.parse(value, { legacyRoot: false, keepWsc: true });
return stringify(spec);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can skip options like it was before https://github.com/elastic/kibana/pull/47473/files#diff-2abd10d2a2ed5649151d832d6ae32983L63.
For example without options reformatting as HJON removes comments:
Oct-14-2019 16-00-46

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Fixed.
But currently HJSON formatting works incorrectly because of upgrading -> #48023

src/legacy/core_plugins/vis_type_vega/public/components/vega_help_menu.tsx Show resolved Hide resolved
@elasticmachine
Copy link
Contributor

💔 Build Failed

@sulemanof
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

cchaos
cchaos suggested changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a couple regressions due to some of the CSS removals.

src/legacy/core_plugins/vis_type_vega/public/_vega_editor.scss Show resolved Hide resolved
src/legacy/core_plugins/vis_type_vega/public/_vega_editor.scss Show resolved Hide resolved
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

cchaos
cchaos approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing those

maryia-lapata
maryia-lapata approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@maryia-lapata maryia-lapata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sulemanof sulemanof merged commit 3138709 into elastic:master Oct 18, 2019
@sulemanof sulemanof deleted the EUIfication/options/vega branch October 18, 2019 13:26
@sulemanof sulemanof added v7.6.0 and removed v7.5.0 labels Oct 18, 2019
@sulemanof sulemanof mentioned this pull request Oct 18, 2019
Merged
sulemanof added a commit to sulemanof/kibana that referenced this pull request Oct 18, 2019
@sulemanof
[Vis: Default editor] EUIficate Vega options tab (elastic#47473)
96c036d 
* EUIficate Vega options tab

* Update  list of dependencies

* Fix comments

* Adjust styles
sulemanof added a commit that referenced this pull request Oct 21, 2019
@sulemanof
[Vis: Default editor] EUIficate Vega options tab (#47473) (#48637)
354973e 
* EUIficate Vega options tab

* Update  list of dependencies

* Fix comments

* Adjust styles
@alexwizp alexwizp mentioned this pull request Aug 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexwizp alexwizp alexwizp approved these changes

@maryia-lapata maryia-lapata maryia-lapata approved these changes

@flash1293 flash1293 flash1293 approved these changes

@cchaos cchaos cchaos approved these changes

@ryankeairns ryankeairns Awaiting requested review from ryankeairns

@snide snide Awaiting requested review from snide

Assignees
No one assigned
Labels
Feature:Vega Vega visualizations release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sulemanof @elasticmachine @cchaos @flash1293 @maryia-lapata @alexwizp