Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Make navigation in tests more stable #50132

Merged
merged 3 commits into from
Nov 12, 2019
Merged

[ML] Make navigation in tests more stable #50132

merged 3 commits into from
Nov 12, 2019

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Nov 11, 2019 •
edited
Loading

Summary

This PR fixes the ML navigation.

Fixes #50130
Fixes #50113
Fixes #50106
Fixes #50102
Fixes #50011
Fixes #49942
Fixes #49696
Fixes #49315

@pheyos pheyos added :ml test_ui_functional v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.5.0 test-matrix Use this label to ensure PRs are tested with matrix jobs labels Nov 11, 2019
@pheyos pheyos self-assigned this Nov 11, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 11, 2019 •
edited by pheyos
Loading

💚 Build Succeeded

Passed 20x

@pheyos
Copy link
Member Author

pheyos commented Nov 11, 2019

retest

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 11, 2019 •
edited by pheyos
Loading

💚 Build Succeeded

Passed 20x

@pheyos
Copy link
Member Author

pheyos commented Nov 11, 2019

retest

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 11, 2019 •
edited by pheyos
Loading

💚 Build Succeeded

Passed 20x

@pheyos
Copy link
Member Author

pheyos commented Nov 11, 2019

retest

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 11, 2019 •
edited by pheyos
Loading

💔 Build Failed

Passed 19x, failed 1x with an unrelated dashboard failure.

@pheyos
Copy link
Member Author

pheyos commented Nov 11, 2019

retest

@pheyos pheyos changed the title [ML] Make navigation more stable [ML] Make navigation in tests more stable Nov 11, 2019
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 11, 2019 •
edited by pheyos
Loading

💚 Build Succeeded

Passed 20x

@pheyos
Copy link
Member Author

pheyos commented Nov 12, 2019

Summary of test executions so far:
Passed 99x, failed 1x with an unrelated dashboard failure.

@pheyos pheyos removed the test-matrix Use this label to ensure PRs are tested with matrix jobs label Nov 12, 2019
@pheyos pheyos marked this pull request as ready for review November 12, 2019 07:22
@pheyos pheyos requested a review from a team as a code owner November 12, 2019 07:22
@pheyos pheyos requested review from walterra and darnautov November 12, 2019 07:24
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 12, 2019 •
edited by pheyos
Loading

💔 Build Failed

Unrelated dashboard and visualize test failures.

walterra
walterra approved these changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

darnautov
darnautov approved these changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pheyos
Copy link
Member Author

pheyos commented Nov 12, 2019

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@pheyos pheyos merged commit d00be34 into elastic:master Nov 12, 2019
@pheyos pheyos deleted the fix_navigation branch November 12, 2019 11:04
@pheyos pheyos mentioned this pull request Nov 12, 2019
Merged
pheyos added a commit to pheyos/kibana that referenced this pull request Nov 12, 2019
@pheyos
[ML] Make navigation in tests more stable (elastic#50132)
9adbf7d 
This PR fixes the ML navigation.
pheyos added a commit to pheyos/kibana that referenced this pull request Nov 12, 2019
@pheyos
[ML] Make navigation in tests more stable (elastic#50132)
0447f08 
This PR fixes the ML navigation.
@pheyos pheyos mentioned this pull request Nov 12, 2019
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 12, 2019
@jloleysens
Merge remote-tracking branch 'upstream/master' into test-1
37d4836 
* upstream/master:
  [ML] Make navigation in tests more stable (elastic#50132)
  Migrate authorization subsystem to the new platform.  (elastic#46145)
  Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063)
  Update dependency @elastic/charts to v14 (elastic#49947)
  [ML] Adding cloud specific ML node warning (elastic#50139)
  Fixing bugs in the Shareable Runtime (elastic#49965)
  Revert router base name for Uptime plugin to use hash in default path. (elastic#50095)
  Ability to have telemetry always opted in (elastic#49798)
  Add "Get Help" and "Kibana Feedback" links to the help popover (elastic#49797)
  Removes references to Elasticsearch mapping types (elastic#47610)
  [skip-ci] Replace coordinate map in Kibana getting started docs with Maps (elastic#50167)
  [ML] Indicate missing required privileges for import in File Data Viz (elastic#50147)
  [SIEM][Detection Engine] Removes technical debt and minor bug fixes (elastic#50111)
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 12, 2019
@jloleysens
Merge remote-tracking branch 'upstream/master' into test-3
7b512ad 
* upstream/master:
  Move table-list-view to kibana-react (elastic#50046)
  [ML] Stats bar for data frame analytics (elastic#49464)
  [ML] Make navigation in tests more stable (elastic#50132)
  Migrate authorization subsystem to the new platform.  (elastic#46145)
  Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063)
  Update dependency @elastic/charts to v14 (elastic#49947)
  [ML] Adding cloud specific ML node warning (elastic#50139)
  Fixing bugs in the Shareable Runtime (elastic#49965)
  Revert router base name for Uptime plugin to use hash in default path. (elastic#50095)
  Ability to have telemetry always opted in (elastic#49798)
  Add "Get Help" and "Kibana Feedback" links to the help popover (elastic#49797)
  Removes references to Elasticsearch mapping types (elastic#47610)
  [skip-ci] Replace coordinate map in Kibana getting started docs with Maps (elastic#50167)
  [ML] Indicate missing required privileges for import in File Data Viz (elastic#50147)
  [SIEM][Detection Engine] Removes technical debt and minor bug fixes (elastic#50111)
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 12, 2019
@jloleysens
Merge remote-tracking branch 'upstream/master' into np-migration/ua […
faa2676 
…skip ci]

* upstream/master:
  Move table-list-view to kibana-react (elastic#50046)
  [ML] Stats bar for data frame analytics (elastic#49464)
  [ML] Make navigation in tests more stable (elastic#50132)
  Migrate authorization subsystem to the new platform.  (elastic#46145)
  Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063)
  Update dependency @elastic/charts to v14 (elastic#49947)
  [ML] Adding cloud specific ML node warning (elastic#50139)
  Fixing bugs in the Shareable Runtime (elastic#49965)
  Revert router base name for Uptime plugin to use hash in default path. (elastic#50095)
  Ability to have telemetry always opted in (elastic#49798)
  Add "Get Help" and "Kibana Feedback" links to the help popover (elastic#49797)
  Removes references to Elasticsearch mapping types (elastic#47610)
  [skip-ci] Replace coordinate map in Kibana getting started docs with Maps (elastic#50167)
  [ML] Indicate missing required privileges for import in File Data Viz (elastic#50147)
  [SIEM][Detection Engine] Removes technical debt and minor bug fixes (elastic#50111)
pheyos added a commit that referenced this pull request Nov 12, 2019
@pheyos
[ML] Make navigation in tests more stable (#50132) (#50291)
4d64a3f 
This PR fixes the ML navigation.
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 13, 2019
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into fix/grokdebug…
0c102d9 
…ger-ace-theme

* 'master' of github.com:elastic/kibana: (56 commits)
  [ML] Server info service refactor (elastic#50302)
  Remove internal platform types exports (elastic#50427)
  [APM] Document `apm_oss.metricsIndices` and `apm_oss.sourcemap… (elastic#50312)
  [Telemetry] Server side fetcher (elastic#50015)
  [SIEM] Detection engine placeholders (elastic#50220)
  [Uptime] Donut chart loader position centered vertically  (elastic#50219)
  update telemetry banner notice text (elastic#50403)
  Fix aborting when searching without batching (elastic#49966)
  [Telemetry] Remove telemetry splash page and add conditional messaging (elastic#50189)
  Revert chromedriver update (elastic#50324)
  Remove deprecated argument include_type_name from ES calls (elastic#50285)
  [Maps] add settings to maps telemetry (elastic#50161)
  remove visualize loader (elastic#46910)
  Fix misuse of react-router and react-router-dom (elastic#50120)
  Move table-list-view to kibana-react (elastic#50046)
  [ML] Stats bar for data frame analytics (elastic#49464)
  [ML] Make navigation in tests more stable (elastic#50132)
  Migrate authorization subsystem to the new platform.  (elastic#46145)
  Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063)
  Update dependency @elastic/charts to v14 (elastic#49947)
  ...
pheyos added a commit that referenced this pull request Nov 13, 2019
@pheyos
[ML] Make navigation in tests more stable (#50132) (#50292)
91587e2 
This PR fixes the ML navigation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darnautov darnautov darnautov approved these changes

@walterra walterra walterra approved these changes

Assignees

@pheyos pheyos

Labels
:ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing test: Firefox XPack UI Functional Tests.x-pack/test/functional/apps/machine_learning/anomaly_detection/multi_metric_job·ts - machine learning anomaly detection multi metric job creation displays the created job in the job list Failing test: Firefox XPack UI Functional Tests.x-pack/test/functional/apps/machine_learning/anomaly_detection/advanced_job·ts - machine learning anomaly detection advanced job with multiple metric detectors and custom datafeed settings job creation loads the job management page Failing test: Firefox XPack UI Functional Tests.x-pack/test/functional/apps/machine_learning/anomaly_detection/saved_search_job·ts - machine learning anomaly detection saved search with filter and kuery query job creation loads the job management page Failing test: Firefox XPack UI Functional Tests.x-pack/test/functional/apps/machine_learning/anomaly_detection/saved_search_job·ts - machine learning anomaly detection saved search with lucene query job creation displays the created job in the job list Failing test: Firefox XPack UI Functional Tests.x-pack/test/functional/apps/machine_learning/anomaly_detection/saved_search_job·ts - machine learning anomaly detection saved search job creation with filter and lucene query loads the job management page
Failing test: Firefox XPack UI Functional Tests.x-pack/test/functional/apps/machine_learning/anomaly_detection/population_job·ts - machine learning anomaly detection population job creation displays the created job in the job list Failing test: Firefox XPack UI Functional Tests.x-pack/test/functional/apps/machine_learning/anomaly_detection/advanced_job·ts - machine learning anomaly detection advanced job with categorization detector and default datafeed settings job creation loads the job management page Failing test: Firefox XPack UI Functional Tests.x-pack/test/functional/apps/machine_learning/anomaly_detection/population_job·ts - machine learning anomaly detection population job creation loads the job management page
4 participants
@pheyos @elasticmachine @walterra @darnautov