Remove deprecated argument include_type_name from ES calls #50285

lizozom · 2019-11-12T10:07:30Z

Summary

include_type_name was deprecated since v7.0 and was recently removed in v8.0 this PR.

force_memory_term_dictionary was deprecated as well.

ATM tests are breaking on master due to a snapshot update. This PR removes all usages of include_type_name and force_memory_term_dictionary.

mappings files which need to be updated:

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2019-11-12T10:09:25Z

Pinging @elastic/kibana-app-arch (Team:AppArch)

romseygeek

LGTM

flash1293

Changes LGTM, did not test locally

elasticmachine · 2019-11-12T11:19:41Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 8a1003d

jloleysens

Tested locally, Console changes LGTM.

src/es_archiver/lib/indices/create_index_stream.js

elasticmachine · 2019-11-12T12:18:17Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 9b1c3fe

rudolf · 2019-11-12T13:37:47Z

@elastic/stack-monitoring After changing the mappings file x-pack/test/functional/es_archives/monitoring/apm/mappings.json to remove the "doc" type so that it's compatible with v8.0.0 the test

kibana/x-pack/test/api_integration/apis/monitoring/apm/instance.js

Line 29 in 2e232c2

it('should get apm instance data', async () => {

started failing. Can you please take a look?

elasticmachine · 2019-11-12T14:39:04Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 9a8cd6c

elasticmachine · 2019-11-12T15:13:25Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 99256b5

…include_type_name

elasticmachine · 2019-11-12T16:04:16Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: f936f95

rudolf · 2019-11-12T16:15:03Z

@lizozom

This failing test:

apis
       management
         index management
           settings
             should fetch an index settings:
     Error: Expected setting "force_memory_term_dictionary" not found

seems to be caused by the removal of that setting:
https://github.com/elastic/elasticsearch/blob/3ce7a37f1ff2ff4c24c97c60ce619f840ed1b7fb/docs/reference/migration/migrate_8_0/indices.asciidoc

So it should be safe to remove.

/CC @elastic/es-ui

elasticmachine · 2019-11-12T17:47:59Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 5412be3

rudolf

Even when ignoring whitespace there's so much formatting changes it's hard to review every line, but with ignoring the mappings changes everything looks good, so with CI being green I think this is good to merge 👍

elasticmachine · 2019-11-12T21:41:24Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 5412be3

* upstream/master: Remove internal platform types exports (elastic#50427) [APM] Document `apm_oss.metricsIndices` and `apm_oss.sourcemap… (elastic#50312) [Telemetry] Server side fetcher (elastic#50015) [SIEM] Detection engine placeholders (elastic#50220) [Uptime] Donut chart loader position centered vertically (elastic#50219) update telemetry banner notice text (elastic#50403) Fix aborting when searching without batching (elastic#49966) [Telemetry] Remove telemetry splash page and add conditional messaging (elastic#50189) Revert chromedriver update (elastic#50324) Remove deprecated argument include_type_name from ES calls (elastic#50285) [Maps] add settings to maps telemetry (elastic#50161) remove visualize loader (elastic#46910) Fix misuse of react-router and react-router-dom (elastic#50120)

…-fallback * 'master' of github.com:elastic/kibana: Remove internal platform types exports (elastic#50427) [APM] Document `apm_oss.metricsIndices` and `apm_oss.sourcemap… (elastic#50312) [Telemetry] Server side fetcher (elastic#50015) [SIEM] Detection engine placeholders (elastic#50220) [Uptime] Donut chart loader position centered vertically (elastic#50219) update telemetry banner notice text (elastic#50403) Fix aborting when searching without batching (elastic#49966) [Telemetry] Remove telemetry splash page and add conditional messaging (elastic#50189) Revert chromedriver update (elastic#50324) Remove deprecated argument include_type_name from ES calls (elastic#50285) [Maps] add settings to maps telemetry (elastic#50161) remove visualize loader (elastic#46910) Fix misuse of react-router and react-router-dom (elastic#50120) Move table-list-view to kibana-react (elastic#50046) [ML] Stats bar for data frame analytics (elastic#49464)

…ger-ace-theme * 'master' of github.com:elastic/kibana: (56 commits) [ML] Server info service refactor (elastic#50302) Remove internal platform types exports (elastic#50427) [APM] Document `apm_oss.metricsIndices` and `apm_oss.sourcemap… (elastic#50312) [Telemetry] Server side fetcher (elastic#50015) [SIEM] Detection engine placeholders (elastic#50220) [Uptime] Donut chart loader position centered vertically (elastic#50219) update telemetry banner notice text (elastic#50403) Fix aborting when searching without batching (elastic#49966) [Telemetry] Remove telemetry splash page and add conditional messaging (elastic#50189) Revert chromedriver update (elastic#50324) Remove deprecated argument include_type_name from ES calls (elastic#50285) [Maps] add settings to maps telemetry (elastic#50161) remove visualize loader (elastic#46910) Fix misuse of react-router and react-router-dom (elastic#50120) Move table-list-view to kibana-react (elastic#50046) [ML] Stats bar for data frame analytics (elastic#49464) [ML] Make navigation in tests more stable (elastic#50132) Migrate authorization subsystem to the new platform. (elastic#46145) Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063) Update dependency @elastic/charts to v14 (elastic#49947) ...

deprecate include_type_name

8a1003d

lizozom self-assigned this Nov 12, 2019

lizozom added bug Fixes for quality problems that affect the customer experience v7.6.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:AppArch labels Nov 12, 2019

lizozom requested a review from ppisljar November 12, 2019 10:09

romseygeek approved these changes Nov 12, 2019

View reviewed changes

flash1293 approved these changes Nov 12, 2019

View reviewed changes

include_type_name

9b1c3fe

jloleysens approved these changes Nov 12, 2019

View reviewed changes

rudolf reviewed Nov 12, 2019

View reviewed changes

src/es_archiver/lib/indices/create_index_stream.js Show resolved Hide resolved

Liza K added 4 commits November 12, 2019 15:15

remove doc from mappings

aff2393

Updated timelion mapping

d7cd41f

Updated spaces and uptime mapping

eea2096

monitoring apm mapping

9a8cd6c

Updated more mappings

99256b5

pgayvallet mentioned this pull request Nov 12, 2019

Remove react references from core Notifications apis #49573

Merged

4 tasks

Liza K added 2 commits November 12, 2019 16:40

2 more mappings

863e25f

Updated reporting mappings after syncing with @gammon

f936f95

Merge remote-tracking branch 'upstream/master' into deprecate/remove-…

1d76534

…include_type_name

Removed deprecated setting

5412be3

lizozom merged commit 19f7e99 into elastic:master Nov 12, 2019

rudolf approved these changes Nov 12, 2019

View reviewed changes

lizozom removed the v7.6.0 label Nov 12, 2019

lizozom deleted the deprecate/remove-include_type_name branch November 14, 2019 13:05

alisonelizabeth mentioned this pull request Nov 21, 2019

[UA] Remove include_type_name parameter from request #49634

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove deprecated argument include_type_name from ES calls #50285

Remove deprecated argument include_type_name from ES calls #50285

lizozom commented Nov 12, 2019 •

edited

Loading

elasticmachine commented Nov 12, 2019

romseygeek left a comment

flash1293 left a comment

elasticmachine commented Nov 12, 2019

jloleysens left a comment

elasticmachine commented Nov 12, 2019

rudolf commented Nov 12, 2019

elasticmachine commented Nov 12, 2019

elasticmachine commented Nov 12, 2019

elasticmachine commented Nov 12, 2019

rudolf commented Nov 12, 2019

elasticmachine commented Nov 12, 2019

rudolf left a comment

elasticmachine commented Nov 12, 2019

Remove deprecated argument include_type_name from ES calls #50285

Remove deprecated argument include_type_name from ES calls #50285

Conversation

lizozom commented Nov 12, 2019 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented Nov 12, 2019

romseygeek left a comment

Choose a reason for hiding this comment

flash1293 left a comment

Choose a reason for hiding this comment

elasticmachine commented Nov 12, 2019

💔 Build Failed

jloleysens left a comment

Choose a reason for hiding this comment

elasticmachine commented Nov 12, 2019

💔 Build Failed

rudolf commented Nov 12, 2019

elasticmachine commented Nov 12, 2019

💔 Build Failed

elasticmachine commented Nov 12, 2019

💔 Build Failed

elasticmachine commented Nov 12, 2019

💔 Build Failed

rudolf commented Nov 12, 2019

elasticmachine commented Nov 12, 2019

💔 Build Failed

rudolf left a comment

Choose a reason for hiding this comment

elasticmachine commented Nov 12, 2019

💚 Build Succeeded

lizozom commented Nov 12, 2019 •

edited

Loading