-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Console] Update template definitions #51592
[Console] Update template definitions #51592
Conversation
- Update _template body completions
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jloleysens Thanks for adding this! Tested locally. LGTM.
I had one question, but I don't think it's blocking.
@@ -21,7 +21,7 @@ import { ListComponent } from './list_component'; | |||
|
|||
export class TemplateAutocompleteComponent extends ListComponent { | |||
constructor(name, parent) { | |||
super(name, mappings.getTemplates, parent); | |||
super(name, mappings.getTemplates, parent, true, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these args related to this statement: Updates completion to kick in even if index in URL does not match an existing endpoint
?
Also, note that the url contains the template name, not the index (not sure if you just had a typo there or not).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these args related to this statement:...
Yes, :(. Sorry that it's a bit unclear but I would very much like to get to properly documenting how the system works. The object being extended is ListComponent
which is where you would be able to better see what those arguments do.
Also, note...
Ah fair enough! That was my mistake, will update PR description.
…ist (elastic#51592) - Update _template body completions
Great! Thanks for this enhancement! |
Summary
Addresses #50415
indextemplate in URL does not match an existing endpointChecklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers