Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Update template definitions #51592

Merged

Conversation

jloleysens
Copy link
Contributor

@jloleysens jloleysens commented Nov 25, 2019

Summary

Addresses #50415

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@jloleysens jloleysens added Feature:Console Dev Tools Console Feature v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.6.0 labels Nov 25, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jloleysens Thanks for adding this! Tested locally. LGTM.

I had one question, but I don't think it's blocking.

@@ -21,7 +21,7 @@ import { ListComponent } from './list_component';

export class TemplateAutocompleteComponent extends ListComponent {
constructor(name, parent) {
super(name, mappings.getTemplates, parent);
super(name, mappings.getTemplates, parent, true, true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these args related to this statement: Updates completion to kick in even if index in URL does not match an existing endpoint?

Also, note that the url contains the template name, not the index (not sure if you just had a typo there or not).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these args related to this statement:...

Yes, :(. Sorry that it's a bit unclear but I would very much like to get to properly documenting how the system works. The object being extended is ListComponent which is where you would be able to better see what those arguments do.

Also, note...

Ah fair enough! That was my mistake, will update PR description.

@jloleysens jloleysens merged commit a1b01f4 into elastic:master Nov 25, 2019
@jloleysens jloleysens deleted the console/template-body-completion branch November 25, 2019 14:15
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 25, 2019
@jloleysens jloleysens added v7.5.0 and removed v7.5.0 labels Nov 25, 2019
jloleysens added a commit that referenced this pull request Nov 26, 2019
@fbaligand
Copy link
Contributor

Great! Thanks for this enhancement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Console Dev Tools Console Feature release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants