Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Console] Update template definitions #51592

Merged
merged 1 commit into from
Nov 25, 2019
Merged

[Console] Update template definitions #51592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...console/public/quarantined/src/autocomplete/components/template_autocomplete_component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import { ListComponent } from './list_component';

export class TemplateAutocompleteComponent extends ListComponent {
constructor(name, parent) {
super(name, mappings.getTemplates, parent);
super(name, mappings.getTemplates, parent, true, true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these args related to this statement: Updates completion to kick in even if index in URL does not match an existing endpoint?

Also, note that the url contains the template name, not the index (not sure if you just had a typo there or not).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these args related to this statement:...

Yes, :(. Sorry that it's a bit unclear but I would very much like to get to properly documenting how the system works. The object being extended is ListComponent which is where you would be able to better see what those arguments do.

Also, note...

Ah fair enough! That was my mistake, will update PR description.

}
getContextKey() {
return 'template';
Expand Down
12 changes: 9 additions & 3 deletions src/legacy/core_plugins/console/server/api_server/spec/overrides/indices.put_template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,16 @@
{
"indices.put_template": {
"data_autocomplete_rules": {
"template": "index*",
"warmers": { "__scope_link": "_warmer" },
"index_patterns": [],
"mappings": { "__scope_link": "put_mapping" },
"settings": { "__scope_link": "put_settings" }
"settings": { "__scope_link": "put_settings" },
"version": 0,
"order": 0,
"aliases": {
"__template": {
"NAME": {}
}
}
},
"patterns": [
"_template/{template}"
Expand Down