Add top level examples folder and command to run, --run-examples.
#52027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed
|
stacey-gammon
force-pushed
the
2019-11-25-run-demos-shortcuts
branch
from
ed86c9e to
3badfa2
Compare
💔 Build Failed
|
stacey-gammon
force-pushed
the
2019-11-25-run-demos-shortcuts
branch
2 times, most recently
from
4c31ad4 to
c29adca
Compare
💔 Build Failed
|
stacey-gammon
force-pushed
the
2019-11-25-run-demos-shortcuts
branch
2 times, most recently
from
d247678 to
4c199f0
Compare
stacey-gammon
added
the
release_note:plugin_api_changes
stacey-gammon
added
v7.6.0
v8.0.0
release_note:skip
|
Pinging @elastic/kibana-platform (Team:Platform) |
💔 Build Failed
|
stacey-gammon
force-pushed
the
2019-11-25-run-demos-shortcuts
branch
2 times, most recently
from
fe4c89d to
96754d6
Compare
stacey-gammon
force-pushed
the
2019-11-25-run-demos-shortcuts
branch
from
96754d6 to
b8a0215
Compare
💔 Build Failed
|
stacey-gammon
force-pushed
the
2019-11-25-run-demos-shortcuts
branch
from
b8a0215 to
52c2bd1
Compare
💔 Build Failed
|
stacey-gammon
force-pushed
the
2019-11-25-run-demos-shortcuts
branch
from
52c2bd1 to
f3c54d4
Compare
💚 Build Succeeded |
💚 Build Succeeded |
joshdover
approved these changes
Dec 10, 2019
| @@ -237,7 +243,7 @@ export default function (program) { | |||
| silent: !!opts.silent, | |||
| watch: !!opts.watch, | |||
| repl: !!opts.repl, | |||
| basePath: !!opts.basePath, | |||
| basePath: opts.runExamples ? false : !!opts.basePath, | |||
There was a problem hiding this comment.
What's the reason for this?
There was a problem hiding this comment.
Good question. Added an explanation. Copying here:
// We want to run without base path when the `--run-examples` flag is given so that we can use local
// links in other documentation sources, like "View this tutorial [here](http://localhost:5601/app/tutorial/xyz)".
// We can tell users they only have to run with `yarn start --run-examples` to get those
// local links to work. Similar to what we do for "View in Console" links in our
// elastic.co links.
|
@elasticmachine merge upstream |
…mmon/kibana into 2019-11-25-run-demos-shortcuts
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Dec 11, 2019
…le-sql-highlighting * 'master' of github.com:elastic/kibana: (56 commits) Migrate url shortener service (elastic#50896) Re-enable datemath in from/to canvas timelion args (elastic#52159) [Logs + Metrics UI] Remove eslint exceptions (elastic#50979) [Logs + Metrics UI] Add missing headers in Logs & metrics (elastic#52405) [ML] API integration tests - initial tests for bucket span estimator (elastic#52636) [Watcher] New Platform (NP) Migration (elastic#50908) Decouple Authorization subsystem from Legacy API. (elastic#52638) [APM] Fix some warnings logged in APM tests (elastic#52487) [ui/public/utils] Delete unused base_object & find_by_param (elastic#52500) [ui/public/utils] Move items into ui/vis (elastic#52615) fix newlines in kbn-analytics build script Add top level examples folder and command to run, `--run-examples`. (elastic#52027) feat(NA): add trap for SIGINT in the git precommit hook (elastic#52662) [DOCS] Updtes description of elasticsearch.requestHeadersWhitelist (elastic#52675) [Telemetry/Pulse] Updates advanced settings text for usage data (elastic#52657) [SIEM][Detection Engine] Adds the default name space to the end of the signals index [Logs UI] Generalize ML module management (elastic#50662) Removing stateful saved object finder (elastic#52166) Shim oss telemetry (elastic#51168) [Reporting/Screenshots] Do not fail the report if request is aborted (elastic#52344) ... # Conflicts: # src/legacy/core_plugins/console/public/legacy.ts # src/legacy/core_plugins/console/public/np_ready/application/models/legacy_core_editor/mode/elasticsearch_sql_highlight_rules.ts # src/legacy/core_plugins/console/public/np_ready/lib/autocomplete/components/full_request_component.ts # src/legacy/core_plugins/console/public/quarantined/src/sense_editor/row_parser.js
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Dec 11, 2019
…lastic#52027) * Add top level examples folder and command to run, `--run-examples`. * Add comment explaining reason --run-examples flag turns off base path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26781
examplesfolder filled with example plugins that can be run with a--run-examplesflag. Currently the only two plugins in there are:plugin_functionalfolder so it could use the--run-examplesflag in the config.Blocks #52111