[Reporting/Screenshots] Do not fail the report if request is aborted #52344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
|
tsullivan
force-pushed
the
reporting/ignore-network-request-failures
branch
from
12c8bcc to
d477a82
Compare
tsullivan
added
(Deprecated) Feature:Reporting
|
Pinging @elastic/kibana-stack-services (Team:Stack Services) |
|
@elasticmachine merge upstream |
tsullivan
commented
Dec 9, 2019
| tap(line => { | ||
| getBrowserLogger(page: Page): Rx.Observable<void> { | ||
| const consoleMessages$ = Rx.fromEvent<ConsoleMessage>(page, 'console').pipe( | ||
| map(line => { |
There was a problem hiding this comment.
switching from tap to map makes this an Observable of void
|
@tsullivan I'm not sure I can actually test this correctly until it's merged and in a snapshot build. I'll try it locally and report my results but if it passes, I don't think it will be definitive. |
|
I'm struggling to get all the setup correct for my watcher/reporting test when running from this PR source. But I did get to the point of seeing the |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Dec 10, 2019
…lastic#52344) * [Reporting/Screenshots] Do not fail the report if request is aborted * take pageRequestFailed out of pageExit observable
|
7.x/7.6.0: #52653 |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Dec 11, 2019
…le-sql-highlighting * 'master' of github.com:elastic/kibana: (56 commits) Migrate url shortener service (elastic#50896) Re-enable datemath in from/to canvas timelion args (elastic#52159) [Logs + Metrics UI] Remove eslint exceptions (elastic#50979) [Logs + Metrics UI] Add missing headers in Logs & metrics (elastic#52405) [ML] API integration tests - initial tests for bucket span estimator (elastic#52636) [Watcher] New Platform (NP) Migration (elastic#50908) Decouple Authorization subsystem from Legacy API. (elastic#52638) [APM] Fix some warnings logged in APM tests (elastic#52487) [ui/public/utils] Delete unused base_object & find_by_param (elastic#52500) [ui/public/utils] Move items into ui/vis (elastic#52615) fix newlines in kbn-analytics build script Add top level examples folder and command to run, `--run-examples`. (elastic#52027) feat(NA): add trap for SIGINT in the git precommit hook (elastic#52662) [DOCS] Updtes description of elasticsearch.requestHeadersWhitelist (elastic#52675) [Telemetry/Pulse] Updates advanced settings text for usage data (elastic#52657) [SIEM][Detection Engine] Adds the default name space to the end of the signals index [Logs UI] Generalize ML module management (elastic#50662) Removing stateful saved object finder (elastic#52166) Shim oss telemetry (elastic#51168) [Reporting/Screenshots] Do not fail the report if request is aborted (elastic#52344) ... # Conflicts: # src/legacy/core_plugins/console/public/legacy.ts # src/legacy/core_plugins/console/public/np_ready/application/models/legacy_core_editor/mode/elasticsearch_sql_highlight_rules.ts # src/legacy/core_plugins/console/public/np_ready/lib/autocomplete/components/full_request_component.ts # src/legacy/core_plugins/console/public/quarantined/src/sense_editor/row_parser.js
tsullivan
added
release_note:fix
and removed
release_note:skip
💔 Build FailedHistory
To update your PR or re-run it, just comment with: |
This was referenced Jan 13, 2020
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Jan 13, 2020
…lastic#52344) * [Reporting/Screenshots] Do not fail the report if request is aborted * take pageRequestFailed out of pageExit observable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #52350
Release note: Fixed an issue in Reporting to stop the job from failing when there were aborted requests on the Kibana page.
Kibana applications have the ability now to abort network requests that have been fired, without waiting for a response, and this can happen during rendering. This seems to happen most of the time when Elasticsearch is finding search results with no cache (fresh restart of Elasticsearch).
These situations would cause Reporting jobs to fail, because we would fail a job when there were network errors detected.
This PR simply logs network errors as a warning, and assumes the reporting job still has a chance to complete successfully.
Here is the new warning log item:
Here are full logs with the warning in context:
I am not sure how this could be covered by testing.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11- Reporting screenshot capture is Chromium only.[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibility