-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs UI] Refactor log position to hooks #53540
Conversation
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
d755a10
to
03e0230
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good so far. Thanks!
Let's wait until the other PR is merged before I mark it as approved
x-pack/legacy/plugins/infra/public/containers/logs/log_filter/use_log_filter_url_state.tsx
Outdated
Show resolved
Hide resolved
@@ -5,4 +5,3 @@ | |||
*/ | |||
|
|||
export * from './log_highlights'; | |||
export * from './redux_bridges'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
03e0230
to
6a94a40
Compare
This reverts commit 4e04aa0. # Conflicts: # x-pack/legacy/plugins/infra/public/containers/logs/log_filter/use_log_filter_url_state.tsx # x-pack/legacy/plugins/infra/public/pages/logs/stream/page_providers.tsx
e324628
to
d43ffcb
Compare
retest |
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
* Move URL state to hook * Fix log filter URL state infinite loop * Initial refactor of log position to hooks * Simplify and reimplement controlsShouldDisplayTargetPosition * Fix live streaming * Flatten logposition destructuring * Revert "Move URL state to hook" This reverts commit 4e04aa0. # Conflicts: # x-pack/legacy/plugins/infra/public/containers/logs/log_filter/use_log_filter_url_state.tsx # x-pack/legacy/plugins/infra/public/pages/logs/stream/page_providers.tsx * Fix unused imports * Fix link-to test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* master: (55 commits) [ui/public/utils] Copy rarely used items to where they are consumed (elastic#53819) set AppArch team as an owner of the search endpoints (elastic#54131) Don't expose Elasticsearch client as Observable (elastic#53824) [SIEM] Cleanup unnecessary use of enzyme-to-json (elastic#53980) fix ui exports doc (elastic#54138) change markdown element title (elastic#54194) [Logs UI] Refactor log position to hooks (elastic#53540) [SIEM] Implement NP Plugin Setup (elastic#54030) [DOCS] Updates ML links (elastic#53613) sort renovate packages in config Spaces - fix flakey api tests (elastic#54154) Remove dependency that was causing effect to re-execute infinitely. (elastic#54160) [dev/run] expose unexpected flags as more than just names (elastic#54080) [DOCS] Moves index pattern doc to Discover (elastic#53347) [SIEM] Cleanup React imports (elastic#53981) Update eslint related packages (elastic#54107) [Uptime] Added date range filter into expanded list query (elastic#52609) [SIEM] Add react/display-name eslint rule (elastic#53107) [SIEM] Enable eslint prefer-template rule (elastic#53983) Elasticsearch snapshots automation (elastic#53706) ...
* Move URL state to hook * Fix log filter URL state infinite loop * Initial refactor of log position to hooks * Simplify and reimplement controlsShouldDisplayTargetPosition * Fix live streaming * Flatten logposition destructuring * Revert "Move URL state to hook" This reverts commit 4e04aa0. # Conflicts: # x-pack/legacy/plugins/infra/public/containers/logs/log_filter/use_log_filter_url_state.tsx # x-pack/legacy/plugins/infra/public/pages/logs/stream/page_providers.tsx * Fix unused imports * Fix link-to test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Summary
Closes #50398
Rebuilds log position state logic within hooks, and simplifies a great deal of this logic. Also encapsulates live streaming further within the log entries hook, having it call back to the log position hook in order to scroll along with the stream. Scroll locking functionality is now exclusively in the
ScrollableLogTextStreamView
component rather than in the state hook.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers