-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Updates ML links #53613
[DOCS] Updates ML links #53613
Conversation
Pinging @elastic/kibana-docs (Team:Docs) |
Pinging @elastic/ml-ui (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to edit the link to the job tips page in x-pack/legacy/plugins/ml/public/application/components/validate_job/validate_job_view.js
to https://www.elastic.co/guide/en/machine-learning/${metadata.branch}/create-jobs.html#job-tips
@@ -24,15 +24,15 @@ export const getMessages = () => { | |||
}, | |||
}), | |||
url: | |||
'https://www.elastic.co/guide/en/elastic-stack-overview/{{version}}/ml-configuring-aggregation.html', | |||
'https://www.elastic.co/guide/en/machine-learning/{{version}}/ml-configuring-aggregation.html', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will need to rebase against the changes I made in #53576, and edit all the links in this file to the previous Create anomaly detection jobs page. So the createJobsDocsUrl
field I added in my PR needs to be amended to https://www.elastic.co/guide/en/machine-learning/{{version}}/create-jobs.html
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @peteharverson !
@elasticmachine merge upstream |
💔 Build FailedHistory
To update your PR or re-run it, just comment with: |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
* master: (55 commits) [ui/public/utils] Copy rarely used items to where they are consumed (elastic#53819) set AppArch team as an owner of the search endpoints (elastic#54131) Don't expose Elasticsearch client as Observable (elastic#53824) [SIEM] Cleanup unnecessary use of enzyme-to-json (elastic#53980) fix ui exports doc (elastic#54138) change markdown element title (elastic#54194) [Logs UI] Refactor log position to hooks (elastic#53540) [SIEM] Implement NP Plugin Setup (elastic#54030) [DOCS] Updates ML links (elastic#53613) sort renovate packages in config Spaces - fix flakey api tests (elastic#54154) Remove dependency that was causing effect to re-execute infinitely. (elastic#54160) [dev/run] expose unexpected flags as more than just names (elastic#54080) [DOCS] Moves index pattern doc to Discover (elastic#53347) [SIEM] Cleanup React imports (elastic#53981) Update eslint related packages (elastic#54107) [Uptime] Added date range filter into expanded list query (elastic#52609) [SIEM] Add react/display-name eslint rule (elastic#53107) [SIEM] Enable eslint prefer-template rule (elastic#53983) Elasticsearch snapshots automation (elastic#53706) ...
Summary
Related to elastic/stack-docs#777 and #53713
This PR updates links to machine learning content so that they point to the appropriate book (https://www.elastic.co/guide/en/machine-learning/master/index.html instead of https://www.elastic.co/guide/en/elastic-stack-overview/master/index.html).
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers