Disallow importing Joi client side

[jloleysens]

Summary

After this blocker: #54888 arose blocking 7.6 QA (and a previous case of joi causing an issue in IE11 (#36493)).

This seems like something an automated check can help with.

How to review

• test importing joi in x-pack plugin public
• test importing joi in oss plugin public

Screenshot

Piggy backing off of existing eslint rules

[jloleysens]

Looks like eslint has picked up two cases of joi inside shared module code. We can escape the eslint rule there?

[flash1293]

The first one looks like it is only used on the server, so it should be save to move it to a server directory together with the whole lib folder (the folder structure of this plugin is strange anyway). @joshdover looks like this is a platform concern, is it fine to put lib into a server folder?

The second one will be resolved by #54910 (should be done soon)

[cjcenizal]

Tested locally, code LGTM. Thanks for adding this, JL!

[joshdover]

The first one looks like it is only used on the server, so it should be save to move it to a server directory together with the whole lib folder (the folder structure of this plugin is strange anyway). @joshdover looks like this is a platform concern, is it fine to put lib into a server folder?

Yep, should be good to move that one.

[LeeDr]

I'm not sure if we want the v8.0.0 label on this PR. We may be dropping support for IE11 in 8.0.0. If that decision is made, will someone remember to change the eslint rule?

[jloleysens]

@LeeDr that makes sense to me! I've also added a TODO to the lint rule.

[jloleysens]

@elasticmachine merge upstream

[lukeelmers]

LGTM

[jloleysens]

@elasticmachine merge upstream

[jloleysens]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: f4dd010

History

• 💔 Build #22315 failed 707bb44
• 💔 Build #21834 failed 04aec1f
• 💔 Build #21833 failed 514e903
• 💔 Build #20788 failed d8250a4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream