Tutorial migration #54910
Merged
Tutorial migration #54910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
Feature:Home
flash1293
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
flash1293
added
the
release_note:skip
|
Thanks for tackling this @flash1293! Maps code looks good and works as expected. I am getting the following
Follow-up: Actually, scratch that. Checked and this issue exists on master as well and shouldn't hold up this PR. May file as a small, separate issue. |
kindsun
approved these changes
Jan 21, 2020
kertal
approved these changes
Jan 22, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Jan 22, 2020
flash1293
added a commit
that referenced
this pull request
Jan 23, 2020
This was referenced Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50224
This PR migrates all tutorials to the new platform.
In a previous PR the logic for handling tutorials was already moved, this PR also moves the actual tutorials and removes the legacy API completley.
Tutorials that are based on internals of existing plugins are moved into these plugins to avoid exposing more state than necessary.
This means the EMS tutorial becomes part of the
mapsplugin and the APM tutorial becomes part of theapmplugin.There are a lot of changed lines, but most of them follow a very predictable pattern - most tutorials are basically the same with some changed labels.