Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Tutorial migration (#54910) #55563

Merged
merged 2 commits into from
Jan 23, 2020

Conversation

flash1293
Copy link
Contributor

Backports the following commits to 7.x:

@flash1293
Copy link
Contributor Author

@dgieselaar Could you check the APM changes again? There were some conflicts which I resolved with the state from master/my PR, but I'm not sure whether I pulled in too much.

@dgieselaar
Copy link
Member

Hmm, looks like CODEOWNER settings for the NP APM plugin have not been set up yet. I'll get that fixed, but that means that I didn't review the NP changes in the original PR because I use the CODEOWNER filter to review. Will do so now, my bad.

Copy link
Member

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @flash1293

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 merged commit d69ce69 into elastic:7.x Jan 23, 2020
@flash1293 flash1293 deleted the backport/7.x/pr-54910 branch January 23, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants