[Uptime] Reintroduce a column for url #55451

justinkambic · 2020-01-21T18:27:26Z

Summary

Resolves #55285.

I created this PR because it's a very nimble change. This is MVP for addressing the issue, but I'm curious to know whether we'd be in favor of Shahzad's solution instead. It'd probably make better use of space and look cleaner.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2020-01-21T18:27:29Z

Pinging @elastic/uptime (Team:uptime)

shahzad31 · 2020-01-22T08:46:29Z

x-pack/legacy/plugins/uptime/public/components/functional/monitor_list/monitor_list.tsx

+    {
+      aligh: 'left' as const,
+      field: 'state.url.full',
+      name: labels.URL,


Suggested change

name: labels.URL,

name: labels.URL,

render: (url: string, summary: MonitorSummary) => (

<>

<EuiLink href={url} target="_blank" color="text">

{url} <EuiIcon size="s" type="popout" color="subbdued" />

</EuiLink>

</>

),

We should restore it the way it originally was, i think it looked better that way.

I'm going to comment here to make sure there's a summary of a discussion had in a more ephemeral medium:

We spent some time talking about @shahzad31's idea on the original issue; the idea is to place the URL link under the location name in the second column. Feedback was mixed, some feel it is too cluttered, and there's not enough space between two clickable elements, while others like the change looks nice and conserves space.

Here's a screenshot of a "PoC"-style change to the UI.

We determined that because this patch is intended to resolve a UX bug, it was inappropriate to entertain the addition of complexity to the app targeting 7.6 after FF. We may come back to this discussion later.

justinkambic · 2020-01-24T12:59:53Z

@elasticmachine merge upstream

shahzad31

@justinkambic PR looks good, though have one design question, should we show ... for longer URLs?

andrewvc · 2020-01-24T20:49:24Z

@shahzad31 yes, I think we should abbreviate them somehow

justinkambic · 2020-01-27T14:02:01Z

@elasticmachine merge upstream

justinkambic · 2020-01-27T14:51:59Z

shahzad31 yes, I think we should abbreviate them somehow

I'll make the edit on this PR and we can re-review that commit

justinkambic · 2020-01-27T16:49:26Z

@andrewvc @shahzad31 please re-review 0bc9787

justinkambic · 2020-01-27T17:22:12Z

@elasticmachine merge upstream

shahzad31

LGTM, WFG !!

kibanamachine · 2020-01-27T18:43:17Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: d43dec7

History

💔 Build #22754 failed 0bc9787
💔 Build #22690 failed 6bd9e85
💚 Build #22363 succeeded b525da9
💔 Build #21676 failed e1b5793

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Reintroduce a column for url. * Reintroduce original URL column. * Update busted test snapshots. * Truncate long URLs. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* Reintroduce a column for url. * Reintroduce original URL column. * Update busted test snapshots. * Truncate long URLs. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

justinkambic · 2020-01-27T23:26:23Z

Backported to:

7.x/7.7.0 617dbab
[7.x] [Uptime] Reintroduce a column for url (#55451) #56074
7.6/7.6.0 ea2983e
[7.6] [Uptime] Reintroduce a column for url (#55451) #56075

…ve-out-legacy * 'master' of github.com:elastic/kibana: (187 commits) [ML] Reseting categorization validation if category field is cleared (elastic#56029) [SIEM] Fields browser readable (elastic#56000) [docs] Remove unused callout (elastic#56032) Refactor saved object management registry usage (elastic#54155) [SIEM][Detection Engine] critical blocker, updates the pre-packaged rules, removes dead ones, adds license file (elastic#56090) Fix failing snapshot artifact tests when using env var (elastic#56063) Fix Github PR comment formatting (elastic#56078) [Maps] fix join metric field selection bugs (elastic#56044) Create a new menu for observability links (elastic#54847) [SIEM] [Detection Engine] Fixes histogram intervals (elastic#55969) make test less flaky by retrying if list is re-rendered (elastic#55949) Remove matrix build support (elastic#54202) Add animation to service map layout (elastic#56042) [Canvas] Remove Angular and unnecessary reporting config from Canvas (elastic#54050) [Uptime] Simplify snapshot max to Infinity (elastic#55931) [Uptime] Reintroduce a column for url (elastic#55451) Cleanup action task params objects after successful execution (elastic#55227) [CI] Retry flaky tests (elastic#53961) Expose NP FieldFormats service to server side (elastic#55419) [Endpoint] EMT-65: make endpoint data types common, restructure (elastic#54772) ... # Conflicts: # src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/__snapshots__/split_panel.test.tsx.snap # src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/containers/panel.tsx # src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/context.tsx # src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/index.ts # src/legacy/core_plugins/console/public/np_ready/application/components/split_panel/split_panel.test.tsx # src/legacy/ui/public/vis/editors/default/default_editor.tsx # src/plugins/console/public/application/components/split_panel/__snapshots__/split_panel.test.tsx.snap # src/plugins/console/public/application/components/split_panel/components/resizer.tsx # src/plugins/console/public/application/components/split_panel/containers/panel.tsx # src/plugins/console/public/application/components/split_panel/containers/panel_container.tsx # src/plugins/console/public/application/components/split_panel/context.tsx # src/plugins/console/public/application/components/split_panel/index.ts # src/plugins/console/public/application/components/split_panel/registry.ts # src/plugins/console/public/application/components/split_panel/split_panel.test.tsx # src/plugins/kibana_react/public/split_panel/__snapshots__/split_panel.test.tsx.snap # src/plugins/kibana_react/public/split_panel/containers/panel.tsx # src/plugins/kibana_react/public/split_panel/context.tsx # src/plugins/kibana_react/public/split_panel/index.ts # src/plugins/kibana_react/public/split_panel/split_panel.test.tsx

* master: (77 commits) [ML] Reseting categorization validation if category field is cleared (elastic#56029) [SIEM] Fields browser readable (elastic#56000) [docs] Remove unused callout (elastic#56032) Refactor saved object management registry usage (elastic#54155) [SIEM][Detection Engine] critical blocker, updates the pre-packaged rules, removes dead ones, adds license file (elastic#56090) Fix failing snapshot artifact tests when using env var (elastic#56063) Fix Github PR comment formatting (elastic#56078) [Maps] fix join metric field selection bugs (elastic#56044) Create a new menu for observability links (elastic#54847) [SIEM] [Detection Engine] Fixes histogram intervals (elastic#55969) make test less flaky by retrying if list is re-rendered (elastic#55949) Remove matrix build support (elastic#54202) Add animation to service map layout (elastic#56042) [Canvas] Remove Angular and unnecessary reporting config from Canvas (elastic#54050) [Uptime] Simplify snapshot max to Infinity (elastic#55931) [Uptime] Reintroduce a column for url (elastic#55451) Cleanup action task params objects after successful execution (elastic#55227) [CI] Retry flaky tests (elastic#53961) Expose NP FieldFormats service to server side (elastic#55419) [Endpoint] EMT-65: make endpoint data types common, restructure (elastic#54772) ...

Reintroduce a column for url.

e1b5793

justinkambic added bug Fixes for quality problems that affect the customer experience v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.6.0 labels Jan 21, 2020

justinkambic self-assigned this Jan 21, 2020

shahzad31 added the release_note:skip Skip the PR/issue when compiling release notes label Jan 22, 2020

shahzad31 reviewed Jan 22, 2020

View reviewed changes

justinkambic added 2 commits January 23, 2020 09:38

Reintroduce original URL column.

24f51b4

Update busted test snapshots.

7bab44d

Merge branch 'master' into uptime_url-column

b525da9

shahzad31 approved these changes Jan 24, 2020

View reviewed changes

Merge branch 'master' into uptime_url-column

6bd9e85

Truncate long URLs.

0bc9787

Merge branch 'master' into uptime_url-column

d43dec7

justinkambic requested a review from shahzad31 January 27, 2020 17:22

shahzad31 approved these changes Jan 27, 2020

View reviewed changes

justinkambic merged commit 1df0190 into elastic:master Jan 27, 2020

justinkambic added the backport pending label Jan 27, 2020

This was referenced Jan 27, 2020

[7.x] [Uptime] Reintroduce a column for url (#55451) #56074

Merged

[7.6] [Uptime] Reintroduce a column for url (#55451) #56075

Merged

justinkambic deleted the uptime_url-column branch January 27, 2020 23:26

justinkambic removed the backport pending label Jan 27, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Uptime] Reintroduce a column for url #55451

[Uptime] Reintroduce a column for url #55451

justinkambic commented Jan 21, 2020 •

edited

Loading

elasticmachine commented Jan 21, 2020

shahzad31 Jan 22, 2020

shahzad31 Jan 22, 2020

justinkambic Jan 24, 2020

justinkambic commented Jan 24, 2020

shahzad31 left a comment

andrewvc commented Jan 24, 2020

justinkambic commented Jan 27, 2020

justinkambic commented Jan 27, 2020

justinkambic commented Jan 27, 2020

justinkambic commented Jan 27, 2020

shahzad31 left a comment

kibanamachine commented Jan 27, 2020

justinkambic commented Jan 27, 2020

-      name: labels.URL,
+      name: labels.URL,
+      render: (url: string, summary: MonitorSummary) => (
+        <>
+           <EuiLink href={url} target="_blank" color="text">
+             {url} <EuiIcon size="s" type="popout" color="subbdued" />
+           </EuiLink>
+        </>
+        ),

[Uptime] Reintroduce a column for url #55451

[Uptime] Reintroduce a column for url #55451

Conversation

justinkambic commented Jan 21, 2020 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented Jan 21, 2020

shahzad31 Jan 22, 2020

Choose a reason for hiding this comment

shahzad31 Jan 22, 2020

Choose a reason for hiding this comment

justinkambic Jan 24, 2020

Choose a reason for hiding this comment

justinkambic commented Jan 24, 2020

shahzad31 left a comment

Choose a reason for hiding this comment

andrewvc commented Jan 24, 2020

justinkambic commented Jan 27, 2020

justinkambic commented Jan 27, 2020

justinkambic commented Jan 27, 2020

justinkambic commented Jan 27, 2020

shahzad31 left a comment

Choose a reason for hiding this comment

kibanamachine commented Jan 27, 2020

💚 Build Succeeded

History

justinkambic commented Jan 27, 2020

justinkambic commented Jan 21, 2020 •

edited

Loading